New issue
Advanced search Search tips

Issue 830985 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Icon Group Titles Disappear

Reported by bmgraphi...@gmail.com, Apr 10 2018

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10452.42.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.79 Safari/537.36
Platform: 10452.42.0 (Official Build) beta-channel eve

Steps to reproduce the problem:
1. Create a group of apps
2. Enter a name for the title of the group.
3. Restart Pixelbook, title names are blank.

What is the expected behavior?
Icon group titles should remain intact and not disappear after each time the Pixelbook is turned on.

What went wrong?
The Icon Group Titles went blank.  The issue us repeatable every time.

Did this work before? Yes I think it still worked in v65

Chrome version: 66.0.3359.79  Channel: beta
OS Version: 10452.42.0
Flash Version: 29.0.0.134
 
Screenshot 2018-04-09 at 8.22.04 PM.png
235 KB View Download
Components: -UI UI>Shell>Launcher
Labels: Touch-Friendly-Launcher-Urgent
Cc: khmel@chromium.org
Labels: M-67
Owner: weidongg@chromium.org
Stable release is tomorrow, but we can fix this in M67 if it is merged.

Giving it to weidongg@ because it's folder related.
+khmel@ for possible sync issue (it occurs after the device is turned off and on).
I logged "metadata->name" in https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/chrome_app_list_item.cc?q=chrome_app_list_item&dr=C&l=75, and it prints the updated folder name each time I change the folder name. It seems the metadata is not synced to server or it is not synced from server at next login?
khmel@, when I modify the folder name, the function SendSyncChange[1] is called, but SyncStarted() [2] returns false. I am not familiar with the code in sync service, do you know when the sync should be started?
[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_list_syncable_service.cc?q=app_list_syncable_service.cc&dr&l=1003
[2] https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_list_syncable_service.cc?dr&l=992
Labels: -Pri-2 Pri-1
Labels: ReleaseBlock-Stable

Comment 8 Deleted

This may be related to 828209 so lets see if khmel@'s CL fixes this too.
Thanks, let me sync to ToT to see if it is fixed.

Comment 11 by khmel@chromium.org, Apr 18 2018

At this moment that CL was reverted due compilation problem. Please wait reland is landed.
Looks like 828209 landed so I'll see if this is fixed.
After updating to ToT, this issue is fixed but now with mutli-sign in all users have the same apps in the launcher.

I'll track this in a new bug.
Status: Fixed (was: Unconfirmed)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
https://crbug.com/836266 is the new bug.
Cc: weidongg@chromium.org
 Issue 827476  has been merged into this issue.
This is still an Issue, I am on build 66.0.3359.203 (Official Build) (64-bit)
and every time I turn off and back on my Acer Spin 11 the names of the folders disappear
Screenshot 2018-06-13 at 10.57.58 AM.png
210 KB View Download

Comment 21 by ducku...@gmail.com, Jun 13 2018

Running Version 68.0.3440.15 (Official Build) dev (64-bit), and it has been working correctly (IE labels stay, and order is constant) for me.
I wonder if it came back in later builds? I am updating to beta Version 66.0.3359.203 (Official Build) (64-bit) to see if its still there in the beta or not.

Comment 23 by dymp...@gmail.com, Jun 13 2018

It still exists on Stable 66.0.3359.203. 
It's fixed in Beta 67.0.3396.69


Google Chrome	66.0.3359.203 (Official Build) (64-bit)
Revision	0
Platform	10452.99.0 (Official Build) stable-channel auron_yuna
Firmware Version	Google_Auron_yuna.6301.59.116
ARC	4808754
JavaScript	V8 6.6.346.32
Flash	29.0.0.171 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; CrOS x86_64 10452.99.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.203 Safari/537.36
Thank you! It works for me now on the new Beta. Sweeet!
I'd rather not go to the Beta channel, but this is really bugging me. Any educated guesses as to how long it'll be until it's in the Stable channel?
I am on latest available Beta, 67 something, and it still DOES NOT work.  
How did you get Version 68.0.3440.15?

Comment 27 by dymp...@gmail.com, Jun 17 2018

bmgraphi...@,

If it's not working for you, please send feedback with hashtag # issue 830985 .

Click the 3 dot menu on the browser toolbar, then Help > Report an issue.... or use the keyboard shortcut.

1. alt + shift + i to report feedback
2. check the box to include screenshot 
3. check the box to include system info 

Copy and paste the first 4 lines of chrome://version (type into address bar)here so the devs can see which CB you have. Like this.

This issue is fixed for me on the Samsung Pro Beta channel.

Google Chrome	67.0.3396.78 (Official Build) beta (64-bit)
Revision	39679bd3daf2c313478fc0f17c11665141d3f6f9-refs/branch-heads/3396@{#753}
Platform	10575.54.0 (Official Build) beta-channel caroline
Firmware Version	Google_Caroline.7820.356.0
Customization ID	SAMSUNG-CAROLINE
ARC	4815124


Reported the issue, again.  But I am still curious where you obtained

Version *68*.0.3440.15

I have a Google Pixelbook and the latest available Beta is Version
67.0.3396.78 (Official Build) beta (64-bit)

Comment 29 by ducku...@gmail.com, Jun 17 2018

On the Dev channel, and just pull updates as they come up...see attached screen caps...


Screenshot 2018-06-17 at 2.21.00 PM.png
23.0 KB View Download
Screenshot 2018-06-17 at 2.20.41 PM.png
26.2 KB View Download
Problem solved. 
I am currently on 67.0.3396.99 (Build officiel) (64 bits) on my Asus Flip C302 and the problem is solved. Group Titles have reappeared and are stable. 
Project Member

Comment 31 by sheriffbot@chromium.org, Aug 8

Labels: -Merge-TBD

Sign in to add a comment