Opening an offline page from Astro File Manager while online opens online version of the page |
|||||||||
Issue description(Is that the right behavior?) Steps: 0. Make sure your phone is online 1. Save a page offline. Exit chromium. 2. Install and open Astro File Manager. Navigate to downloads 3. Tap on the offline page Expected: The offline page opens as an offline page Actual: The opened page has the online treatment (no "Offline" in info bar). I seem to recall some discussion about this behavior, but I don't remember the outcome, if we decided that we want the online version, OK to close this bug. If not, let's fix it.
,
Apr 10 2018
Seen on N5X running android 8.1 with Tip of Tree chromium. I was planning on this being triaged by the Offline Pages team, who normally monitors UI>Browser>Offline. I would expect it to be assigned to either myself or JianLi by Triage.
,
Apr 11 2018
Confirmed in Canary 67.0.3393.2 (and 3394.0 as well).
,
Apr 11 2018
FYI - When opening the exact same page about 10 minutes later, the UI treatment was correct, this might be some kind of race condition at work.
,
Apr 13 2018
,
Apr 19 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d6a146c44838440026aca864be890daddd1f1a commit b0d6a146c44838440026aca864be890daddd1f1a Author: Jian Li <jianli@chromium.org> Date: Thu Apr 19 21:53:13 2018 Base64 encode the intent_url value in offline page header The content:// URL can contain SPACE and other characters that are not escaped. To deal with this, we base64 encode the value. Bug: 830983 Change-Id: I8737fb1f94f1a498429af42ef53d61adfe237cc2 Reviewed-on: https://chromium-review.googlesource.com/1013087 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552174} [modify] https://crrev.com/b0d6a146c44838440026aca864be890daddd1f1a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java [modify] https://crrev.com/b0d6a146c44838440026aca864be890daddd1f1a/components/offline_pages/core/request_header/offline_page_header.cc [modify] https://crrev.com/b0d6a146c44838440026aca864be890daddd1f1a/components/offline_pages/core/request_header/offline_page_header_unittest.cc
,
Apr 19 2018
,
Apr 23 2018
,
Apr 23 2018
,
Apr 23 2018
Please confirm the fix works in canary
,
Apr 23 2018
Verified with Chrome Canary 68.0.3404.0
,
Apr 24 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ac73d257ea05d9b16877d3edd0e92ccfdd024c9 commit 7ac73d257ea05d9b16877d3edd0e92ccfdd024c9 Author: Jian Li <jianli@chromium.org> Date: Tue Apr 24 20:36:51 2018 M67: Base64 encode the intent_url value in offline page header The content:// URL can contain SPACE and other characters that are not escaped. To deal with this, we base64 encode the value. TBR=jianli@chromium.org (cherry picked from commit b0d6a146c44838440026aca864be890daddd1f1a) Bug: 830983 Change-Id: I8737fb1f94f1a498429af42ef53d61adfe237cc2 Reviewed-on: https://chromium-review.googlesource.com/1013087 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552174} Reviewed-on: https://chromium-review.googlesource.com/1026556 Reviewed-by: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#264} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/7ac73d257ea05d9b16877d3edd0e92ccfdd024c9/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java [modify] https://crrev.com/7ac73d257ea05d9b16877d3edd0e92ccfdd024c9/components/offline_pages/core/request_header/offline_page_header.cc [modify] https://crrev.com/7ac73d257ea05d9b16877d3edd0e92ccfdd024c9/components/offline_pages/core/request_header/offline_page_header_unittest.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sandeepkumars@chromium.org
, Apr 10 2018Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback