New issue
Advanced search Search tips

Issue 830967 link

Starred by 1 user
Status: Verified
Owner:
katie@chromium.org
Closed: Jul 11
Cc:
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

STS competes for focus when using "Highlight object with keyboard focus"

Project Member Reported by leberly@chromium.org, Apr 9 2018 
Google Chrome 67.0.3383.0 (Official Build) dev (64-bit)
Google_Samus.6300.276.0
Chrome OS with flag enabled: #enable-experimental-accessibility-features

# Enable STS
# Enable "Highlight object with keyboard focus" in Accessibility Settings menu or in the Status bar > Accessibility menu
# Invoke STS by holding down the search button and drawing a ring around text. I used this page: https://en.wikipedia.org/wiki/Theriodont
Note that the focus ring will flicker which is covered in  bug 830953 
# While STS is reading, start using tab around the page
Expected: the highlight object with keyboard focus will show its own highlight independent of the STS focus ring, focus ring around STS remains stable
Actual: the focus jumps back and forth between the STS focus ring and wherever the keyboard focus lands. 

Another interesting observation is that when you just enable Highlight object with keyboard focus with no other features, the highlight at first was bright green. When you use it with STS, the highlight turns pink for a bit while competing with STS but then eventually becomes orange. Even after turning off STS, it remains orange. The green highlight may have been some sort of mistake since I can't repro that green color.

Comment 1 by leberly@chromium.org, Apr 11 2018 

Note that this flickering also does reproduce on Eve at its highest resolution 2400x1600.

Comment 2 by leberly@chromium.org, Apr 18 2018 

In this bug, flickering is happening specifically while the focus ring is being drawn using search + mouse drag. It doesn't flicker after it is drawn around a node, just during the drawing process.

Comment 3 by katie@chromium.org, Jun 28 2018

Status: Started (was: Available)
See go/cros-multiple-focus-rings
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a621e47e2fb48b34b90a83fe18e745421b2c2729

commit a621e47e2fb48b34b90a83fe18e745421b2c2729
Author: Katie D <katie@chromium.org>
Date: Wed Jul 11 17:49:55 2018

Support multiple focus rects from different sources at once.

This refactors AccessibilityFocusRingController components needed
for tracking an individual group of focus rings into
AccessibilityFocusRingGroup. The Controller maps from caller_ids
to AccessibilityFocusRingGroups. Unit tests are updated to ensure
coverage.

See go/cros-multiple-focus-rings for background.

Bug:  830967 
Change-Id: Ic04c883b2445fc74747cc93e907d373fba65949f
Reviewed-on: https://chromium-review.googlesource.com/1120838
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574234}
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/BUILD.gn
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_controller.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_controller.h
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_controller_unittest.cc
[add] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_group.cc
[add] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_group.h
[add] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_focus_ring_group_unittest.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/accessibility_highlight_controller.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/accessibility/touch_exploration_manager.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/ash/public/interfaces/accessibility_focus_ring_controller.mojom
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/a621e47e2fb48b34b90a83fe18e745421b2c2729/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc

Comment 5 by katie@chromium.org, Jul 11

Labels: a11y-testers
Owner: katie@chromium.org
Status: Fixed (was: Started)

Comment 6 by katie@chromium.org, Jul 11 

 Issue 830953  has been merged into this issue.

Comment 7 by leberly@chromium.org, Jul 30

Labels: -a11y-testers
Status: Verified (was: Fixed)
Google Chrome	70.0.3505.0 (Official Build) canary (64-bit)
Firmware Version	Google_Eve.9584.160.0

Verified using steps above.
►

Sign in to add a comment