New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830946 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Replace CCT by Minimal UI in WebAPK

Project Member Reported by ranj@chromium.org, Apr 9 2018

Issue description

Use Minimal UI to handle out of scope urls instead of CCT.
 

Comment 1 by ranj@chromium.org, Apr 9 2018

This bug is part of the fix for oauth signin
https://bugs.chromium.org/p/chromium/issues/detail?id=771418

By using Minimal UI, we can keep a single navigation scope.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d

commit 1b5a273ae8c65a026e3eaa197f21d76ce10dce4d
Author: Ran Ji <ranj@chromium.org>
Date: Wed Apr 18 17:37:23 2018

Replace CCT by Minimal UI in WebAPK.

Stop opening a CCT for out-of-scope navigations from WebappActivities.

Bug:  830946 , 771418
Change-Id: Ied9c33518488f0bab38366bf2e8b8532c71e3819
Reviewed-on: https://chromium-review.googlesource.com/1003552
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551731}
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappScopePolicy.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java
[modify] https://crrev.com/1b5a273ae8c65a026e3eaa197f21d76ce10dce4d/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java

Comment 3 by ranj@chromium.org, Apr 18 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03f40f32b5c72770dbf4223dddd53e37272447a

commit d03f40f32b5c72770dbf4223dddd53e37272447a
Author: Ran Ji <ranj@chromium.org>
Date: Tue May 08 17:47:30 2018

Replace CCT by Minimal UI in WebAPK.

Stop opening a CCT for out-of-scope navigations from WebappActivities.

Bug:  830946 , 771418
Change-Id: Ied9c33518488f0bab38366bf2e8b8532c71e3819
Reviewed-on: https://chromium-review.googlesource.com/1003552
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551731}(cherry picked from commit 1b5a273ae8c65a026e3eaa197f21d76ce10dce4d)
Reviewed-on: https://chromium-review.googlesource.com/1050386
Cr-Commit-Position: refs/branch-heads/3396@{#520}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappScopePolicy.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestRule.java
[modify] https://crrev.com/d03f40f32b5c72770dbf4223dddd53e37272447a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java

Sign in to add a comment