New issue
Advanced search Search tips

Issue 830945 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrasAudioClientTest.GetNodesV2 fails on msan

Project Member Reported by thakis@chromium.org, Apr 9 2018

Issue description

[ RUN      ] CrasAudioClientTest.GetNodesV2
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: SetNameOwnerChangedCallback(8-byte object <C0-5D 01-00 40-70 00-00>)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
process 1805: Array or variant type requires that type end_dict_entry be written, but string was written.
The overall signature expected here was 'a{sv}' and we are on byte 4 of that signature.
process 1805: Writing an element of type variant, but no value is expected here
The overall signature expected here was 'a{sv}' and we are on byte 5 of that signature.
process 1805: Array or variant type wasn't expecting any more values to be written into it, but a value variant was written.
The overall signature expected here was 'a{sv}' and we are on byte 5 of that signature.
==1805==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f326b6ddd47 in write_or_verify_typecode /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-marshal-recursive.c:1727:13
    #1 0x7f326b6dd530 in _dbus_type_writer_unrecurse /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-marshal-recursive.c:2200:12
    #2 0x7f326b6f7454 in dbus_message_iter_close_container /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-message.c:2853:9
    #3 0x3378fb9 in dbus::MessageWriter::CloseContainer(dbus::MessageWriter*) ./../../dbus/message.cc:568:24
    #4 0x87bf10 in chromeos::(anonymous namespace)::WriteNodesToResponse(std::__1::vector<chromeos::AudioNode, std::__1::allocator<chromeos::AudioNode> > const&, dbus::MessageWriter*) ./../../chromeos/dbus/cras_audio_client_unittest.cc:210:16
    #5 0x8824ed in chromeos::CrasAudioClientTest_GetNodesV2_Test::TestBody() ./../../chromeos/dbus/cras_audio_client_unittest.cc:841:3
    #6 0x1d06023 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
    #7 0x1d09828 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2661:11
    #8 0x1d0b249 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2779:28
    #9 0x1d41914 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5036:43
    #10 0x1d40202 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #11 0x20a4450 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    #12 0x20a4450 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #13 0x20ae702 in Run ./../../base/callback.h:95:12
    #14 0x20ae702 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
    #15 0x20adf1e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10
    #16 0xfba598 in main ./../../chromeos/run_all_unittests.cc:15:10
    #17 0x7f3266b83f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0
    #18 0x4b1979 in _start ??:0:0
  Uninitialized value was stored to memory at
    #0 0x4d7122 in __interceptor_realloc /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:897:3
    #1 0x7f326b74c1d6 in dbus_realloc /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-memory.c:677:13
    #2 0x7f326b74ef1a in reallocate_for_length /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-string.c:352:13
    #3 0x7f326b74ef1a in set_length /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-string.c:393:0
    #4 0x7f326b74f533 in _dbus_string_lengthen /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-string.c:755:10
    #5 0x7f326b74f533 in _dbus_string_alloc_space /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-string.c:888:0
    #6 0x7f326b6dbbc9 in writer_recurse_array /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-marshal-recursive.c:1860:12
    #7 0x7f326b6dbbc9 in _dbus_type_writer_recurse_contained_len /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-marshal-recursive.c:2079:0
    #8 0x7f326b6db007 in _dbus_type_writer_recurse /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-marshal-recursive.c:2119:10
    #9 0x7f326b6f5f51 in dbus_message_iter_open_container /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-message.c:0:14
    #10 0x337899c in dbus::MessageWriter::OpenArray(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, dbus::MessageWriter*) ./../../dbus/message.cc:521:24
    #11 0x87b140 in chromeos::(anonymous namespace)::WriteNodesToResponse(std::__1::vector<chromeos::AudioNode, std::__1::allocator<chromeos::AudioNode> > const&, dbus::MessageWriter*) ./../../chromeos/dbus/cras_audio_client_unittest.cc:170:13
    #12 0x8824ed in chromeos::CrasAudioClientTest_GetNodesV2_Test::TestBody() ./../../chromeos/dbus/cras_audio_client_unittest.cc:841:3
    #13 0x1d06023 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
    #14 0x1d09828 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2661:11
    #15 0x1d0b249 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2779:28
    #16 0x1d41914 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5036:43
    #17 0x1d40202 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #18 0x20a4450 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    #19 0x20a4450 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #20 0x20ae702 in Run ./../../base/callback.h:95:12
    #21 0x20ae702 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
    #22 0x20adf1e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10
    #23 0xfba598 in main ./../../chromeos/run_all_unittests.cc:15:10
    #24 0x7f3266b83f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0
  Uninitialized value was created by a heap allocation
    #0 0x4d726d in __interceptor_malloc /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:915:3
    #1 0x7f326b74c0b4 in dbus_malloc /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-memory.c:499:13
    #2 0x7f326b74d4ae in _dbus_string_init_preallocated /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-string.c:149:15
    #3 0x7f326b6fb1fd in _dbus_message_iter_open_signature /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-message.c:2421:12
    #4 0x7f326b6f59f6 in dbus_message_iter_open_container /home/tim/chromium/src/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libdbus-1-3/dbus-1.6.18/dbus/dbus-message.c:2803:8
    #5 0x337899c in dbus::MessageWriter::OpenArray(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, dbus::MessageWriter*) ./../../dbus/message.cc:521:24
    #6 0x87b140 in chromeos::(anonymous namespace)::WriteNodesToResponse(std::__1::vector<chromeos::AudioNode, std::__1::allocator<chromeos::AudioNode> > const&, dbus::MessageWriter*) ./../../chromeos/dbus/cras_audio_client_unittest.cc:170:13
    #7 0x8824ed in chromeos::CrasAudioClientTest_GetNodesV2_Test::TestBody() ./../../chromeos/dbus/cras_audio_client_unittest.cc:841:3
    #8 0x1d06023 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
    #9 0x1d09828 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2661:11
    #10 0x1d0b249 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2779:28
    #11 0x1d41914 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5036:43
    #12 0x1d40202 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #13 0x20a4450 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2314:46
    #14 0x20a4450 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #15 0x20ae702 in Run ./../../base/callback.h:95:12
    #16 0x20ae702 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
    #17 0x20adf1e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10
    #18 0xfba598 in main ./../../chromeos/run_all_unittests.cc:15:10
    #19 0x7f3266b83f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287:0
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/instrumented_libraries_prebuilt/msan/lib/libdbus-1.so.3+0x58d47)
Exiting
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8fc38f72151224ad8cc4582cda864a7721560bc

commit a8fc38f72151224ad8cc4582cda864a7721560bc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Apr 10 02:20:11 2018

Remove msan, tsan test lists and just use asan test lists on all memory bots.

For example, angle_unittests wasn't running on the MSan bot, which wasn't
intentional.  If a test really doesn't work under e.g. TSan, it can
be added to the exceptions file instead.

For another example, https://chromium-review.googlesource.com/#/c/981787/
added cronet tests, but again not to msan.

Disable a few tests that don't pass on tsan or msan.

Bug:  830659 , 830648 ,830653, 830819 ,830944, 830945 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icac81720f32c24497942b9c056c6d6999a866ec6
Reviewed-on: https://chromium-review.googlesource.com/987477
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549382}
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/chromeos/dbus/cras_audio_client_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/third_party/blink/renderer/platform/text/text_run_test.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_context_glx_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_image_shared_memory_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcbbbc7613fc0c587a0e663bcf44ebc65904a844

commit fcbbbc7613fc0c587a0e663bcf44ebc65904a844
Author: Toni Barzic <tbarzic@chromium.org>
Date: Thu Apr 12 21:58:40 2018

Fix CrasAudioClientTest.GetNodesV2 on msan

BUG= 830945 

Change-Id: I1d2481f3b2cdc874fb36a72e951b9602cc37b56e
Reviewed-on: https://chromium-review.googlesource.com/1005441
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550376}
[modify] https://crrev.com/fcbbbc7613fc0c587a0e663bcf44ebc65904a844/chromeos/dbus/cras_audio_client_unittest.cc

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcbbbc7613fc0c587a0e663bcf44ebc65904a844

commit fcbbbc7613fc0c587a0e663bcf44ebc65904a844
Author: Toni Barzic <tbarzic@chromium.org>
Date: Thu Apr 12 21:58:40 2018

Fix CrasAudioClientTest.GetNodesV2 on msan

BUG= 830945 

Change-Id: I1d2481f3b2cdc874fb36a72e951b9602cc37b56e
Reviewed-on: https://chromium-review.googlesource.com/1005441
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550376}
[modify] https://crrev.com/fcbbbc7613fc0c587a0e663bcf44ebc65904a844/chromeos/dbus/cras_audio_client_unittest.cc

Sign in to add a comment