New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830936 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Autofill - Items under Keyboard can not be selected

Project Member Reported by dougman@chromium.org, Apr 9 2018

Issue description

Chrome Version: 67.0.3390.1
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(1) Navigate to https://rsolomakhin.github.io/autofill/
(2) Enter VR Browsing
(3) Edit a filed near the keyboard, trigger autofill

What is the expected result?
Allowing the user to dismiss the keyboard and still select the item from the autocomplete list or move the autocomplete list somewhere the user can interact with it.

What happens instead?
The autofill dialog slides under the keyboard and attempting to dismiss the keyboard results in the autofill dialog being closed.
 
Screenshot_20180409-142539.png
389 KB View Download
Owner: ymalik@chromium.org
Status: Available (was: Untriaged)

Comment 2 by tiborg@chromium.org, Apr 16 2018

Status: Assigned (was: Available)

Comment 3 by ymalik@chromium.org, Apr 17 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56801e49bbc478c5bc23d80a9573e495c7c0a601

commit 56801e49bbc478c5bc23d80a9573e495c7c0a601
Author: Yash Malik <ymalik@google.com>
Date: Wed Apr 18 14:43:48 2018

VR: Move the keyboard lower when editing web input fields

Bug:  830936 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I44792a3b2d9b4bfa971c28407f0dd0c1831f5ca6
Reviewed-on: https://chromium-review.googlesource.com/1015886
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551671}
[modify] https://crrev.com/56801e49bbc478c5bc23d80a9573e495c7c0a601/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/56801e49bbc478c5bc23d80a9573e495c7c0a601/chrome/browser/vr/ui_scene_creator.cc

Comment 5 by ymalik@chromium.org, Apr 19 2018

Labels: Merge-Rejected-67

Comment 6 by ymalik@chromium.org, Apr 19 2018

Labels: -Merge-Rejected-67 Merge-Request-67
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 20 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7533e1440defea02a470b2bb9d385c87ae01ac88

commit 7533e1440defea02a470b2bb9d385c87ae01ac88
Author: Yash Malik <ymalik@google.com>
Date: Fri Apr 20 14:56:50 2018

VR: Move the keyboard lower when editing web input fields

Bug:  830936 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I44792a3b2d9b4bfa971c28407f0dd0c1831f5ca6
Reviewed-on: https://chromium-review.googlesource.com/1015886
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551671}(cherry picked from commit 56801e49bbc478c5bc23d80a9573e495c7c0a601)
Reviewed-on: https://chromium-review.googlesource.com/1022012
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#162}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/7533e1440defea02a470b2bb9d385c87ae01ac88/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/7533e1440defea02a470b2bb9d385c87ae01ac88/chrome/browser/vr/ui_scene_creator.cc

Comment 9 by ymalik@chromium.org, Apr 20 2018

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
I can still repro this on 68.0.3420.1. 
Did it regress, or can you still repro on 67?
I can repro on 67.0.3396.29. I'm wondering though, what is the expected functionality? IMHO, I'd expect to be able to scroll the page, or to exit the keyboard while the drop down list was still open.
Cc: asimjour@chromium.org mthiesse@chromium.org
Owner: bshe@chromium.org
Yash left - Biao is this something you can pick up?
I thought there was some discussion of having the autofill appear above if there isn't room sufficient room below?

Comment 14 by bshe@chromium.org, May 10 2018

I am not familiar with keyboard but I can take a look.
It might not be trivial though as this means autofill popup need to know about keyboard boundary somehow. Do we still intend to merge back to 67? If so, aming to have the autofill appear above is probably not a very good idea.

dbbrooks@ just to confirm, when you say that you can still repo, do you mean that the autofill disappear after kb is dismissed or autofill dialog still slides under the keyboard?
Hi Biao, both things you described occur. 

1. The list of autofill items can go underneath the keyboard.
2. If the keyboard is dismissed the list of autofill items is also closed.

Comment 16 by bshe@chromium.org, May 14 2018

Status: Fixed (was: Assigned)
close this one. It sounds like that Yash already moved the keyboard lower compare to previous state (and we probably can't move further). It doesn't completely solve the problem as dbbrooks@ pointed out. But that's also expected at the moment as it is not trivial to make popup aware of Vk. And we should track the correct fix in a different bug on M68+.

Comment 17 by bshe@chromium.org, May 14 2018

oh forgot to mention that the 2nd point is consistent with clank in 2D. hide VK also hides autofill items in 2D. We want to keep them consistent.
Labels: Test-Complete
Status: Verified (was: Fixed)
This bug was considered fixed for M67 by Yash's fix to move the keyboard lower.  A better/correct fix is being investigated for M68+ release.
It has been verified in 67.

Sign in to add a comment