Only expose VR controllers as Gamepads if the appropriate flags/Origin Trials are enabled |
||||
Issue descriptionVR-specific controllers are only useful in exclusive VR mode and/or require a VR runtime. We should ensure that they are only exposed by getGamepads() if the relevant features (flags/Origin Trials) are enabled. For WebVR: Expose them if the WebVR feature is enabled. In this case, the GamepadExtensions features only affects the attributes exposed to the web and does not affect whether Gamepads are exposed. For WebXR: Expose them if the WebXRGamepadSupport feature is enabled. Do NOT expose them if just the WebXR feature is enabled.
,
Apr 12 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9556845a873d4ac52f9ea21f5c13890d732f68b0 commit 9556845a873d4ac52f9ea21f5c13890d732f68b0 Author: Bill Orr <billorr@chromium.org> Date: Thu Apr 12 08:09:35 2018 Only expose VR controllers as Gamepads when appropriate VR runtime-backed controllers should only be exposed when WebXR or WebVR APIs are available. BUG= 830935 Change-Id: I354be9e62e90e7acac3fd712fc3497c141373a47 Reviewed-on: https://chromium-review.googlesource.com/1003732 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550094} [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/device/gamepad/public/cpp/gamepad.h [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/device/vr/android/gvr/cardboard_gamepad_data_fetcher.cc [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/device/vr/oculus/oculus_gamepad_data_fetcher.cc [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/device/vr/openvr/openvr_gamepad_data_fetcher.cc [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/ppapi/shared_impl/ppb_gamepad_shared.h [modify] https://crrev.com/9556845a873d4ac52f9ea21f5c13890d732f68b0/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
,
Apr 14 2018
Bug for automated tests is https://bugs.chromium.org/p/chromium/issues/detail?id=832399.
,
Apr 17 2018
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dbbrooks@chromium.org
, Apr 9 2018