[POLICY TOOL] Show a spinner or do some other indication that 'work is happening' in the UI. |
||||
Issue description
Chrome Version: 66
What steps will reproduce the problem?
(1) Go to ('chrome://policy-tool').
(2) Click on rename session button and make the rename.
What is the expected result?
Show in the UI that work is happening, and when it is finish, remove that from the UI.
What happens instead?
There is nothing that show work in progress.
,
Apr 9 2018
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bc236e6c7d8667c7336ec80468fa9e8b529b4b3 commit 1bc236e6c7d8667c7336ec80468fa9e8b529b4b3 Author: rodmartin <rodmartin@google.com> Date: Tue Apr 10 15:09:24 2018 Changed methods of rename session to avoid use Unretained(this) This CL makes the calls to GetSessionList and DoRenameSession safe as was noted in CL 929754. Bug: 830913 Change-Id: I7ad22b5712e032f256bd46ae9f04c28255861af7 Reviewed-on: https://chromium-review.googlesource.com/996472 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#549532} [modify] https://crrev.com/1bc236e6c7d8667c7336ec80468fa9e8b529b4b3/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc [modify] https://crrev.com/1bc236e6c7d8667c7336ec80468fa9e8b529b4b3/chrome/browser/ui/webui/policy_tool_ui_handler.cc [modify] https://crrev.com/1bc236e6c7d8667c7336ec80468fa9e8b529b4b3/chrome/browser/ui/webui/policy_tool_ui_handler.h
,
Apr 10 2018
,
Apr 10 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rodmartin@google.com
, Apr 9 2018