New issue
Advanced search Search tips

Issue 830909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 0
Type: Bug



Sign in to add a comment

IndexedDB: Schema version distribution unknown, and is necessary to judge impact

Project Member Reported by dmu...@chromium.org, Apr 9 2018

Issue description

We need to know the distribution of schema version 2 vs 3 of IndexedDB databases in the wild. This will help us know the effects of our schema update fix, which wipes v2 databases that have blobs.
 

Comment 2 by dmu...@chromium.org, Apr 10 2018

Labels: -Pri-1 Merge-Request-66 Pri-0
Requesting merge - we really need this data on m66 to judge the impact of our corrupt databases.

I'd like to wait for a canary to make sure it's not causing problems.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 10 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359

Comment 5 by cma...@chromium.org, Apr 11 2018

Please merge this as soon as possible.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 11 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768

commit 9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768
Author: Daniel Murphy <dmurph@chromium.org>
Date: Wed Apr 11 18:08:57 2018

[IndexedDB] Log schema version

Bug:  830909 ,  756447 ,  829125 , 829141
Change-Id: Iaf467fbe9cf2c836bfcd761d558c3f7c0e7379a8
Reviewed-on: https://chromium-review.googlesource.com/1003281
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549653}(cherry picked from commit c757238fa2717fa08178def1faf522ad3c876416)
Reviewed-on: https://chromium-review.googlesource.com/1007942
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#684}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768/content/browser/indexed_db/indexed_db_leveldb_coding.h
[modify] https://crrev.com/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768/content/browser/indexed_db/indexed_db_reporting.cc
[modify] https://crrev.com/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768/content/browser/indexed_db/indexed_db_reporting.h
[modify] https://crrev.com/9ab30dca6ad03d9dc70f4ca9868a38f1c9b97768/tools/metrics/histograms/histograms.xml

Comment 7 by dmu...@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)

Sign in to add a comment