mac: Quicklook incorrectly opens Dictionary.app on selected string |
|||
Issue descriptionTo reproduce: 1. Select some text 2. Do a quicklook event on a blank part of the page (3-finger tap) Expected result: Nothing should happen (no text is under the tap) Actual result: Dictionary.app opens See attached video. The Dictionary.app instance opens blank, which is issue 830047 . The reason that this happens is that we incorrectly interpret "we received no string from the renderer" to mean "we were incapable of getting a string-and-point, so fall back to using Dictionary.app on whatever the currently selected text is" at [1] (moving soon, search for this bug number to find the new source location). Instead, we need to discriminate between the "we were able to successfully look for the string-and-point in the page, and there is none" situation and "we were unable to look for the string-and-point in the page, do a fallback for us". [1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_cocoa.mm?rcl=426a021c6c1c9232c2f0fd5d56b10c9eef4887d4&l=894
,
Apr 19 2018
Mac triage: over to avi@. ccameron@: does this happen in Views browser windows as well? If not, can you please tag this Hotlist-CocoaBrowser? Thanks :)
,
Apr 19 2018
It does happen with views as well. This can be super-low priority -- I only filed this to document that my quicklook changes weren't creating new regressions :)
,
Nov 26
*** UI Mass Triage*** Adding labels for expert review. We are able to reproduce this bug on latest canary #72.0.3622.0.Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by ccameron@chromium.org
, Apr 9 2018