This bug tracks the work of moving the Chrome Cleanup source code from an internal repo into Chromium.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebd464c04df2f8992e981b57adcb813f3f518f7d commit ebd464c04df2f8992e981b57adcb813f3f518f7d Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Apr 17 19:01:28 2018 Add list of command-line switches and common registry keys to Chrome Cleanup tool. R=csharp Bug: 830892 Change-Id: I8ebbeabc201571e754b8905aff9ba1b88598b48c Reviewed-on: https://chromium-review.googlesource.com/1003061 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551414} [modify] https://crrev.com/ebd464c04df2f8992e981b57adcb813f3f518f7d/chrome_cleaner/constants/BUILD.gn [add] https://crrev.com/ebd464c04df2f8992e981b57adcb813f3f518f7d/chrome_cleaner/constants/chrome_cleaner_switches.cc [add] https://crrev.com/ebd464c04df2f8992e981b57adcb813f3f518f7d/chrome_cleaner/constants/chrome_cleaner_switches.h [add] https://crrev.com/ebd464c04df2f8992e981b57adcb813f3f518f7d/chrome_cleaner/constants/common_registry_names.cc [add] https://crrev.com/ebd464c04df2f8992e981b57adcb813f3f518f7d/chrome_cleaner/constants/common_registry_names.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/952b653d5cb6b5819632e97f510ddc1672e0171d commit 952b653d5cb6b5819632e97f510ddc1672e0171d Author: Joe Mason <joenotcharles@chromium.org> Date: Tue May 01 22:51:37 2018 Add string utilities for chrome_cleaner Also adds chrome_cleaner_unittests to run the added unit tests (only enabled on the FYI bot for now). This is a separate test suite because it will have Chrome Cleaner specific setup added to it as more tests are added. Bug: 830892 Change-Id: I33181ac5ad6bba893594838bf1cb77c83cfc69c5 Reviewed-on: https://chromium-review.googlesource.com/1024972 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#555207} [modify] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/BUILD.gn [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/DEPS [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/BUILD.gn [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string16_embedded_nulls.cc [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string16_embedded_nulls.h [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string16_embedded_nulls_unittest.cc [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string_test_helpers.cc [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string_test_helpers.h [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string_util.cc [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string_util.h [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/strings/string_util_unittest.cc [add] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/chrome/chrome_cleaner/test/test_main.cc [modify] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/952b653d5cb6b5819632e97f510ddc1672e0171d/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a721e42e2338a94cffeb0b459706a196f3f15171 commit a721e42e2338a94cffeb0b459706a196f3f15171 Author: Joe Mason <joenotcharles@chromium.org> Date: Mon Jun 04 14:36:22 2018 Add proto files for chrome_cleaner R=csharp Bug: 830892 Change-Id: Ie89fdddf5ebdfba3e0d5e8ca3205de170c338759 Reviewed-on: https://chromium-review.googlesource.com/1072457 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#564084} [modify] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/BUILD.gn [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/chrome_cleaner_report.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/interface_logger.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/removal_status.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/reporter_logs.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/logging/proto/shared_data.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/proto/BUILD.gn [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/proto/file_digest.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/proto/shared_pup_enums.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/proto/spec_footprints.proto [add] https://crrev.com/a721e42e2338a94cffeb0b459706a196f3f15171/chrome/chrome_cleaner/proto/uws_spec_by_version.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a07c52e32871ec003f75bd6db18395ca66fc33f2 commit a07c52e32871ec003f75bd6db18395ca66fc33f2 Author: Olivier Li <olivierli@chromium.org> Date: Mon Jun 04 15:58:34 2018 Add chrome_cleaner/http directory Bug: 830892 Change-Id: Icd3d547eb5ce96f80de2833aa6a0c4c29fbdae97 Reviewed-on: https://chromium-review.googlesource.com/1077344 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#564106} [modify] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/BUILD.gn [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/DEPS [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/error_utils.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/error_utils.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/error_utils_unittest.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_agent.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_agent_factory.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_agent_factory.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_agent_impl.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_agent_impl.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_response.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/http_status_codes.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/internet_helpers.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/internet_helpers.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/internet_helpers_unittest.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/internet_unittest_helpers.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/internet_unittest_helpers.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/mock_http_agent_factory.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/user_agent.cc [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/user_agent.h [add] https://crrev.com/a07c52e32871ec003f75bd6db18395ca66fc33f2/chrome/chrome_cleaner/http/user_agent_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/671c02ca4a4f60f3851df81a6a7d90b3222966da commit 671c02ca4a4f60f3851df81a6a7d90b3222966da Author: Xida Chen <xidachen@chromium.org> Date: Mon Jun 04 16:28:38 2018 Revert "Add chrome_cleaner/http directory" This reverts commit a07c52e32871ec003f75bd6db18395ca66fc33f2. Reason for revert: Causing failure in here: https://ci.chromium.org/buildbot/chromium/Win%20x64/23257 Original change's description: > Add chrome_cleaner/http directory > > Bug: 830892 > Change-Id: Icd3d547eb5ce96f80de2833aa6a0c4c29fbdae97 > Reviewed-on: https://chromium-review.googlesource.com/1077344 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564106} TBR=eroman@chromium.org,mattm@chromium.org,joenotcharles@chromium.org,rhalavati@chromium.org,olivierli@chromium.org Change-Id: I011c3c495bde62ade543ed020357b4a6c38994f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1085490 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564116} [modify] https://crrev.com/671c02ca4a4f60f3851df81a6a7d90b3222966da/chrome/chrome_cleaner/BUILD.gn [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/BUILD.gn [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/DEPS [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/error_utils.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/error_utils.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/error_utils_unittest.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_agent.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_agent_factory.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_agent_factory.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_agent_impl.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_agent_impl.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_response.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/http_status_codes.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/internet_helpers.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/internet_helpers.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/internet_helpers_unittest.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/internet_unittest_helpers.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/internet_unittest_helpers.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/mock_http_agent_factory.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/user_agent.cc [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/user_agent.h [delete] https://crrev.com/1df88a3a375ed460196b68bb3d490822d00dbcc3/chrome/chrome_cleaner/http/user_agent_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12 commit f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12 Author: Olivier Li <olivierli@chromium.org> Date: Wed Jun 06 14:42:32 2018 Add chrome_cleaner/http directory Bug: 830892 Change-Id: I4e22700df6983b89e0c516c4cb7534f612a28d5e Reviewed-on: https://chromium-review.googlesource.com/1086047 Reviewed-by: proberge <proberge@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564886} [modify] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/BUILD.gn [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/DEPS [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/error_utils.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/error_utils.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/error_utils_unittest.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_agent.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_agent_factory.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_agent_factory.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_agent_impl.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_agent_impl.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_response.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/http_status_codes.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/internet_helpers.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/internet_helpers.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/internet_helpers_unittest.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/internet_unittest_helpers.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/internet_unittest_helpers.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/mock_http_agent_factory.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/user_agent.cc [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/user_agent.h [add] https://crrev.com/f9a24d5d6f4b6c11a152352cfa6d05d8c99dba12/chrome/chrome_cleaner/http/user_agent_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccad6929368005f86e4a5183990eea2ca3708383 commit ccad6929368005f86e4a5183990eea2ca3708383 Author: Joe Mason <joenotcharles@chromium.org> Date: Mon Jun 11 20:04:07 2018 Run chrome_cleaner_unittests on all Windows bots. chrome_cleaner_gtests and chromium_win_fyi_gtests were removed in https://chromium-review.googlesource.com/1093159 because they didn't run anywhere. Add chrome_cleaner_unittests back and put it on all Windows bots. Bug: 830892 Change-Id: I65a2b9cfc85a256e104762087634b22bc9a26c81 Reviewed-on: https://chromium-review.googlesource.com/1094987 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#566117} [modify] https://crrev.com/ccad6929368005f86e4a5183990eea2ca3708383/testing/buildbot/chromium.clang.json [modify] https://crrev.com/ccad6929368005f86e4a5183990eea2ca3708383/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/ccad6929368005f86e4a5183990eea2ca3708383/testing/buildbot/chromium.win.json [modify] https://crrev.com/ccad6929368005f86e4a5183990eea2ca3708383/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/ccad6929368005f86e4a5183990eea2ca3708383/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e326e4a3b782f60153150e28d59ddd4155266e7 commit 3e326e4a3b782f60153150e28d59ddd4155266e7 Author: Olivier Li <olivierli@chromium.org> Date: Wed Jul 04 15:10:37 2018 Add branding and version header generation. Bug: 830892 Change-Id: Ib5d41a5b1a70f4f26752d97096437f489d2fe239 Reviewed-on: https://chromium-review.googlesource.com/1126168 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#572571} [modify] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/BUILD.gn [add] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/CLEANER_BRANDING [add] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/REPORTER_BRANDING [add] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/VERSION [add] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/branding.h.in [add] https://crrev.com/3e326e4a3b782f60153150e28d59ddd4155266e7/chrome/chrome_cleaner/constants/version.h.in
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d0514d9c82d874a15a8686b60744da4ccdb3241 commit 0d0514d9c82d874a15a8686b60744da4ccdb3241 Author: Chris Sharp <csharp@chromium.org> Date: Wed Jul 11 14:25:00 2018 Upstream chrome_cleaner/os subdir minus unit tests The main changes were: -converting LOG(INFO) to VLOG(1) -Removing usages of Time::FromInternalValue Bug: 830892 Change-Id: I117d6d605b5ca0b82ea7d509a127fbf316f483b0 Reviewed-on: https://chromium-review.googlesource.com/1130103 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#574154} [modify] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/DEPS [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/digest_verifier.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/digest_verifier.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/disk_util.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/disk_util.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/disk_util_types.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/disk_util_types.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/early_exit.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/early_exit.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_path_sanitization.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_path_sanitization.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_path_set.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_path_set.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_removal_status_updater.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_removal_status_updater.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_remover.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_remover.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/file_remover_api.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/initializer.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/initializer.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/layered_service_provider_api.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/layered_service_provider_wrapper.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/layered_service_provider_wrapper.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/nt_internals.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/post_reboot_registration.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/post_reboot_registration.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/pre_fetched_paths.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/pre_fetched_paths.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/process.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/process.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/rebooter.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/rebooter.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/rebooter_api.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry_override_manager.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry_override_manager.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry_util.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/registry_util.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/resource_util.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/resource_util.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/scoped_disable_wow64_redirection.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/scoped_disable_wow64_redirection.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/scoped_service_handle.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/scoped_service_handle.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/secure_dll_loading.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/secure_dll_loading.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/shutdown_watchdog.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/shutdown_watchdog.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/system_util.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/system_util.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/system_util_cleaner.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/system_util_cleaner.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/task_scheduler.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/task_scheduler.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/whitelisted_directory.cc [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/os/whitelisted_directory.h [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/0d0514d9c82d874a15a8686b60744da4ccdb3241/chrome/chrome_cleaner/test/test_branding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d commit ba563dc09526aa400b0e6dfce5d9bcefaad43e8d Author: Olivier Li <olivierli@chromium.org> Date: Fri Jul 13 14:50:11 2018 Add the settings directory Bug: 830892 Change-Id: I665849d42d4af63171a972eaa10d9670b23f8899 Reviewed-on: https://chromium-review.googlesource.com/1134220 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574914} [modify] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/constants/chrome_cleaner_switches.cc [modify] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/constants/chrome_cleaner_switches.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/engines/BUILD.gn [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/engines/dummy_engine_resources.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/engines/engine_resources.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/BUILD.gn [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/DEPS [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/cleaner_settings_definitions.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/cleaner_settings_unittest.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/default_matching_options.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/default_matching_options.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/matching_options.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/matching_options.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/other_settings_definitions.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/reporter_settings_definitions.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/reporter_settings_unittest.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/settings.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/settings.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/settings_definitions.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/settings_types.h [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/settings/settings_unittest.cc [modify] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/test/DEPS [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/test/test_name_helper.cc [add] https://crrev.com/ba563dc09526aa400b0e6dfce5d9bcefaad43e8d/chrome/chrome_cleaner/test/test_name_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/912f4b449d9eaaf8b5cafcef887fa02912ee2d86 commit 912f4b449d9eaaf8b5cafcef887fa02912ee2d86 Author: Chris Sharp <csharp@chromium.org> Date: Mon Jul 16 20:41:44 2018 Move empty_dll, scoped_file and test_strings to the Chromium repo Bug: 830892 Change-Id: I0621b9b69cd84e539231e535562f7c34b75fa1ca Reviewed-on: https://chromium-review.googlesource.com/1136941 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#575412} [modify] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/empty_dll.cc [add] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/scoped_file.cc [add] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/scoped_file.h [add] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/test_strings.cc [add] https://crrev.com/912f4b449d9eaaf8b5cafcef887fa02912ee2d86/chrome/chrome_cleaner/test/test_strings.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb31578254ac036fe8445c9828d837aa8693c79e commit bb31578254ac036fe8445c9828d837aa8693c79e Author: Olivier Li <olivierli@chromium.org> Date: Tue Jul 17 21:07:41 2018 Add the pup_data directory Bug: 830892 Change-Id: Id148e1503564e86f220a6a775aa9055294e465b1 Reviewed-on: https://chromium-review.googlesource.com/1140198 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575771} [modify] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/proto/uws_spec_by_version.proto [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/BUILD.gn [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/dynamic_pup.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/dynamic_pup.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/dynamic_pup_unittest.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_cleaner_util.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_cleaner_util.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_cleaner_util_unittest.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_data.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_data.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_data_unittest.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_disk_util.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_disk_util.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/pup_disk_util_unittest.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/test_uws.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/test_uws.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/pup_data/uws_catalog.h [modify] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_file_util.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_file_util.h [modify] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_main.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_pup_data.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_pup_data.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_registry_util.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_registry_util.h [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_signatures.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_uws_catalog.cc [add] https://crrev.com/bb31578254ac036fe8445c9828d837aa8693c79e/chrome/chrome_cleaner/test/test_uws_catalog.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec commit f18ad704e7ee2ffa04f8cef7d45a8159496a32ec Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Jul 19 21:07:56 2018 Add chrome_cleaner test resources and scripts to compute digest of empty DLL R=csharp Bug: 830892 Change-Id: Ia98a43f14b355ef58582ee610f70f938a7056e64 Reviewed-on: https://chromium-review.googlesource.com/1144259 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576624} [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/test/resources/BUILD.gn [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/test/resources/resource_ids [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/test/resources/test_resources.grd [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/test/resources/test_text.txt [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/tools/compute_digests.py [add] https://crrev.com/f18ad704e7ee2ffa04f8cef7d45a8159496a32ec/chrome/chrome_cleaner/tools/import_util.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47a44d77e048b49dea46b0a36f09996f52518061 commit 47a44d77e048b49dea46b0a36f09996f52518061 Author: Joe Mason <joenotcharles@chromium.org> Date: Mon Jul 23 20:33:28 2018 chrome_cleaner/os unit tests, part 1: a-f Also add test_util add extra setup that uses it to the test harness/ Bug: 830892 Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d Reviewed-on: https://chromium-review.googlesource.com/1141146 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#577240} [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/DEPS [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/digest_verifier_unittest.cc [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/disk_util.h [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/disk_util_unittest.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/file_path_sanitization_unittest.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/file_path_set_unittest.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/file_removal_status_updater_unittest.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/os/file_remover_unittest.cc [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/reboot_deletion_helper.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/reboot_deletion_helper.h [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/reboot_deletion_helper_unittest.cc [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/BUILD.gn [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/signed_dll/README.md [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.crt [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.pfx [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_key.key [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/resources/signed_dll/signed_empty_dll.dll [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_executables.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_executables.h [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_layered_service_provider.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_layered_service_provider.h [modify] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_main.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_process_main.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_service_main.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_util.cc [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_util.h [add] https://crrev.com/47a44d77e048b49dea46b0a36f09996f52518061/chrome/chrome_cleaner/test/test_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aa87588310f489658a5238241949d409f717a71 commit 6aa87588310f489658a5238241949d409f717a71 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Jul 24 06:35:51 2018 Revert "chrome_cleaner/os unit tests, part 1: a-f" This reverts commit 47a44d77e048b49dea46b0a36f09996f52518061. Reason for revert: Test failures on some bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2064 ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(892): error: Value of: HasZoneIdentifier(target_exe_path) Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x00007FF663FC6FE0+80] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF663FE254A+90] testing::internal::AssertHelper::operator= [0x00007FF663FE204A+90] chrome_cleaner::DiskUtilTests_ZoneIdentifierWhenProcessIsRunning_Test::TestBody [0x00007FF663EECF4C+2924] ../../chrome/chrome_cleaner/os/disk_util_unittest.cc(897): error: Value of: base::ReadFileToString(stream_path, &content) Actual: false Expected: true Original change's description: > chrome_cleaner/os unit tests, part 1: a-f > > Also add test_util add extra setup that uses it to the test harness/ > > Bug: 830892 > Change-Id: Iae1bb4323f6a0b25339d13e702135c2a3625c99d > Reviewed-on: https://chromium-review.googlesource.com/1141146 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577240} TBR=csharp@chromium.org,pennymac@chromium.org,joenotcharles@chromium.org Change-Id: Icf4ceab27056789e7aeb20f7c979aa9a3e52f3f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1147961 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577439} [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/DEPS [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/os/BUILD.gn [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/digest_verifier_unittest.cc [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/os/disk_util.h [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/disk_util_unittest.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/file_path_sanitization_unittest.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/file_path_set_unittest.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/file_removal_status_updater_unittest.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/os/file_remover_unittest.cc [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/test/BUILD.gn [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/reboot_deletion_helper.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/reboot_deletion_helper.h [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/reboot_deletion_helper_unittest.cc [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/test/resources/BUILD.gn [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/resources/signed_dll/README.md [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.crt [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.pfx [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_key.key [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/resources/signed_dll/signed_empty_dll.dll [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_executables.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_executables.h [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_layered_service_provider.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_layered_service_provider.h [modify] https://crrev.com/6aa87588310f489658a5238241949d409f717a71/chrome/chrome_cleaner/test/test_main.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_process_main.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_service_main.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_util.cc [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_util.h [delete] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/chrome_cleaner/test/test_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d commit d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Jul 25 20:15:13 2018 Reland "chrome_cleaner/os unit tests, part 1: a-f" with failing tests disabled DiskUtilTests.ZoneIdentifierWhenProcessIsRunning fails with component builds because it involves copying test_process.exe before running it, and in a component build the copy does not include the component DLLs so the exe will not start. Disabling the test for now. This relands commit 47a44d77e048b49dea46b0a36f09996f52518061: chrome_cleaner/os unit tests, part 1: a-f Also add test_util add extra setup that uses it to the test harness/ R=csharp Bug: 830892 Change-Id: If819a529b03683748abffe2230667d794e576b55 Reviewed-on: https://chromium-review.googlesource.com/1150213 Reviewed-by: Penny MacNeil <pennymac@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#578033} [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/DEPS [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/digest_verifier_unittest.cc [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/disk_util.h [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/disk_util_unittest.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/file_path_sanitization_unittest.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/file_path_set_unittest.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/file_removal_status_updater_unittest.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/os/file_remover_unittest.cc [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/reboot_deletion_helper.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/reboot_deletion_helper.h [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/reboot_deletion_helper_unittest.cc [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/BUILD.gn [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/signed_dll/README.md [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.crt [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_cert.pfx [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/signed_dll/cleaner_test_key.key [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/resources/signed_dll/signed_empty_dll.dll [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_executables.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_executables.h [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_layered_service_provider.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_layered_service_provider.h [modify] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_main.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_process_main.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_service_main.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_util.cc [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_util.h [add] https://crrev.com/d56ed8048aea7cb3ae6807e741fb31d4e2b6ba7d/chrome/chrome_cleaner/test/test_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/488b309ecb29420293150a6b02d29b399a09db70 commit 488b309ecb29420293150a6b02d29b399a09db70 Author: Joe Mason <joenotcharles@chromium.org> Date: Fri Jul 27 19:04:43 2018 chrome_cleaner/os unit tests, part 2: g-r Remove unused chrome_cleaner::RegistryOverrideManager. All tests now use registry_util::RegistryOverrideManager. R=csharp Bug: 830892 Change-Id: Ife5ed1075176436e470bac0aeb02ac271409aea5 Reviewed-on: https://chromium-review.googlesource.com/1150681 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#578738} [modify] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/post_reboot_registration_unittest.cc [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/pre_fetched_paths_unittest.cc [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/process_unittest.cc [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/rebooter_unittest.cc [delete] https://crrev.com/49da6702b16031c40d63e5618de03a32ff6c197e/chrome/chrome_cleaner/os/registry_override_manager.cc [delete] https://crrev.com/49da6702b16031c40d63e5618de03a32ff6c197e/chrome/chrome_cleaner/os/registry_override_manager.h [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/registry_unittest.cc [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/registry_util_unittest.cc [add] https://crrev.com/488b309ecb29420293150a6b02d29b399a09db70/chrome/chrome_cleaner/os/resource_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e55c0dadeacf5553ea396a2de7600c651738fbf1 commit e55c0dadeacf5553ea396a2de7600c651738fbf1 Author: Joe Mason <joenotcharles@chromium.org> Date: Fri Jul 27 19:27:27 2018 chrome_cleaner/os unit tests, part 3: s-z R=csharp Bug: 830892 Change-Id: I8e4af3d60d35a4b4af24267bb9967bca4ac5b5cc Reviewed-on: https://chromium-review.googlesource.com/1150808 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578746} [modify] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/shutdown_watchdog_unittest.cc [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/system_util_cleaner_unittest.cc [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/system_util_unittest.cc [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/task_scheduler_unittest.cc [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/os/whitelisted_directory_unittest.cc [modify] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/test/test_scoped_service_handle.cc [add] https://crrev.com/e55c0dadeacf5553ea396a2de7600c651738fbf1/chrome/chrome_cleaner/test/test_scoped_service_handle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0a8a7071d621333c6439792c1a2205b709551cb commit f0a8a7071d621333c6439792c1a2205b709551cb Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Jul 31 19:03:48 2018 Add ComputeSHA256DigestOfString function to chrome_cleaner/os Bug: 830892 Change-Id: I3b900e68527f31cfd52cc27d98cfcdd3a22d001b Reviewed-on: https://chromium-review.googlesource.com/1147497 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#579511} [modify] https://crrev.com/f0a8a7071d621333c6439792c1a2205b709551cb/chrome/chrome_cleaner/os/digest_verifier.cc [modify] https://crrev.com/f0a8a7071d621333c6439792c1a2205b709551cb/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/f0a8a7071d621333c6439792c1a2205b709551cb/chrome/chrome_cleaner/os/disk_util.h [modify] https://crrev.com/f0a8a7071d621333c6439792c1a2205b709551cb/chrome/chrome_cleaner/os/disk_util_unittest.cc [modify] https://crrev.com/f0a8a7071d621333c6439792c1a2205b709551cb/chrome/chrome_cleaner/test/test_service_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec4400b28a913290681684212c9dfccb5ea103ed commit ec4400b28a913290681684212c9dfccb5ea103ed Author: Olivier Li <olivierli@chromium.org> Date: Tue Jul 31 19:50:44 2018 Add chrome/chrome_cleaner to the _CheckSpamLogging whitelist. The chrome_cleaner logs are separate from Chrome's. Bug: 830892 Change-Id: Idb89dfc5f477451b8135e5cbe9cf02a256473aca Reviewed-on: https://chromium-review.googlesource.com/1157077 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#579537} [modify] https://crrev.com/ec4400b28a913290681684212c9dfccb5ea103ed/PRESUBMIT.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e63be647a452a23a177b5c4ac33d2603abaea132 commit e63be647a452a23a177b5c4ac33d2603abaea132 Author: Olivier Li <olivierli@chromium.org> Date: Thu Aug 02 14:10:22 2018 Add logging and chrome_utils directories Bug: 830892 Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045 Reviewed-on: https://chromium-review.googlesource.com/1158719 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580163} [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/DEPS [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/BUILD.gn [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/DEPS [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/chrome_util.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/chrome_util.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/extensions_util.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/http/http_agent_factory.cc [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/http/http_agent_factory.h [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/http/mock_http_agent_factory.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/BUILD.gn [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/api_keys.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/cleaner_logging_definitions.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/cleaner_logging_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/cleaner_logging_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/detailed_info_sampler.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/detailed_info_sampler.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/detailed_info_sampler_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/dummy_api_keys.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/info_sampler.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/interface_log_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/interface_log_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/interface_log_service_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/logging_definitions.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/logging_service_api.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/logging_service_api.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/message_builder.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/message_builder.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/message_builder_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/mock_logging_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/mock_logging_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/network_checker.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/noop_logging_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/noop_logging_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/other_logging_definitions.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/pending_logs_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/pending_logs_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/pending_logs_service_unittest.cc [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/proto/chrome_cleaner_report.proto [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/proto/interface_logger.proto [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/proto/shared_data.proto [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/registry_logger.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/registry_logger.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/registry_logger_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/reporter_logging_definitions.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/reporter_logging_service.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/reporter_logging_service.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/reporter_logging_service_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/safe_browsing_reporter.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/safe_browsing_reporter.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/safe_browsing_reporter_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/scoped_logging.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/scoped_logging.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/scoped_timed_task_logger.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/scoped_timed_task_logger.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/scoped_timed_task_logger_unittest.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/test_utils.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/test_utils.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/utils.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/utils.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/logging/utils_unittest.cc [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/test/test_settings_util.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/test/test_settings_util.h [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/test/test_task_scheduler.cc [add] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/chrome/chrome_cleaner/test/test_task_scheduler.h [modify] https://crrev.com/e63be647a452a23a177b5c4ac33d2603abaea132/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d commit ec57bf7827e47a8db197b6a57f53d42f88b0fa2d Author: Ned Nguyen <nednguyen@google.com> Date: Thu Aug 02 15:19:43 2018 Revert "Add logging and chrome_utils directories" This reverts commit e63be647a452a23a177b5c4ac33d2603abaea132. Reason for revert: breaking generate_build_files on chromium.perf/Win Builder Perf Original change's description: > Add logging and chrome_utils directories > > Bug: 830892 > Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045 > Reviewed-on: https://chromium-review.googlesource.com/1158719 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580163} TBR=pkasting@chromium.org,joenotcharles@chromium.org,dullweber@chromium.org,olivierli@chromium.org Change-Id: I295b58fdf9300e681b985c93b6f68b0ec0702da0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1160881 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#580181} [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/DEPS [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/BUILD.gn [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/DEPS [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/chrome_util.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/chrome_util.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/extensions_util.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/http/http_agent_factory.cc [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/http/http_agent_factory.h [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/http/mock_http_agent_factory.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/BUILD.gn [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/api_keys.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/cleaner_logging_definitions.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/cleaner_logging_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/cleaner_logging_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/detailed_info_sampler.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/detailed_info_sampler.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/detailed_info_sampler_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/dummy_api_keys.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/info_sampler.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/interface_log_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/interface_log_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/interface_log_service_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/logging_definitions.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/logging_service_api.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/logging_service_api.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/message_builder.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/message_builder.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/message_builder_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/mock_logging_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/mock_logging_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/network_checker.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/noop_logging_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/noop_logging_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/other_logging_definitions.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/pending_logs_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/pending_logs_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/pending_logs_service_unittest.cc [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/logging/proto/chrome_cleaner_report.proto [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/logging/proto/interface_logger.proto [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/logging/proto/shared_data.proto [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/registry_logger.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/registry_logger.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/registry_logger_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/reporter_logging_definitions.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/reporter_logging_service.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/reporter_logging_service.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/reporter_logging_service_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/safe_browsing_reporter.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/safe_browsing_reporter.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/safe_browsing_reporter_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/scoped_logging.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/scoped_logging.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/scoped_timed_task_logger.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/scoped_timed_task_logger.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/scoped_timed_task_logger_unittest.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/test_utils.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/test_utils.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/utils.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/utils.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/logging/utils_unittest.cc [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/chrome/chrome_cleaner/test/BUILD.gn [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/test/test_settings_util.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/test/test_settings_util.h [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/test/test_task_scheduler.cc [delete] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/chrome_cleaner/test/test_task_scheduler.h [modify] https://crrev.com/ec57bf7827e47a8db197b6a57f53d42f88b0fa2d/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a10cf40828deb75fa74d3342fa671c24078b71e commit 8a10cf40828deb75fa74d3342fa671c24078b71e Author: Olivier Li <olivierli@chromium.org> Date: Thu Aug 02 18:24:47 2018 Reland : Add logging and chrome_utils directories This relands commit e63be647a452a23a177b5c4ac33d2603abaea132. This originally got reverted because it broke generate_build_files on chromium.perf/Win Builder. Bug: 830892 Original change's description: > Add logging and chrome_utils directories > > Bug: 830892 > Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045 > Reviewed-on: https://chromium-review.googlesource.com/1158719 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580163} TBR=pkasting@chromium.org,joenotcharles@chromium.org,dullweber@chromium.org Change-Id: I526ff309c639ef26c8a8f2e98722aa730cc3e911 Reviewed-on: https://chromium-review.googlesource.com/1160776 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580254} [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/DEPS [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/BUILD.gn [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/DEPS [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/chrome_util.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/chrome_util.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/extensions_util.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/http/http_agent_factory.cc [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/http/http_agent_factory.h [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/http/mock_http_agent_factory.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/BUILD.gn [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/api_keys.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/cleaner_logging_definitions.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/cleaner_logging_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/cleaner_logging_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/detailed_info_sampler.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/detailed_info_sampler.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/detailed_info_sampler_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/dummy_api_keys.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/info_sampler.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/interface_log_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/interface_log_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/interface_log_service_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/logging_definitions.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/logging_service_api.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/logging_service_api.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/message_builder.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/message_builder.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/message_builder_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/mock_logging_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/mock_logging_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/network_checker.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/noop_logging_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/noop_logging_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/other_logging_definitions.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/pending_logs_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/pending_logs_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/pending_logs_service_unittest.cc [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/proto/chrome_cleaner_report.proto [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/proto/interface_logger.proto [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/proto/shared_data.proto [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/registry_logger.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/registry_logger.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/registry_logger_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/reporter_logging_definitions.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/reporter_logging_service.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/reporter_logging_service.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/reporter_logging_service_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/safe_browsing_reporter.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/safe_browsing_reporter.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/safe_browsing_reporter_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/scoped_logging.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/scoped_logging.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/scoped_timed_task_logger.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/scoped_timed_task_logger.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/scoped_timed_task_logger_unittest.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/test_utils.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/test_utils.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/utils.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/utils.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/logging/utils_unittest.cc [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/settings/BUILD.gn [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/test/test_settings_util.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/test/test_settings_util.h [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/test/test_task_scheduler.cc [add] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/chrome/chrome_cleaner/test/test_task_scheduler.h [modify] https://crrev.com/8a10cf40828deb75fa74d3342fa671c24078b71e/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e11ce38cc7fff1e42385314ed08a4c9bc4565df commit 7e11ce38cc7fff1e42385314ed08a4c9bc4565df Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Aug 07 19:52:42 2018 Fix remove internal codename from chrome_cleaner/settings R=proberge Bug: 830892 Change-Id: I2dca13dc4046021fa7091ae737b4dba093c6e87f Reviewed-on: https://chromium-review.googlesource.com/1165844 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#581316} [modify] https://crrev.com/7e11ce38cc7fff1e42385314ed08a4c9bc4565df/chrome/chrome_cleaner/constants/chrome_cleaner_switches.cc [modify] https://crrev.com/7e11ce38cc7fff1e42385314ed08a4c9bc4565df/chrome/chrome_cleaner/settings/settings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e00760c6a1f5c6c2c83759c5707b68f86efb7136 commit e00760c6a1f5c6c2c83759c5707b68f86efb7136 Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Aug 07 23:20:12 2018 Add chrome_cleaner/crash dir Also add crash and logging deps to test_main.cc R=proberge Bug: 830892 Change-Id: I1fae62bfcff0beded07a1827cab1d58dab79f3ac Reviewed-on: https://chromium-review.googlesource.com/1163635 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581388} [modify] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/BUILD.gn [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/DEPS [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crash_client.h [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crash_keys.cc [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crash_keys.h [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crash_reporter.h [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crashpad_crash_client.cc [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crashpad_crash_client.h [add] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/crash/crashpad_crash_reporter.cc [modify] https://crrev.com/e00760c6a1f5c6c2c83759c5707b68f86efb7136/chrome/chrome_cleaner/test/test_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d47866cda53b29774b22c0e3e503a1797878d249 commit d47866cda53b29774b22c0e3e503a1797878d249 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Aug 08 14:16:48 2018 Add chrome_cleaner/ipc dir Also add missing functions to chrome_cleaner/os needed by IPC unit tests. R=proberge Bug: 830892 Change-Id: Ibc9f4e919264d2e54cbc9808574639abb879b63e Reviewed-on: https://chromium-review.googlesource.com/1161283 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#581555} [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/BUILD.gn [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/DEPS [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.h [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/chrome_prompt_ipc_unittest.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/ipc_test_util.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/ipc_test_util.h [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/mock_chrome_prompt_ipc.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/mock_chrome_prompt_ipc.h [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/mojo_task_runner.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/mojo_task_runner.h [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/mojo_task_runner_unittest.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/sandbox.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/sandbox.h [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/ipc/sandbox_unittest.cc [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/os/BUILD.gn [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/os/inheritable_event.cc [add] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/os/inheritable_event.h [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/os/initializer.cc [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/os/initializer.h [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/test/BUILD.gn [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/test/test_executables.cc [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/test/test_main.cc [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/test/test_util.cc [modify] https://crrev.com/d47866cda53b29774b22c0e3e503a1797878d249/chrome/chrome_cleaner/test/test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/576c7e134e5ce40b4ef09482600d9bd51f52d152 commit 576c7e134e5ce40b4ef09482600d9bd51f52d152 Author: Joe Mason <joenotcharles@chromium.org> Date: Sat Aug 11 01:31:32 2018 Mojo: Add ArrayTraits for std::unordered_set This is required to typemap chrome_cleaner::PUPData. R=rockot Bug: 830892 Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e Reviewed-on: https://chromium-review.googlesource.com/1171736 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582416} [modify] https://crrev.com/576c7e134e5ce40b4ef09482600d9bd51f52d152/mojo/public/cpp/bindings/array_traits_stl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a12bc8f7a25464580101a8308c6c455fe62b6d9 commit 0a12bc8f7a25464580101a8308c6c455fe62b6d9 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Aug 22 15:28:43 2018 Add chrome_cleaner sandboxed engine Mojo interfaces R=wfh Bug: 830892 Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 Reviewed-on: https://chromium-review.googlesource.com/1171737 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585025} [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/OWNERS [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/cleaner_engine_requests.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/engine_file_requests.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/engine_requests.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/engine_sandbox.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/pup.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/string16_embedded_nulls.mojom [add] https://crrev.com/0a12bc8f7a25464580101a8308c6c455fe62b6d9/chrome/chrome_cleaner/interfaces/windows_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15a955f8cb3c2ad8942e5829b5498331ae37ed4b commit 15a955f8cb3c2ad8942e5829b5498331ae37ed4b Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 23 05:24:29 2018 Add chrome_cleaner/scanner dir R=csharp Bug: 830892 Change-Id: I8af09ba27cbc35d7bff39f4b7b6a9c972f1afc0d Reviewed-on: https://chromium-review.googlesource.com/1175202 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585405} [modify] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/BUILD.gn [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/matcher_util.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/matcher_util.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/matcher_util_unittest.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/scanner.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/scanner_controller.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/scanner_controller.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/signature_matcher.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/signature_matcher.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/signature_matcher_api.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/signature_matcher_unittest.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/urza_scanner_controller.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/urza_scanner_controller.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/urza_scanner_impl.cc [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/urza_scanner_impl.h [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc [modify] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/15a955f8cb3c2ad8942e5829b5498331ae37ed4b/chrome/chrome_cleaner/test/test_signature_matcher.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86ba94de312026b0488f0e73d91c1b018952309d commit 86ba94de312026b0488f0e73d91c1b018952309d Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 23 05:57:13 2018 Add chrome_cleaner/json_parser This does not use services/data_decoder because it's closely tied to the service manager, which chrome_cleaner does not support. R=csharp Bug: 830892 Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 Reviewed-on: https://chromium-review.googlesource.com/1180349 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585408} [modify] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/interfaces/json_parser.mojom [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/interfaces/test_mojo_sandbox_hooks.mojom [modify] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/ipc/BUILD.gn [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks_unittest.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/BUILD.gn [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/json_parser_api.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/json_parser_impl.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/json_parser_impl.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/json_parser_impl_unittest.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandbox_setup_unittest.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.h [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/test_json_parser.cc [add] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/json_parser/test_json_parser.h [modify] https://crrev.com/86ba94de312026b0488f0e73d91c1b018952309d/chrome/chrome_cleaner/settings/settings_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9bebf445b16fb83db26954fc61d4f8948b9ab95 commit c9bebf445b16fb83db26954fc61d4f8948b9ab95 Author: Hayato Ito <hayato@chromium.org> Date: Thu Aug 23 06:39:57 2018 Revert "Add chrome_cleaner/json_parser" This reverts commit 86ba94de312026b0488f0e73d91c1b018952309d. Reason for revert: Compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/1338 log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8937424896625406016/+/steps/compile/0/stdout In file included from gen\chrome/chrome_cleaner/interfaces/pup.mojom-blink.h:25: ../..\mojo/public/cpp/bindings/struct_ptr.h(96,18): error: no member named 'Hash' in 'chrome_cleaner::mojom::blink::FilePath' return ptr_->Hash(seed); Original change's description: > Add chrome_cleaner/json_parser > > This does not use services/data_decoder because it's closely tied to > the service manager, which chrome_cleaner does not support. > > R=​csharp > > Bug: 830892 > Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 > Reviewed-on: https://chromium-review.googlesource.com/1180349 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585408} TBR=csharp@chromium.org,tsepez@chromium.org,joenotcharles@chromium.org Change-Id: I10a119dfbdbc34ba06ad3d5c3d18ef4a8a5d09a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1186241 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585413} [modify] https://crrev.com/c9bebf445b16fb83db26954fc61d4f8948b9ab95/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/c9bebf445b16fb83db26954fc61d4f8948b9ab95/chrome/chrome_cleaner/interfaces/BUILD.gn [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/interfaces/json_parser.mojom [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/interfaces/test_mojo_sandbox_hooks.mojom [modify] https://crrev.com/c9bebf445b16fb83db26954fc61d4f8948b9ab95/chrome/chrome_cleaner/ipc/BUILD.gn [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks_unittest.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/BUILD.gn [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/json_parser_api.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/json_parser_impl.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/json_parser_impl.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/json_parser_impl_unittest.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandbox_setup_unittest.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.h [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/test_json_parser.cc [delete] https://crrev.com/0a53b73ec4e8e80c4f34d0a90625773b8affbdf4/chrome/chrome_cleaner/json_parser/test_json_parser.h [modify] https://crrev.com/c9bebf445b16fb83db26954fc61d4f8948b9ab95/chrome/chrome_cleaner/settings/settings_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dd16ecbd1c7498ac8cfac0706bc57e231133acf commit 8dd16ecbd1c7498ac8cfac0706bc57e231133acf Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 23 14:41:51 2018 Revert "Add chrome_cleaner sandboxed engine Mojo interfaces" This reverts commit 0a12bc8f7a25464580101a8308c6c455fe62b6d9. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1186241 reverted a related patch, but the error in the log was from pup.mojom, which is in this patch. Reverting both patches until I can find the root cause. Original change's description: > Add chrome_cleaner sandboxed engine Mojo interfaces > > R=​wfh > > Bug: 830892 > Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 > Reviewed-on: https://chromium-review.googlesource.com/1171737 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585025} TBR=joenotcharles@chromium.org,wfh@chromium.org Change-Id: Ieaf8c3d4e8557361e79084b18708f786b88c8473 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1186781 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585484} [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/BUILD.gn [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/OWNERS [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/cleaner_engine_requests.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/engine_file_requests.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/engine_requests.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/engine_sandbox.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/pup.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/string16_embedded_nulls.mojom [delete] https://crrev.com/023e0f3b37728dd36c527b2d88a2abf0aa814e1b/chrome/chrome_cleaner/interfaces/windows_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61e1ede34791acc3b63d83f13e6d4b4285c00ae4 commit 61e1ede34791acc3b63d83f13e6d4b4285c00ae4 Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Aug 28 14:22:52 2018 Reland "Add chrome_cleaner sandboxed engine Mojo interfaces" This relands commit 0a12bc8f7a25464580101a8308c6c455fe62b6d9, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1186781. This is identical to 0a12bc8f7a25464580101a8308c6c455fe62b6d9 but adds disable_variants = true to all chrome_cleaner mojo interfaces to prevent the blink and non-C++ variants from being built. Original change's description: > Add chrome_cleaner sandboxed engine Mojo interfaces > > R=wfh > > Bug: 830892 > Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 > Reviewed-on: https://chromium-review.googlesource.com/1171737 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585025} Bug: 830892 Change-Id: Ib476d03e0c3aba44c55bb0b4b26b6c38369e6b12 Reviewed-on: https://chromium-review.googlesource.com/1187004 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586683} [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/OWNERS [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/cleaner_engine_requests.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/engine_file_requests.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/engine_requests.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/engine_sandbox.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/pup.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/string16_embedded_nulls.mojom [add] https://crrev.com/61e1ede34791acc3b63d83f13e6d4b4285c00ae4/chrome/chrome_cleaner/interfaces/windows_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e70a2ce168938f7ef352eaded6b62e7a658ce2e2 commit e70a2ce168938f7ef352eaded6b62e7a658ce2e2 Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Aug 28 19:23:06 2018 Reland "Add chrome_cleaner/json_parser" This is a reland of 86ba94de312026b0488f0e73d91c1b018952309d, with one change: it uses the chrome_cleaner_mojo build template introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1187004 to disable the blink variants of all interfaces. Original change's description: > Add chrome_cleaner/json_parser > > This does not use services/data_decoder because it's closely tied to > the service manager, which chrome_cleaner does not support. > > R=csharp > > Bug: 830892 > Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 > Reviewed-on: https://chromium-review.googlesource.com/1180349 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585408} TBR=tsepez TBR_REASON=Reland. Bug: 830892 Change-Id: I930c84a9d80c61e5a81a87e2ab84adcc963038d5 Reviewed-on: https://chromium-review.googlesource.com/1194292 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586810} [modify] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/interfaces/json_parser.mojom [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/interfaces/test_mojo_sandbox_hooks.mojom [modify] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/ipc/BUILD.gn [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks_unittest.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/BUILD.gn [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/json_parser_api.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/json_parser_impl.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/json_parser_impl.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/json_parser_impl_unittest.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandbox_setup_unittest.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.h [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/test_json_parser.cc [add] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/json_parser/test_json_parser.h [modify] https://crrev.com/e70a2ce168938f7ef352eaded6b62e7a658ce2e2/chrome/chrome_cleaner/settings/settings_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21e07a5a96dc4ce334d000c8a833b3207f6d1194 commit 21e07a5a96dc4ce334d000c8a833b3207f6d1194 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Aug 29 22:12:12 2018 Add typemaps for chrome_cleaner interfaces. Bug: 830892 Change-Id: Ia87628d081cd11f415c56cd067237c4d6536b432 Reviewed-on: https://chromium-review.googlesource.com/1172733 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#587314} [modify] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/test_pup_typemap.mojom [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/test_string16_embedded_nulls.mojom [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/BUILD.gn [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/DEPS [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/OWNERS [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/pup.typemap [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/pup_struct_traits.cc [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/pup_struct_traits.h [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/pup_typemap_unittest.cc [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/string16_embedded_nulls.typemap [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/string16_embedded_nulls_mojom_traits.cc [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/string16_embedded_nulls_mojom_traits.h [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/string16_embedded_nulls_typemap_unittest.cc [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/typemaps.gni [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/windows_handle.typemap [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/windows_handle_mojom_traits.cc [add] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/chrome/chrome_cleaner/interfaces/typemaps/windows_handle_mojom_traits.h [modify] https://crrev.com/21e07a5a96dc4ce334d000c8a833b3207f6d1194/mojo/public/tools/bindings/chromium_bindings_configuration.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ec8ae804cc6834bca2a7b29bb8857652333443d commit 0ec8ae804cc6834bca2a7b29bb8857652333443d Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 30 17:28:29 2018 Normalize copyright headers in chrome_cleaner Global search and replace of "Copyright (c) 2018" with "Copyright 2018" to match the style guide. R=csharp Bug: 830892 Change-Id: I9db77f6b26b7639499b82690360b26805588d304 Reviewed-on: https://chromium-review.googlesource.com/1195718 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#587641} [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/cleaner/noop_cleaner_impl.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/BUILD.gn [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/chrome_cleaner_switches.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/chrome_cleaner_switches.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/common_registry_names.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/common_registry_names.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/constants/uws_id.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/BUILD.gn [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/error_utils.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/error_utils.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/error_utils_unittest.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_agent.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_agent_factory.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_agent_factory.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_agent_impl.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_agent_impl.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_response.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/http_status_codes.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/internet_helpers.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/internet_helpers.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/internet_helpers_unittest.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/internet_unittest_helpers.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/internet_unittest_helpers.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/mock_http_agent_factory.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/mock_http_agent_factory.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/user_agent.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/user_agent.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/http/user_agent_unittest.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/BUILD.gn [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string16_embedded_nulls.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string16_embedded_nulls.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string16_embedded_nulls_unittest.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string_test_helpers.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string_test_helpers.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string_util.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string_util.h [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/strings/string_util_unittest.cc [modify] https://crrev.com/0ec8ae804cc6834bca2a7b29bb8857652333443d/chrome/chrome_cleaner/test/test_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f35f396325ab93b18550dba2f682c97625f9a097 commit f35f396325ab93b18550dba2f682c97625f9a097 Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 30 19:16:51 2018 Update chrome_cleaner/os directory from internal repo Get changes from the internal repo since last branch point: - Replace hardcoded company name with COMPANY_SHORTNAME_STRING - Add more paths to PreFetchedPaths - Replace some VLOG statements with LOG(INFO) - Enforce that RegKeyPath takes only predefined keys in rootkey - Add chrome-cleanup-tool-test to keys in registry unit tests - Add Chrome policy key constants to registry_util.h - Replace StringPrintf with StrCat R=csharp Bug: 830892 Change-Id: I71c0c3f03ce852c4af4738056187512cfea9f82e Reviewed-on: https://chromium-review.googlesource.com/1195802 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#587692} [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/BUILD.gn [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/file_remover.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/initializer.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/post_reboot_registration.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/pre_fetched_paths.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/pre_fetched_paths.h [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/pre_fetched_paths_unittest.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/registry.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/registry.h [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/registry_unittest.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/registry_util.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/registry_util.h [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/system_util_cleaner.cc [modify] https://crrev.com/f35f396325ab93b18550dba2f682c97625f9a097/chrome/chrome_cleaner/os/task_scheduler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ced1fac74c5043d69268072ce638e75abe98c30 commit 4ced1fac74c5043d69268072ce638e75abe98c30 Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Aug 30 19:24:48 2018 Update chrome_cleaner dirs from internal repo: chrome_utils, crash, logging Get changes from the internal repo since last branch point: - chrome_utils now uses the sandboxed JsonParser to parse extension install methods - add JsonParser sandbox to crash client and process information logging - get internal API keys for official build, dummy API keys for public build - Add FOUND_IN_PROGRAMFILES trace location R=csharp Bug: 830892 Change-Id: I33944eaaf31be836ac4c91041fd7e4e0d25278d2 Reviewed-on: https://chromium-review.googlesource.com/1195798 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#587700} [add] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_cleaner_args.gni [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/BUILD.gn [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/chrome_util.cc [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/chrome_util.h [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/extensions_util.h [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/crash/crashpad_crash_client.cc [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/logging/BUILD.gn [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/logging/proto/shared_data.proto [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/logging/reporter_logging_service.cc [modify] https://crrev.com/4ced1fac74c5043d69268072ce638e75abe98c30/chrome/chrome_cleaner/logging/utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c022154e6e03429a4ae291c6381a0dd66743040 commit 2c022154e6e03429a4ae291c6381a0dd66743040 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Sep 05 15:18:13 2018 Use PredefinedHandle in pup.mojom instead of the full WindowsHandle RegKeyPath in pup.mojom has the only registry handle passed from the chrome_cleaner target process to the broker process. This handle is always a root key (eg. HKCU or HKLM) so it can be represented directly using the PredefinedHandle enum. This simplifies the serialization slightly and is a first step to switching to a move-only interface for registry handles. Also update copyright headers and an obsolete comment on the EngineCommands interface. R=wfh Bug: 830892 Change-Id: I687773b545d199b765345b2a7dd8e310b7609265 Reviewed-on: https://chromium-review.googlesource.com/1197223 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#588869} [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/engine_requests.mojom [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/engine_sandbox.mojom [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/pup.mojom [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/typemaps/pup.typemap [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/typemaps/string16_embedded_nulls.typemap [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/typemaps/windows_handle.typemap [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/typemaps/windows_handle_mojom_traits.cc [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/typemaps/windows_handle_mojom_traits.h [modify] https://crrev.com/2c022154e6e03429a4ae291c6381a0dd66743040/chrome/chrome_cleaner/interfaces/windows_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/870ca29a73f20650d5bef3b47e94646e79b57fc3 commit 870ca29a73f20650d5bef3b47e94646e79b57fc3 Author: Joe Mason <joenotcharles@chromium.org> Date: Thu Sep 06 19:15:43 2018 Add chrome_cleaner/zip_archiver. R=csharp Bug: 830892 Change-Id: I821588099796a86a685bd85fa29456fd5d8bc705 Reviewed-on: https://chromium-review.googlesource.com/1197102 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589235} [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/crash/crashpad_crash_client.cc [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/interfaces/BUILD.gn [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/interfaces/zip_archiver.mojom [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/logging/proto/shared_data.proto [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/logging/utils.cc [modify] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/settings/settings_types.h [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/BUILD.gn [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/DEPS [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/broker/BUILD.gn [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/broker/sandbox_setup.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/broker/sandbox_setup.h [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/broker/sandbox_setup_unittest.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver.h [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver_unittest.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/BUILD.gn [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/sandbox_setup.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/sandbox_setup.h [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.h [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl_unittest.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.cc [add] https://crrev.com/870ca29a73f20650d5bef3b47e94646e79b57fc3/chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98a349ce1962437bd8672eb6935a245918e1b1d4 commit 98a349ce1962437bd8672eb6935a245918e1b1d4 Author: Joe Mason <joenotcharles@chromium.org> Date: Fri Sep 07 20:58:42 2018 Updates from internal chrome_cleaner repo * Add a hook to override the command line of test_main.cc. chrome_cleaner_unittests has an empty implementation. Other internal test executables that use test_main.cc use this to add flags to the commandline. * Add more accessors to engine_resources.h to reduce hardcoding. * Move the dummy engine resources and signatures to their own build targets. * Remove unused MatchingOptions::find_incomplete_matches. * Remove unused StartScanning and StartCleanup methods in MainDialogAPI. * Make test binaries into console apps. * Allow import_util.py to work outside the source tree. * Cleanups to deps and includes. * Alphabetize test/BUILD.gn so it can be diffed against the internal version more easily during upstreaming. R=csharp Bug: 830892 Change-Id: I263aabf02a467df231e3c227ea6f01328b9212d3 Reviewed-on: https://chromium-review.googlesource.com/1207171 Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589625} [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/engines/BUILD.gn [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/engines/dummy_engine_resources.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/engines/engine_resources.h [add] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/logging/DEPS [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/pup_data/BUILD.gn [rename] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/pup_data/dummy_signatures.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/scanner/BUILD.gn [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/scanner/urza_scanner_impl.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/settings/DEPS [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/settings/default_matching_options.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/settings/matching_options.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/settings/matching_options.h [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/strings/string16_embedded_nulls.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/strings/string16_embedded_nulls.h [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/BUILD.gn [delete] https://crrev.com/ead1c24e5b0e6b883f7d7e816b15c81777fef6bb/chrome/chrome_cleaner/test/DEPS [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/test_main.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/test_name_helper.h [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/test_process_main.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/test_util_unittest.cc [add] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/test/unit_test_override_command_line.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/tools/import_util.py [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog.h [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog_unittest.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/main_dialog_api.h [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/silent_main_dialog.cc [modify] https://crrev.com/98a349ce1962437bd8672eb6935a245918e1b1d4/chrome/chrome_cleaner/ui/silent_main_dialog.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87 commit ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87 Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Sep 11 14:49:22 2018 Move args from chrome_cleaner/constants/BUILD.gn to a .gni file. This lets the args be included from other directories. Also fix the license in REPORTER_BRANDING and CLEANER_BRANDING. R=csharp Bug: 830892 Change-Id: Ia753c988579ee65a969aa07103677b80da0eede4 Reviewed-on: https://chromium-review.googlesource.com/1216707 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#590305} [modify] https://crrev.com/ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87/chrome/chrome_cleaner/constants/BUILD.gn [modify] https://crrev.com/ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87/chrome/chrome_cleaner/constants/CLEANER_BRANDING [modify] https://crrev.com/ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87/chrome/chrome_cleaner/constants/REPORTER_BRANDING [add] https://crrev.com/ce3666ace0884cbf16e0c9efe46ab4c2dc6a5d87/chrome/chrome_cleaner/constants/args.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c188107807d424aaf209a96fff1b5cc3752d7eb commit 1c188107807d424aaf209a96fff1b5cc3752d7eb Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Sep 11 14:50:12 2018 chrome_cleaner/settings NamedPlatformChannel -> PlatformChannel Before M69 this code used mojo::edk::PlatformChannelPair, not mojo::edk::NamedPlatformChannelPair. R=csharp Bug: 830892 Change-Id: I69d4f3dd5ef730e38cbb76f3d827c9094b6492ab Reviewed-on: https://chromium-review.googlesource.com/1216710 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#590306} [modify] https://crrev.com/1c188107807d424aaf209a96fff1b5cc3752d7eb/chrome/chrome_cleaner/settings/settings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/559793640bbb6a3fded311749d4ea1912d455ca0 commit 559793640bbb6a3fded311749d4ea1912d455ca0 Author: Joe Mason <joenotcharles@chromium.org> Date: Tue Sep 11 15:49:36 2018 Add quarantine status to chrome_cleaner's shared_data.proto Also add new ERROR_IN_ARCHIVER removal status value, and update the override permissions map to handle it. Full code and tests to deal with QuarantineStatus will come in a followup. R=csharp Bug: 830892 Change-Id: Ib002f44b8aba6899f54b44148d8645c3c0c7178f Reviewed-on: https://chromium-review.googlesource.com/1217148 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#590330} [modify] https://crrev.com/559793640bbb6a3fded311749d4ea1912d455ca0/chrome/chrome_cleaner/logging/proto/removal_status.proto [modify] https://crrev.com/559793640bbb6a3fded311749d4ea1912d455ca0/chrome/chrome_cleaner/logging/proto/shared_data.proto [modify] https://crrev.com/559793640bbb6a3fded311749d4ea1912d455ca0/chrome/chrome_cleaner/os/file_removal_status_updater.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2261382ce1e0db421f15bc50e51d46cd7cc1faa5 commit 2261382ce1e0db421f15bc50e51d46cd7cc1faa5 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Sep 12 15:45:03 2018 Remove unneeded other_settings_definitions.cc in settings unittests This file isn't a test itself so shouldn't have been included in the unittest_sources target. It's supposed to only be linked against top-level executables to avoid ODR's. And it is, in fact, already linked to chrome_cleaner_unittests target directly through :other_executable_definions R=proberge Bug: 830892 Change-Id: Ib3368a7197a0ab8c66973f4e3fc52fe47ac8a2c9 Reviewed-on: https://chromium-review.googlesource.com/1220185 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#590697} [modify] https://crrev.com/2261382ce1e0db421f15bc50e51d46cd7cc1faa5/chrome/chrome_cleaner/settings/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e6404f57cdb20df320f977b26d0862c0fa144d0 commit 0e6404f57cdb20df320f977b26d0862c0fa144d0 Author: Joe Mason <joenotcharles@chromium.org> Date: Fri Sep 28 15:37:13 2018 Add chrome_cleaner/components dir Fix ICWYU error in chrome_cleaner/os/rebooter_api.h R=csharp Bug: 830892 Change-Id: I3f311bdd32e21b2901594a835aead483ae8d823b Reviewed-on: https://chromium-review.googlesource.com/1227683 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595101} [modify] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/BUILD.gn [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/BUILD.gn [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/DEPS [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_api.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_manager.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_manager.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_manager_unittest.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_unpacker.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/component_unpacker.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/crx_file.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/crx_file.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/recovery_component.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/recovery_component.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/recovery_component_unittest.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_report_component.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_report_component.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_report_component_unittest.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_restore_point_component.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_restore_point_component.h [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/components/system_restore_point_component_unittest.cc [modify] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/os/rebooter_api.h [modify] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/test/test_component.cc [add] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/chrome/chrome_cleaner/test/test_component.h [modify] https://crrev.com/0e6404f57cdb20df320f977b26d0862c0fa144d0/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49c86ba000e3616927bc82bc51ff87e66c86e42c commit 49c86ba000e3616927bc82bc51ff87e66c86e42c Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Oct 10 15:03:34 2018 Copy chrome_cleaner changes from internal repo: IWYU fixes in chrome_utils/, crash/. New zip archiver result codes in interfaces/. Hook up ChromePrompt::DisableExtensions method in ipc/. Refactor sandbox error connection setup in ipc/. Add JsonSplicer class in json_parser/. Add quarantine status stubs to logging/ (the full quarantine status code has dependencies that aren't upstreamed yet so will be included in a followup). Re-enable RegistryLogger tests in logging/. Simplify EnableUploads logic in logging/. Fix copyright of uwe_matcher in proto/. R=proberge Bug: 830892 Change-Id: Ide23f8e06820866d49acb82c1aceb1e622e1155a Reviewed-on: https://chromium-review.googlesource.com/c/1271409 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#598324} [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/crash/crashpad_crash_client.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/interfaces/zip_archiver.mojom [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.h [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/ipc/chrome_prompt_ipc_unittest.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/ipc/sandbox.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/ipc/sandbox.h [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/BUILD.gn [add] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/DEPS [add] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/json_splicer.cc [add] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/json_splicer.h [add] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/json_splicer_unittest.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/logging/cleaner_logging_service.h [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/logging/registry_logger_unittest.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/logging/scoped_logging.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/logging/utils.cc [modify] https://crrev.com/49c86ba000e3616927bc82bc51ff87e66c86e42c/chrome/chrome_cleaner/proto/uwe_matcher.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52b13f9d83f5338fd332973b319e9d81f17a0a4 commit b52b13f9d83f5338fd332973b319e9d81f17a0a4 Author: Joe Mason <joenotcharles@google.com> Date: Mon Nov 12 22:59:57 2018 Remove unused PATCH from chrome_cleaner VERSION file R=proberge@chromium.org Bug: 830892 Change-Id: Ib22499d88a2fdb160a083eeb904e17e24a96edfc Reviewed-on: https://chromium-review.googlesource.com/c/1331876 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#607364} [modify] https://crrev.com/b52b13f9d83f5338fd332973b319e9d81f17a0a4/chrome/chrome_cleaner/constants/VERSION
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4 commit 9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4 Author: Joe Mason <joenotcharles@google.com> Date: Wed Nov 14 19:37:36 2018 Move the JSON parser into a general Parser interface This also moves json_parser into a parsers subdir. More parsers that run in the same sandbox will be added in followups. R=csharp Bug: 830892 Change-Id: I8c73d7a88d03f62dd817bd9c834bd9a61783eb5b Reviewed-on: https://chromium-review.googlesource.com/c/1329893 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608084} [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/BUILD.gn [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/DEPS [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/chrome_utils/BUILD.gn [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/chrome_utils/extensions_util.h [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/components/BUILD.gn [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/components/system_report_component.cc [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/components/system_report_component.h [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/components/system_report_component_unittest.cc [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/crash/crashpad_crash_client.cc [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/interfaces/BUILD.gn [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/interfaces/json_parser.mojom [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/interfaces/parser_interface.mojom [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/ipc/sandbox.cc [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/DEPS [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/json_parser_impl.h [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/json_splicer.h [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.cc [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandbox_target_hooks.h [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.cc [delete] https://crrev.com/2cfceacd244692996b25004d58240d4decb38dde/chrome/chrome_cleaner/json_parser/sandboxed_json_parser.h [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/logging/proto/shared_data.proto [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/logging/utils.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/DEPS [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/broker/BUILD.gn [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/broker/json_parser_sandbox_setup_unittest.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/broker/sandbox_setup_hooks.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/broker/sandbox_setup_hooks.h [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/BUILD.gn [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/json_parser_api.h [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/json_splicer.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/json_splicer.h [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/json_splicer_unittest.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/sandboxed_json_parser.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/sandboxed_json_parser.h [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/test_json_parser.cc [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/json_parser/test_json_parser.h [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/BUILD.gn [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/parser_impl.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/parser_impl.h [rename] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/parser_impl_unittest.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/sandbox_setup.cc [add] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/parsers/target/sandbox_setup.h [modify] https://crrev.com/9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4/chrome/chrome_cleaner/settings/settings_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db528719335f2e761fb126e2baee12cb4cc7a18e commit db528719335f2e761fb126e2baee12cb4cc7a18e Author: Joe Mason <joenotcharles@google.com> Date: Thu Nov 15 04:00:06 2018 Update chrome_cleaner/chrome_utils to remove force-installed extensions. Also includes changes to parsers/ and test/ that chrome_utils depends on. R=csharp Bug: 830892 Change-Id: Idaba2972a0fbc2c5e896c9403442c24c8b8c6a60 Reviewed-on: https://chromium-review.googlesource.com/c/1336047 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608249} [modify] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/BUILD.gn [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/extension_id.cc [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/extension_id.h [modify] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/extensions_util.cc [modify] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/extensions_util.h [modify] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/force_installed_extension.cc [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/chrome_utils/force_installed_extension.h [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/parsers/parser_utils/BUILD.gn [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/parsers/parser_utils/parse_tasks_remaining_counter.cc [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/parsers/parser_utils/parse_tasks_remaining_counter.h [modify] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/test/test_extensions.cc [add] https://crrev.com/db528719335f2e761fb126e2baee12cb4cc7a18e/chrome/chrome_cleaner/test/test_extensions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a3bce7a8fb6803282c7d41bcea44be19988b59a commit 4a3bce7a8fb6803282c7d41bcea44be19988b59a Author: Joe Mason <joenotcharles@google.com> Date: Thu Nov 15 16:18:06 2018 Minor cleanups to chrome_cleaner/components and chrome_cleaner/cleaner Remove an unused constant that was moved to a test/ header Fix copyright header format in cleaner dir Fix comma in comments in constants dir R=csharp@chromium.org Bug: 830892 Change-Id: I8e91c4e320ceb3f8758d7182853dd46874968f6e Reviewed-on: https://chromium-review.googlesource.com/c/1336048 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608388} [modify] https://crrev.com/4a3bce7a8fb6803282c7d41bcea44be19988b59a/chrome/chrome_cleaner/cleaner/BUILD.gn [modify] https://crrev.com/4a3bce7a8fb6803282c7d41bcea44be19988b59a/chrome/chrome_cleaner/cleaner/cleaner.h [modify] https://crrev.com/4a3bce7a8fb6803282c7d41bcea44be19988b59a/chrome/chrome_cleaner/cleaner/noop_cleaner_impl.h [modify] https://crrev.com/4a3bce7a8fb6803282c7d41bcea44be19988b59a/chrome/chrome_cleaner/components/system_report_component.cc [modify] https://crrev.com/4a3bce7a8fb6803282c7d41bcea44be19988b59a/chrome/chrome_cleaner/constants/chrome_cleaner_switches.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47f35a3192cb23183bb07f35aa5d50da31ab0e98 commit 47f35a3192cb23183bb07f35aa5d50da31ab0e98 Author: Joe Mason <joenotcharles@google.com> Date: Thu Nov 15 17:38:43 2018 Call ReportProcessLaunchAttempted when launching a mojo-connected sandbox R=csharp@chromium.org Bug: 830892 Change-Id: I13ef01f4194bc747b4c9ea28537a188aa9315c49 Reviewed-on: https://chromium-review.googlesource.com/c/1336067 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608418} [modify] https://crrev.com/47f35a3192cb23183bb07f35aa5d50da31ab0e98/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.cc [modify] https://crrev.com/47f35a3192cb23183bb07f35aa5d50da31ab0e98/chrome/chrome_cleaner/ipc/mojo_sandbox_hooks.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178 commit 7b6c5d7c426bf823bb6c7485d71c1e950ca4f178 Author: Joe Mason <joenotcharles@google.com> Date: Fri Nov 16 16:33:24 2018 Update chrome_Cleaner's zip_archiver subdir to support quarantine feature Includes a fix to ComputeSHA256DigestOfPath required by the unit test R=csharp@chromium.org Bug: 830892 Change-Id: I72e6c1a4fcf21565357e5e6043ee93b480931a4f Reviewed-on: https://chromium-review.googlesource.com/c/1338659 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608794} [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/os/disk_util.cc [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/os/file_removal_status_updater.h [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/zip_archiver/BUILD.gn [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/zip_archiver/DEPS [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver.cc [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver.h [modify] https://crrev.com/7b6c5d7c426bf823bb6c7485d71c1e950ca4f178/chrome/chrome_cleaner/zip_archiver/sandboxed_zip_archiver_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc5ea016aae1a6924c100e3e4f75fa65e0325c4 commit afc5ea016aae1a6924c100e3e4f75fa65e0325c4 Author: Joe Mason <joenotcharles@google.com> Date: Fri Nov 16 16:39:50 2018 Add matched_extensions field to PUPData and related mojo interface Also includes a .clang_format file in the pup_data dir that was missed, which caused dummy_signatures.cc to be reformatted. R=csharp@chromium.org Bug: 830892 Change-Id: I720c083ee6f8ee2b6f1805392419f43c91d43026 Reviewed-on: https://chromium-review.googlesource.com/c/1338205 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608806} [add] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/.clang-format [modify] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/BUILD.gn [modify] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/dummy_signatures.cc [modify] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/pup_data.h [modify] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/test_uws.cc [modify] https://crrev.com/afc5ea016aae1a6924c100e3e4f75fa65e0325c4/chrome/chrome_cleaner/pup_data/test_uws.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fbf3bbb2256e8ece05059c0e914afeac8e03543 commit 5fbf3bbb2256e8ece05059c0e914afeac8e03543 Author: Joe Mason <joenotcharles@google.com> Date: Fri Nov 16 18:32:19 2018 Enable quarantine feature in chrome_cleaner R=csharp@chromium.org Bug: 830892 Change-Id: I6c3a17c2761545f58e18d9058bf2dedc31acf39e Reviewed-on: https://chromium-review.googlesource.com/c/1338566 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608862} [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/logging/cleaner_logging_service.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/BUILD.gn [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_removal_status_updater.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_removal_status_updater.h [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_removal_status_updater_unittest.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_remover.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_remover.h [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_remover_api.h [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/file_remover_unittest.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/rebooter.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/system_util_cleaner.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/system_util_cleaner.h [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/os/system_util_cleaner_unittest.cc [modify] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/test/BUILD.gn [add] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/test/file_remover_test_util.cc [add] https://crrev.com/5fbf3bbb2256e8ece05059c0e914afeac8e03543/chrome/chrome_cleaner/test/file_remover_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7 commit 2837fd1184f84fea7ebccc69f72e2557e3e2c7a7 Author: Joe Mason <joenotcharles@google.com> Date: Fri Nov 16 22:44:36 2018 Add extension handling to chrome_cleaner/ipc and chrome_cleaner/ui R=csharp@chromium.org Bug: 830892 Change-Id: Ib3157dc17c2e2c7738f6b2a6af7d88ed72eb4d33 Reviewed-on: https://chromium-review.googlesource.com/c/1338402 Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#609001} [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/DEPS [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/chrome_prompt_ipc.h [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/chrome_prompt_ipc_unittest.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/mock_chrome_prompt_ipc.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ipc/mock_chrome_prompt_ipc.h [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog.h [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/chrome_proxy_main_dialog_unittest.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/main_dialog_api.h [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/silent_main_dialog.cc [modify] https://crrev.com/2837fd1184f84fea7ebccc69f72e2557e3e2c7a7/chrome/chrome_cleaner/ui/silent_main_dialog.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77af20ddccc5d7ac942fad3926a0986076b55401 commit 77af20ddccc5d7ac942fad3926a0986076b55401 Author: Joe Mason <joenotcharles@google.com> Date: Wed Nov 21 20:16:12 2018 Add extension scanner in chrome_cleaner This updates the logging/proto and scanner subdirs R=csharp@chromium.org Bug: 830892 Change-Id: I15b1cfe9fdb123553b4d00c0e42395adbc068db3 Reviewed-on: https://chromium-review.googlesource.com/c/1338406 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610192} [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/logging/proto/chrome_cleaner_report.proto [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/logging/proto/shared_data.proto [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/BUILD.gn [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/force_installed_extension_scanner.h [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/force_installed_extension_scanner_impl.cc [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/force_installed_extension_scanner_impl.h [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/force_installed_extension_scanner_unittest.cc [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/matcher_util_unittest.cc [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/mock_force_installed_extension_scanner.cc [add] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/mock_force_installed_extension_scanner.h [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/urza_scanner_impl.cc [modify] https://crrev.com/77af20ddccc5d7ac942fad3926a0986076b55401/chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc
Comment 1 by joenotcharles@chromium.org
, Apr 9 2018