New issue
Advanced search Search tips

Issue 830882 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 883487



Sign in to add a comment

Report EQT before/after TTI

Project Member Reported by npm@chromium.org, Apr 9 2018

Issue description

Since TTI is available, we'd like to now split between reporting before and after TTI. This work had started at https://chromium-review.googlesource.com/c/chromium/src/+/871496 and was awaiting exposing the scheduler from the Page class.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfc3637df44106a1c7401735799162db5472dbcd

commit cfc3637df44106a1c7401735799162db5472dbcd
Author: Nicolas Pena <npm@chromium.org>
Date: Wed May 02 16:03:10 2018

Remove QueueingTimeEstimator::State

This CL removes the State member of QueueingTimeEstimator since it is no
longer needed. This is the first step in the plan to report EQT by TTI.

https://docs.google.com/document/d/19D0f5VGFNmqJDcl5_AqkYOm1iUX24adPloCRO58aiH4/

Bug:  832680 , 830882
Change-Id: I571c75a15b51be1f8bff5b105257d6bb0d1092fc
Reviewed-on: https://chromium-review.googlesource.com/1035162
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555409}
[modify] https://crrev.com/cfc3637df44106a1c7401735799162db5472dbcd/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/cfc3637df44106a1c7401735799162db5472dbcd/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b8f0454aedcf19ab395c7c4b87a52ea111202a7

commit 2b8f0454aedcf19ab395c7c4b87a52ea111202a7
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Jul 11 14:58:01 2018

Remove RecordQueueingTimeClient

Bug:  832680 , 830882
Change-Id: I7fc5145f1b1ce9fee9bff6470cc55cda578e2c64
Reviewed-on: https://chromium-review.googlesource.com/1127259
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574161}
[modify] https://crrev.com/2b8f0454aedcf19ab395c7c4b87a52ea111202a7/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc

Blockedon: 883487
Labels: -Pri-2 Pri-3
Cc: tommckee@chromium.org
Tom, do you want to take this bug? I ask since you're already doing all the refactoring needed to report EQT before and after TTI.
Owner: tommckee@chromium.org
Makes sense to me. I'll reserve the right to pester you with questions, though :)

Sign in to add a comment