[CRD iOS] Host setup page text partially shown on languages with longer text (e.g. German) |
|||||||
Issue description
,
Apr 13 2018
This only affect Chromoting and doesn't affect Chrome.
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034b798fe6477e75e8b386b8c026ebea3d9dd77a commit 034b798fe6477e75e8b386b8c026ebea3d9dd77a Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Apr 16 20:03:07 2018 [CRD iOS] Allow setup instruction cells to dynamically grow We got some reports from people using smaller phone and language with longer words that the host setup instruction page has broken layout. Basically cells are overlapping and texts are not fully shown. This happens because we hardcoded the height of each cell. It's almost impossible to get row height autolayout working with UICollectionVC, so I reimplemented the page using UITableViewController. Bug: 830877 Change-Id: I3f748a0409599eec09d5895fa324fbb5dc6ab68b Reviewed-on: https://chromium-review.googlesource.com/1011630 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550807}(cherry picked from commit 7a8df9d06cc7727c144cd0d31254f3651b263f44) Reviewed-on: https://chromium-review.googlesource.com/1012792 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#26} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_header_view.h [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_header_view.mm [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_view_cell.h [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_view_cell.mm [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_view_controller.h [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/host_setup_view_controller.mm [modify] https://crrev.com/034b798fe6477e75e8b386b8c026ebea3d9dd77a/remoting/ios/app/remoting_view_controller.mm
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a8df9d06cc7727c144cd0d31254f3651b263f44 commit 7a8df9d06cc7727c144cd0d31254f3651b263f44 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 13 23:23:47 2018 [CRD iOS] Allow setup instruction cells to dynamically grow We got some reports from people using smaller phone and language with longer words that the host setup instruction page has broken layout. Basically cells are overlapping and texts are not fully shown. This happens because we hardcoded the height of each cell. It's almost impossible to get row height autolayout working with UICollectionVC, so I reimplemented the page using UITableViewController. Bug: 830877 Change-Id: I3f748a0409599eec09d5895fa324fbb5dc6ab68b Reviewed-on: https://chromium-review.googlesource.com/1011630 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550807} [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_header_view.h [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_header_view.mm [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_view_cell.h [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_view_cell.mm [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_view_controller.h [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/host_setup_view_controller.mm [modify] https://crrev.com/7a8df9d06cc7727c144cd0d31254f3651b263f44/remoting/ios/app/remoting_view_controller.mm
,
Jul 19
Verified Fixed in 67.0.3396.22 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018