New issue
Advanced search Search tips

Issue 830871 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 790766



Sign in to add a comment

Implement GetCurrentTime for flinging renderer

Project Member Reported by tguilbert@chromium.org, Apr 9 2018

Issue description

Currently, the flinging renderer only returns 0 as a current time.

Either a custom callback should be implemented, or time should be reported as part of the MediaStatusObserver interface.
 
Components: Internals>Media
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445

commit 8a6d66b9d2859cde8595eb9860a4ff5ef72b8445
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Thu Aug 23 23:33:29 2018

Implement FlingingRenderer::GetMediaTime

This CL uses RemoteMediaPlayer.getApproximateStreamPosition to implement
FlingingRenderer::GetMediaTime().

NOTE: GMS core ignores stream position changes in the MediaStatus, when
we have a pending seek. Calling both Seek() and Play() back to back in
FlingingRenderer::StartPlayingFrom() sometimes causes the stream
position update to be lost. This causes getApproximateStreamPosition to
report a time that is out of sync with the cast device. We already use
the autoplay flag when loading the RemoteMediaPlayer, so removing the
call to MediaController::Play() doest not cause any problems.

Bug:  830871 
Change-Id: Ia5a6384cf11a77a6aa49e9669f015f7835c5a775
Reviewed-on: https://chromium-review.googlesource.com/1180511
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585655}
[modify] https://crrev.com/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445/chrome/android/java/src/org/chromium/chrome/browser/media/router/FlingingControllerBridge.java
[modify] https://crrev.com/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445/chrome/browser/media/android/remote/flinging_controller_bridge.cc
[modify] https://crrev.com/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445/content/browser/media/flinging_renderer.cc
[modify] https://crrev.com/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445/content/browser/media/flinging_renderer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment