New issue
Advanced search Search tips

Issue 830849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Increased host-offline rate

Project Member Reported by yuweih@chromium.org, Apr 9 2018

Issue description

Host-offline rate has been increased to ~14%, which is quite high compared to Android (~4%).

Looks like we never automatically reload the host list, so it could easily become stale.
 

Comment 1 by yuweih@chromium.org, Apr 10 2018

Cc: yuweih@chromium.org
 Issue 828213  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9be7f8d81ecc3ae0b6345888571b592d532667a8

commit 9be7f8d81ecc3ae0b6345888571b592d532667a8
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 12 17:52:35 2018

[CRD iOS] Auto-refreshing host list

Previously we never refresh the host list after it gets loaded, which
increases the host-offline error by a lot. This CL fixes this by
triggering host list refresh when the app is brought back from
background (applicationDidBecomeActive:) and when the user is
disconnected from the session (viewWillAppear:).

Bug:  830849 
Change-Id: Iddbef200cd894bbe60c2a1b42330a186eda80c76
Reviewed-on: https://chromium-review.googlesource.com/1003141
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550262}
[modify] https://crrev.com/9be7f8d81ecc3ae0b6345888571b592d532667a8/remoting/ios/app/remoting_view_controller.mm

Comment 3 by yuweih@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9be7f8d81ecc3ae0b6345888571b592d532667a8

commit 9be7f8d81ecc3ae0b6345888571b592d532667a8
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Apr 12 17:52:35 2018

[CRD iOS] Auto-refreshing host list

Previously we never refresh the host list after it gets loaded, which
increases the host-offline error by a lot. This CL fixes this by
triggering host list refresh when the app is brought back from
background (applicationDidBecomeActive:) and when the user is
disconnected from the session (viewWillAppear:).

Bug:  830849 
Change-Id: Iddbef200cd894bbe60c2a1b42330a186eda80c76
Reviewed-on: https://chromium-review.googlesource.com/1003141
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550262}
[modify] https://crrev.com/9be7f8d81ecc3ae0b6345888571b592d532667a8/remoting/ios/app/remoting_view_controller.mm

Sign in to add a comment