New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830829 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 832286



Sign in to add a comment

9.3% regression in media.desktop at 548615:548670

Project Member Reported by chcunningham@chromium.org, Apr 9 2018

Issue description

Ref looks good. Recent values clearly worse and sustained. 
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830829

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8115cd981a4233de622d5d104006b662479f304fd8c8551e6606ed549667956f


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/149837dcc40000
Description: Show this description
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Apr 12 2018

Cc: pmonette@chromium.org rkaplow@chromium.org
Owner: pmonette@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17bea634c40000

Adding fieldtrial config for the IncompatibleApplicationsWarning feature by pmonette@chromium.org
https://chromium.googlesource.com/chromium/src/+/7a86e22e588d7941bde54bdb4a8c58c23e502836

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Blocking: 832286
Cc: johnchen@chromium.org
+johnchen@chromium.org, benchmark owner

Hi John,

The CL I landed to enable the ModuleDatabase feature causes an increased CPU load in your benchmark. This is completely expected from the feature, as it adds a bunch of expansive background tasks.

But in theory, because the tasks are marked as background, the scheduler should only schedule them when there are idle CPU cycles available.

Is there a way to confirm that the feature doesn't impact this benchmark in any other way than the extra CPU time? I'm talking about speed and memory related metrics.

I'd like to get this bug close as "Working as intended" if that's the case. Thanks!
Since the increased CPU load is expected, I think closing the bug as "working as intended" is the right step. We have perf benchmarks that also measure memory and other metrics. If you don't receive any bugs about regressions in those areas, then it should be safe to assume that there are no other measurable impacts. If you like, you can use the perf dashboard (https://chromeperf.appspot.com/report) to check if there are any regressions around your CL.
Status: WontFix (was: Assigned)
Thanks. I haven't seen anything else than increase CPU time, so I'll close this bug.

I will still continue to monitor the performance of this feature.

Sign in to add a comment