New issue
Advanced search Search tips

Issue 830814 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Create infobar for showing accelerated downloads

Project Member Reported by shaktisahu@chromium.org, Apr 9 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a153356641c317a9c7a429cb52a5467f9fb170e

commit 8a153356641c317a9c7a429cb52a5467f9fb170e
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue May 08 13:14:13 2018

DownloadInfo : Exposing if the download is accelerated

Bug:  830814 
Change-Id: If1e12254aebabb06da1ba0b31de9500331444863
Reviewed-on: https://chromium-review.googlesource.com/1003043
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556775}
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/components/download/public/common/download_item.h
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/components/download/public/common/download_item_impl.h
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/components/download/public/common/mock_download_item.h
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/content/public/test/fake_download_item.cc
[modify] https://crrev.com/8a153356641c317a9c7a429cb52a5467f9fb170e/content/public/test/fake_download_item.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3a7741b860bf523968693bdc4385baca7597c0

commit 5f3a7741b860bf523968693bdc4385baca7597c0
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed May 09 20:28:47 2018

Downloads: Download progress InfoBar UI

This CL adds an infobar to show the download progress. The actual
triggering logic of the infobar will be added in a subsequent CL.

Bug:  830814 
Change-Id: If64cc1939ee4479f919a679d6cc9bf648657ada2
Reviewed-on: https://chromium-review.googlesource.com/1003754
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557305}
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[add] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
[add] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/android/java_sources.gni
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/BUILD.gn
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/ui/android/infobars/download_progress_infobar.cc
[add] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/chrome/browser/ui/android/infobars/download_progress_infobar.h
[modify] https://crrev.com/5f3a7741b860bf523968693bdc4385baca7597c0/components/infobars/core/infobar_delegate.h

Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26e6e4174706e17486bb2b05f6a5f8486a315603

commit 26e6e4174706e17486bb2b05f6a5f8486a315603
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue May 22 05:46:26 2018

Download infobar : Several fixes

1 - A fix for showing plurals appropriately in the downloading state
2 - A fix for previous result state

Bug:  830814 
Change-Id: I17cee00160e2c6498836b7910786e913c562b31d
Reviewed-on: https://chromium-review.googlesource.com/1066820
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560489}
[modify] https://crrev.com/26e6e4174706e17486bb2b05f6a5f8486a315603/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java

Labels: -Pri-2 M-68 OS-Android Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4

commit b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Mon Jun 04 22:07:25 2018

Download infobar : Various fixes

1 - Remove notification on link clicked
2 - Remove download can't open toast for infobar
3 - Adding feature param to turn on/off speeding-up-download message

Bug:  830814 
Change-Id: Ia331b943dd0b269e5dbdf6d28f997f823d6d1147
Reviewed-on: https://chromium-review.googlesource.com/1074449
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564260}
[modify] https://crrev.com/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
[modify] https://crrev.com/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadInfoBarControllerTest.java
[modify] https://crrev.com/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
[modify] https://crrev.com/b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4/testing/variations/fieldtrial_testing_config.json

Labels: Merge-Request-68
Requesting to merge the last patch from #c6

Project Member

Comment 8 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49e6eb80352f1137cb3a8fbd19723844e04778fe

commit 49e6eb80352f1137cb3a8fbd19723844e04778fe
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Jun 05 23:43:37 2018

Download infobar : Various fixes

1 - Remove notification on link clicked
2 - Remove download can't open toast for infobar
3 - Adding feature param to turn on/off speeding-up-download message

Bug:  830814 
Change-Id: Ia331b943dd0b269e5dbdf6d28f997f823d6d1147
Reviewed-on: https://chromium-review.googlesource.com/1074449
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564260}(cherry picked from commit b1a46f4b3e51c212d4025dae0bf8f2dfab5d24d4)
Reviewed-on: https://chromium-review.googlesource.com/1087967
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#200}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
[modify] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadInfoBarControllerTest.java
[modify] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
[modify] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/testing/variations/fieldtrial_testing_config.json

Labels: -Type-Bug Type-Task
Status: Fixed (was: Assigned)

Sign in to add a comment