New issue
Advanced search Search tips

Issue 830792 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.8% regression in smoothness.gpu_rasterization.tough_path_rendering_cases at 548769:548838

Project Member Reported by primiano@chromium.org, Apr 9 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830792

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d0bd00d2e1a82572092573bcb602ebf6dbadb2c20bb9c2307b2ac2b4497a80b7


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 10 2018

Cc: penghuang@chromium.org piman@chromium.org
Owner: penghuang@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12252458c40000

Enable presentation feedback on Linux by penghuang@chromium.org
https://chromium.googlesource.com/chromium/src/+/400c1e296933da71f3b4e3a04b0843297dd4ffa4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Reverting r548803 because it has been bisected as the root cause of several performance regressions.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c90ba20609cb897219c8b656b6255946c1b13d2

commit 9c90ba20609cb897219c8b656b6255946c1b13d2
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed Apr 11 00:27:07 2018

Revert "Enable presentation feedback on Linux"

This reverts commit 400c1e296933da71f3b4e3a04b0843297dd4ffa4.

Reason for revert: This CL caused several performance regressions.

Bug:  830776 , 830790 , 830792 , 830794 , 830802 , 830806 

Original change's description:
> Enable presentation feedback on Linux
> 
> Bug:  776877 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I6faa89c42bb8a6bf43c4a9c6fe86826dca316e4f
> Reviewed-on: https://chromium-review.googlesource.com/998317
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548803}

TBR=penghuang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  776877 
Change-Id: I2f4d442305eb6505401e058773338b782c94c3ef
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1005157
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549693}
[modify] https://crrev.com/9c90ba20609cb897219c8b656b6255946c1b13d2/ui/gl/gl_surface_osmesa_x11.cc
[modify] https://crrev.com/9c90ba20609cb897219c8b656b6255946c1b13d2/ui/gl/gl_surface_osmesa_x11.h
[modify] https://crrev.com/9c90ba20609cb897219c8b656b6255946c1b13d2/ui/gl/gl_switches_util.cc

Status: Fixed (was: Assigned)
Marking Fixed as the CL was reverted. Please re-run the benchmark on perf trybots for linux before re-landing.

Sign in to add a comment