New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 830770 link

Starred by 2 users
Status: WontFix
Owner:
enne@chromium.org
Closed: Apr 2018
Cc:
weiliangc@chromium.org
█ kbr@chromium.org
ericrk@chromium.org
enne@chromium.org
primiano@chromium.org
toyoshim@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.3%-12.5% regression in smoothness.tough_animation_cases at 548839:549022

Project Member Reported by primiano@chromium.org, Apr 9 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 9 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830770

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=11ac77226215d68c0d8fe97435fa07421f660cba22f9502770984a817a17faa8


Bot(s) for this bug's original alert(s):

android-nexus6
android-nexus7v2
android-webview-nexus6
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 9 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12f3deb4c40000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Apr 10 2018

Cc: kbr@chromium.org ericrk@chromium.org enne@chromium.org
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/168e51dcc40000

Revert "viz: Use texture clamping shader always" by enne@chromium.org
https://chromium.googlesource.com/chromium/src/+/d669cd65fee123b17f001052130fe9ce43a21bd4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by enne@chromium.org, Apr 10 2018

Status: WontFix (was: Assigned)
This patch was reverted for correctness reasons.  I don't plan to reenable it.  We should look into batching up shaders more generally for performance reasons and not something this small.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Apr 10 2018

Status: Assigned (was: WontFix)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148ab5bcc40000

Revert "viz: Use texture clamping shader always" by enne@chromium.org
https://chromium.googlesource.com/chromium/src/+/d669cd65fee123b17f001052130fe9ce43a21bd4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 9 by sullivan@chromium.org, Apr 10 2018

Status: WontFix (was: Assigned)
Sorry for the noisy bisect!

Comment 10 by enne@chromium.org, Apr 11 2018 

 Issue 830768  has been merged into this issue.

Comment 11 by enne@chromium.org, Apr 16 2018

Cc: weiliangc@chromium.org
 Issue 806826  has been merged into this issue.

Comment 12 by enne@chromium.org, Apr 16 2018

Cc: toyoshim@chromium.org
 Issue 833302  has been merged into this issue.

Comment 13 by enne@chromium.org, May 4 2018 

 Issue 830744  has been merged into this issue.
►

Sign in to add a comment