New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830765 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

MobMonitor complains about JobAborterRunning

Project Member Reported by haddowk@chromium.org, Apr 9 2018

Issue description


Since the moblab was updated, I noticed MobMonitor complains about JobAborterRunning. When I try to repair it, nothing happens. I've rebooted the moblab and tried again, just in case, but the issue persists. Is this a known issue?

- Remove the check from mobmonitor for the moment.
 
Can you post the logs?  Should be under /var/log/upstart/job_aborter.log I think
I can not find a file called job_aborter.log on the moblab that reported the issue (R65 branch ) or on a machine running at ToT
Ok - the error is correct then I will widthdraw my CL

moblab@localhost /etc/init $ sudo /sbin/initctl list | grep autotest
autotest_setup stop/waiting

moblab@localhost /etc/init $ sudo /sbin/initctl list | grep job_aborter


There is something wrong with that conf file - moblab is not recognizing it.

Also you will have to add chromeos-test as a user to moblab - it currently does not exist.
Owner: ayatane@chromium.org
Assigning to ayatane for the moment

I need to release R65 this week - if there is something I can do to help let me know.
job_aborter should run as the moblab user on moblab.

autotest-server should not install services on moblab, only autotest-server dependencies.

All moblab upstart jobs should be under project-moblab/...
First, the moblab user doesn't really make sense outside of that overlay.
Second, we'd like to keep all upstart jobs on moblab in one place to make it easy to setup dependency / follow dependencies.

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4465a9ca31ac9cfa1de92e89952ea3861b0a253c

commit 4465a9ca31ac9cfa1de92e89952ea3861b0a253c
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 23:29:27 2018

chromeos-bsp-moblab: Add job_aborter Upstart config

BUG= chromium:830765 
TEST=None

Change-Id: Ib3ad2828071f0afdb19d5f78e12986ce35a226c4
Reviewed-on: https://chromium-review.googlesource.com/1005781
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/4465a9ca31ac9cfa1de92e89952ea3861b0a253c/project-moblab/chromeos-base/chromeos-bsp-moblab/files/job_aborter.conf

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/01d18058d9fe9aa16bd334374ea84a3ba89aaefa

commit 01d18058d9fe9aa16bd334374ea84a3ba89aaefa
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 23:29:32 2018

autotest-server: Remove job-aborter Upstart config

Move this to the moblab project overlays

BUG= chromium:830765 
TEST=None

Change-Id: Ifcff0d6e369bbc8637d713d71ad2702296ac743d
Reviewed-on: https://chromium-review.googlesource.com/1005731
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[delete] https://crrev.com/631daed54aabeae841a28eb0095e2cba2b6bb0d0/chromeos-base/autotest-server/files/job_aborter.conf

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 10 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/78129a0ca466ed9c58075bfeccd1c9c8da4238ef

commit 78129a0ca466ed9c58075bfeccd1c9c8da4238ef
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 23:40:29 2018

autotest-server: Remove job-aborter Upstart config

Move this to the moblab project overlays

BUG= chromium:830765 
TEST=None

Change-Id: Ifcff0d6e369bbc8637d713d71ad2702296ac743d
Reviewed-on: https://chromium-review.googlesource.com/1005731
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 01d18058d9fe9aa16bd334374ea84a3ba89aaefa)
Reviewed-on: https://chromium-review.googlesource.com/1006117
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[delete] https://crrev.com/bbd01f0a7435da812736b0656cd3bfc5be905f5b/chromeos-base/autotest-server/files/job_aborter.conf

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a9c12988fa3d626fbe24f2318a48d386d1f373c1

commit a9c12988fa3d626fbe24f2318a48d386d1f373c1
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 23:45:01 2018

chromeos-bsp-moblab: Add job_aborter Upstart config

BUG= chromium:830765 
TEST=None

Change-Id: Ib3ad2828071f0afdb19d5f78e12986ce35a226c4
Reviewed-on: https://chromium-review.googlesource.com/1005781
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 4465a9ca31ac9cfa1de92e89952ea3861b0a253c)
Reviewed-on: https://chromium-review.googlesource.com/1006076
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/a9c12988fa3d626fbe24f2318a48d386d1f373c1/project-moblab/chromeos-base/chromeos-bsp-moblab/files/job_aborter.conf

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 10 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/dd07ce0f765f68e2c68c1c1c8df52b84544d8f79

commit dd07ce0f765f68e2c68c1c1c8df52b84544d8f79
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 23:45:04 2018

chromeos-bsp-moblab: Add job_aborter Upstart config

BUG= chromium:830765 
TEST=None

Change-Id: Ib3ad2828071f0afdb19d5f78e12986ce35a226c4
Reviewed-on: https://chromium-review.googlesource.com/1005781
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 4465a9ca31ac9cfa1de92e89952ea3861b0a253c)
Reviewed-on: https://chromium-review.googlesource.com/1006077
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/dd07ce0f765f68e2c68c1c1c8df52b84544d8f79/project-moblab/chromeos-base/chromeos-bsp-moblab/files/job_aborter.conf

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5f2e3829d85af4f47ae3e0122032b75ba0b7712e

commit 5f2e3829d85af4f47ae3e0122032b75ba0b7712e
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 11 15:54:23 2018

autotest-server: Remove job-aborter Upstart config

Move this to the moblab project overlays

BUG= chromium:830765 
TEST=None

Change-Id: Ifcff0d6e369bbc8637d713d71ad2702296ac743d
Reviewed-on: https://chromium-review.googlesource.com/1005731
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 01d18058d9fe9aa16bd334374ea84a3ba89aaefa)
Reviewed-on: https://chromium-review.googlesource.com/1006118
Tested-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[delete] https://crrev.com/19a7727b5706f4b780854a8fe8bf1075d0b5f9b6/chromeos-base/autotest-server/files/job_aborter.conf

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9ce5e8f2efd66f907ea47785a31f37dc648b3d04

commit 9ce5e8f2efd66f907ea47785a31f37dc648b3d04
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Apr 18 21:29:04 2018

[moblab] Move job_aborter to the init directory.

BUG= chromium:830765 
TEST=None

Change-Id: Ie14b2ac1575fea99311570be7753880a0cbfd487
Reviewed-on: https://chromium-review.googlesource.com/1017920
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/9ce5e8f2efd66f907ea47785a31f37dc648b3d04/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/907fba3eed002a25d2b923a648286a1250434b12

commit 907fba3eed002a25d2b923a648286a1250434b12
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Apr 19 00:35:40 2018

[moblab] Move job_aborter to the init directory.

BUG= chromium:830765 
TEST=None

Change-Id: Ie14b2ac1575fea99311570be7753880a0cbfd487
Reviewed-on: https://chromium-review.googlesource.com/1017343
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[rename] https://crrev.com/907fba3eed002a25d2b923a648286a1250434b12/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Comment 16 by hadd...@google.com, Apr 20 2018

There are still bugs in running job aborter

moblab@localhost /etc/init $ /usr/local/autotest/bin/job_aborter --jobdir /usr/local/autotest/leases&
[1] 26892
moblab@localhost /etc/init $ ERROR: create_venv script could not be located.
You need to update a constant inside python_venv, or your checkout might be
incomplete.


We are hoping to release moblab very soon can you take a look please.

Comment 17 by hadd...@google.com, Apr 20 2018

Also moblab is not recognizing the conf file

moblab@localhost /etc/init $ sudo /sbin/initctl list | grep job
moblab@localhost /etc/init $ cat job_aborter.conf 
# Copyright 2017 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

description "lucifer Autotest job aborter daemon"

start on (runlevel [2345] and started autotest_setup)
stop on runlevel [!2345]
console log
respawn
respawn limit 10 30
setuid moblab

Moblab is using Upstart 1.2 and Autotest prod is using Upstart 1.12.1

console log was added in 1.4.  I will remove that line.
Can't reproduce #16

moblab@localhost ~ $ /usr/local/autotest/bin/job_aborter --jobdir /usr/local/autotest/leases
job_aborter: 2018-04-20 12:05:56,739:INFO:job_aborter:main:46:Starting with args: Namespace(jobdir='/usr/local/autotest/leases')
job_aborter: 2018-04-20 12:05:56,739:INFO:autotest:_monkeypatch_body:86:Could not find chromite; adding system packages and retrying (This should only happen on Moblab)
job_aborter: 2018-04-20 12:05:56,903:DEBUG:autotest:find_module:138:Dummying out autotest_lib.frontend.common import
job_aborter: 2018-04-20 12:05:56,907:DEBUG:autotest:find_module:138:Dummying out autotest_lib.client.common_lib.common import
job_aborter: 2018-04-20 12:05:56,913:DEBUG:autotest:find_module:138:Dummying out autotest_lib.scheduler.common import
job_aborter: 2018-04-20 12:05:57,290:INFO:connectionpool:_new_conn:207:Starting new HTTP connection (1): metadata.google.internal
job_aborter: 2018-04-20 12:05:57,553:INFO:config:load_machine_config:24:Configuration file does not exist, ignoring: /etc/chrome-infra/ts-mon.json
job_aborter: 2018-04-20 12:05:57,554:ERROR:config:process_argparse_options:244:ts_mon monitoring is disabled because the endpoint provided is invalid or not supported: 
job_aborter: 2018-04-20 12:05:57,555:NOTICE:cros_logging:notice:38:ts_mon was set up.
job_aborter: 2018-04-20 12:05:57,621:DEBUG:job_aborter:_main_loop:66:Tick
job_aborter: 2018-04-20 12:05:57,622:DEBUG:job_aborter:_mark_expired_jobs_failed:98:Looking for expired jobs
job_aborter: 2018-04-20 12:05:57,665:DEBUG:autotest:find_module:138:Dummying out autotest_lib.frontend.afe.common import
job_aborter: 2018-04-20 12:05:57,677:DEBUG:autotest:find_module:138:Dummying out autotest_lib.server.common import
job_aborter: 2018-04-20 12:05:57,682:DEBUG:autotest:find_module:138:Dummying out autotest_lib.client.bin.result_tools.common import
job_aborter: 2018-04-20 12:05:57,683:DEBUG:autotest:find_module:138:Dummying out autotest_lib.server.cros.common import
^CTraceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/autotest/venv/lucifer/cmd/job_aborter.py", line 204, in <module>
    main(sys.argv[1:])
  File "/usr/local/autotest/venv/lucifer/cmd/job_aborter.py", line 51, in main
    _main_loop(jobdir=args.jobdir)
  File "/usr/local/autotest/venv/lucifer/cmd/job_aborter.py", line 70, in _main_loop
    time.sleep(20)
KeyboardInterrupt

Maybe this needs to be cherrypicked to R65/66?

https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/infra-virtualenv/infra-virtualenv-9999.ebuild?q=infra-virtualenv-9999&dr
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/86bb69037d0ba7bf4ef44129e550c7e313efb923

commit 86bb69037d0ba7bf4ef44129e550c7e313efb923
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 20 23:33:56 2018

moblab: Remove unsupported stanza

BUG= chromium:830765 
TEST=None

Change-Id: I55687aa0ce75b50c6abb8e1f8ba0233fe2cab5b9
Reviewed-on: https://chromium-review.googlesource.com/1023090
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/86bb69037d0ba7bf4ef44129e550c7e313efb923/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ec3055009087a04722b8ebdaf85fafbe29ae8363

commit ec3055009087a04722b8ebdaf85fafbe29ae8363
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 21 06:02:38 2018

moblab: Remove unsupported stanza

BUG= chromium:830765 
TEST=None

Change-Id: I55687aa0ce75b50c6abb8e1f8ba0233fe2cab5b9
Reviewed-on: https://chromium-review.googlesource.com/1022473
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/ec3055009087a04722b8ebdaf85fafbe29ae8363/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Comment 22 by hadd...@google.com, Apr 23 2018


I cherry picked the CL recommended I now get the error:

moblab@localhost /etc/init $ /usr/local/autotest/bin/job_aborter --jobdir /usr/local/autotest/leases
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/opt/infra_virtualenv/venv/cros_venv/scripts/create_venv.py", line 46, in <module>
    main()
  File "/opt/infra_virtualenv/venv/cros_venv/scripts/create_venv.py", line 35, in main
    print(venv.ensure())
  File "/opt/infra_virtualenv/venv/cros_venv/venvlib.py", line 100, in ensure
    self._check_or_create()
  File "/opt/infra_virtualenv/venv/cros_venv/venvlib.py", line 108, in _check_or_create
    self._create()
  File "/opt/infra_virtualenv/venv/cros_venv/venvlib.py", line 117, in _create
    logfile=logfile)
  File "/opt/infra_virtualenv/venv/cros_venv/venvlib.py", line 209, in _create_venv
    _log_check_call(command, logfile=logfile)
  File "/opt/infra_virtualenv/venv/cros_venv/venvlib.py", line 254, in wrapped_command
    call_func(args, stdout=logfile, **kwargs)
  File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[u'virtualenv', u'/home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d', u'-p', u'/usr/bin/python2.7', u'--extra-search-dir', u'/opt/infra_virtualenv/pip_packages', u'--setuptools', u'--clear']' returned non-zero exit status 100
ERROR: Failed to set up a virtualenv.

Comment 23 by hadd...@google.com, Apr 23 2018

I also found this log
moblab@localhost /etc/init $ cat /home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d/create.log 
Running [u'virtualenv', u'/home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d', u'-p', u'/usr/bin/python2.7', u'--extra-search-dir', u'/opt/infra_virtualenv/pip_packages', u'--setuptools', u'--clear']
Already using interpreter /usr/bin/python2.7
Not deleting /home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d/bin
New python executable in /home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d/bin/python2.7
Also creating executable in /home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d/bin/python
ERROR: The executable /home/moblab/.cache/cros_venv/venv-2.7.10-5e245727ed23dd962b0bb6d1c7a40f7d/bin/python2.7 could not be run: [Errno 13] Permission denied

Comment 24 by hadd...@google.com, Apr 23 2018

Looks like there stateful partition on moblab is mounted noexec

/dev/sda1 on /mnt/stateful_partition type ext4 (rw,nosuid,nodev,noexec,noatime,commit=30,data=ordered)

Any way to control where the virtual env is created ?
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/ec4ec1cc25376e8c752d92b34c0f5d282d059af0

commit ec4ec1cc25376e8c752d92b34c0f5d282d059af0
Author: Allen Li <ayatane@google.com>
Date: Tue Apr 24 01:09:12 2018

Add CROS_VENV_CACHE to allow alternate path

BUG= chromium:830765 
TEST=None

Change-Id: I594402a91eff18dec9f781cad8b3a7ebe245f209
Reviewed-on: https://chromium-review.googlesource.com/1025012
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/ec4ec1cc25376e8c752d92b34c0f5d282d059af0/venv/cros_venv/venvlib.py

Project Member

Comment 27 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/84894d708f7715f6fa7c7e7db451a9b9b8e26c4e

commit 84894d708f7715f6fa7c7e7db451a9b9b8e26c4e
Author: Allen Li <ayatane@google.com>
Date: Tue Apr 24 15:59:37 2018

Add CROS_VENV_CACHE to allow alternate path

BUG= chromium:830765 
TEST=None

Change-Id: I594402a91eff18dec9f781cad8b3a7ebe245f209
Reviewed-on: https://chromium-review.googlesource.com/1025012
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit ec4ec1cc25376e8c752d92b34c0f5d282d059af0)

[modify] https://crrev.com/84894d708f7715f6fa7c7e7db451a9b9b8e26c4e/venv/cros_venv/venvlib.py

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/57e604af8c79ad1899501eff286fbf976a5f335f

commit 57e604af8c79ad1899501eff286fbf976a5f335f
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 24 16:02:33 2018

Use alternate cros_venv cache

Since /home is noexec on non-test images.

BUG= chromium:830765 
TEST=None

Change-Id: Ie77c00f0e4c177b22c936414ae08a1fcf9d3d774
Reviewed-on: https://chromium-review.googlesource.com/1024960
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 18b46c77bf9a822eaef9d146815670d5c090e1d9)
Reviewed-on: https://chromium-review.googlesource.com/1025082
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/57e604af8c79ad1899501eff286fbf976a5f335f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/57e604af8c79ad1899501eff286fbf976a5f335f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Comment 29 by hadd...@google.com, Apr 25 2018

export CROS_VENV_CACHE=/usr/local/.cros-venv-cache

moblab@localhost ~ $ sudo mkdir $CROS_VENV_CACHE
moblab@localhost ~ $ sudo chown moblab:moblab $CROS_VENV_CACHE
moblab@localhost ~ $ /usr/local/autotest/bin/job_aborter --jobdir /usr/local/autotest/leases

I will take care of the conf file changes to make sure the cache directory exists, can you help look into the chromite error please.

job_aborter: 2018-04-25 09:16:32,705:ERROR:autotest:_global_setup:60:Uncaught exception escaped Autotest setup
Traceback (most recent call last):
  File "/usr/local/autotest/venv/lucifer/autotest.py", line 56, in _global_setup
    yield
  File "/usr/local/autotest/venv/lucifer/autotest.py", line 47, in monkeypatch
    _monkeypatch_body()
  File "/usr/local/autotest/venv/lucifer/autotest.py", line 76, in _monkeypatch_body
    importlib.import_module('chromite')
  File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
ImportError: No module named chromite

Comment 30 by hadd...@google.com, Apr 25 2018

Not sure if this helps.

moblab@localhost ~ $ sudo find / -name chromite*
/usr/lib64/python2.7/site-packages/chromite
/usr/lib64/python2.7/site-packages/chromite/venv/chromite
/usr/lib64/python2.7/site-packages/chromite/bootstrap/support/chromite_wrapper

Outside of moblab, chromite is at /usr/local/autotest/site-package/chromite (set up by Autotest).  In theory this should be handled automagically, but apparently I overlooked something.
re #31, I mean switching between the Autotest version and the moblab installed version of chromite should be handled already.

Comment 33 by hadd...@google.com, Apr 25 2018

Let me check ToT perhaps just some more CL's that need to be CP'd back to M65
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/52362f917c82ac73c60855978a7598f535f39638

commit 52362f917c82ac73c60855978a7598f535f39638
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Apr 25 18:53:38 2018

[moblab] Fix job_aborter startup.

Ensure the cache directory exists and is owned by moblab.
remove setuid moblab - not available in this version of upstart.

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: I6befd057d0ea4178bc5cfb0ef2d63b3d736212ac
Reviewed-on: https://chromium-review.googlesource.com/1028616
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/52362f917c82ac73c60855978a7598f535f39638/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/52362f917c82ac73c60855978a7598f535f39638/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

re #33 this is what it looks like working on a lab dut

moblab@localhost /root $ /usr/local/autotest/bin/job_aborter --jobdir /usr/local/autotest/leases/                                                            
job_aborter: 2018-04-25 12:09:17,429:INFO:job_aborter:main:46:Starting with args: Namespace(jobdir='/usr/local/autotest/leases/')
job_aborter: 2018-04-25 12:09:17,430:INFO:autotest:_monkeypatch_body:86:Could not find chromite; adding system packages and retrying (This should only happen on Moblab)


That last line is the chromite support.

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/887625
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/2ce9b356a94b34658ae7340b0e8c68611e44be03

commit 2ce9b356a94b34658ae7340b0e8c68611e44be03
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Apr 26 06:00:36 2018

[moblab] Fix job_aborter startup.

Ensure the cache directory exists and is owned by moblab.
remove setuid moblab - not available in this version of upstart.

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: I6befd057d0ea4178bc5cfb0ef2d63b3d736212ac
Reviewed-on: https://chromium-review.googlesource.com/1028473
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/2ce9b356a94b34658ae7340b0e8c68611e44be03/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/2ce9b356a94b34658ae7340b0e8c68611e44be03/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5e610e1fb2b01ad624e506cc4c9ef69c4ab959f3

commit 5e610e1fb2b01ad624e506cc4c9ef69c4ab959f3
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Apr 26 21:39:17 2018

[moblab] Fix job_aborter startup.

Removed the runlevel syntax on job_aborter - it was not working
on moblab.

Changed the sudo command to use -E option to preserve the
enviroment variable.

Followup fixes from previous review 1028473

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: I96676a482e597b0000293f4deb0af29df5673879
Reviewed-on: https://chromium-review.googlesource.com/1031119
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/5e610e1fb2b01ad624e506cc4c9ef69c4ab959f3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/5e610e1fb2b01ad624e506cc4c9ef69c4ab959f3/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 38 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/30ba08feff2fbc91a2099fdc395fcfa65f2c0743

commit 30ba08feff2fbc91a2099fdc395fcfa65f2c0743
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Apr 26 22:47:54 2018

Revert "[moblab] Fix job_aborter startup."

This reverts commit 5e610e1fb2b01ad624e506cc4c9ef69c4ab959f3.

Reason for revert: Errors in original CL

Original change's description:
> [moblab] Fix job_aborter startup.
> 
> Removed the runlevel syntax on job_aborter - it was not working
> on moblab.
> 
> Changed the sudo command to use -E option to preserve the
> enviroment variable.
> 
> Followup fixes from previous review 1028473
> 
> BUG= chromium:830765 
> TEST=copied onto local moblab and started / stopped scripts
> 
> Change-Id: I96676a482e597b0000293f4deb0af29df5673879
> Reviewed-on: https://chromium-review.googlesource.com/1031119
> Reviewed-by: Keith Haddow <haddowk@chromium.org>
> Commit-Queue: Keith Haddow <haddowk@chromium.org>
> Tested-by: Keith Haddow <haddowk@chromium.org>

Bug:  chromium:830765 
Change-Id: I224d5e33487781ed2640a58e8968a14db52784d4
Reviewed-on: https://chromium-review.googlesource.com/1031517
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/30ba08feff2fbc91a2099fdc395fcfa65f2c0743/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/30ba08feff2fbc91a2099fdc395fcfa65f2c0743/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 39 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d2392c81f5955b03f37a29f0aef90aca598c8d89

commit d2392c81f5955b03f37a29f0aef90aca598c8d89
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Apr 27 01:07:59 2018

[moblab] Fix job_aborter startup.

- reland of cl/1031381

Removed the runlevel syntax on job_aborter - it was not working
on moblab.

Changed the sudo command to use -E option to preserve the
enviroment variable.

Followup fixes from previous review 1028473

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: Ieb1d24f841a8ceab82594fff29f2858598b97cf0
Reviewed-on: https://chromium-review.googlesource.com/1031299
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/d2392c81f5955b03f37a29f0aef90aca598c8d89/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/d2392c81f5955b03f37a29f0aef90aca598c8d89/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 40 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8d5c31ed1564cb8232ddb30b7a499996ac5cb850

commit 8d5c31ed1564cb8232ddb30b7a499996ac5cb850
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Apr 27 20:22:15 2018

[moblab] Move job_aborter to the init directory.

BUG= chromium:830765 
TEST=None

Change-Id: Ie14b2ac1575fea99311570be7753880a0cbfd487
Reviewed-on: https://chromium-review.googlesource.com/1017343
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 907fba3eed002a25d2b923a648286a1250434b12)
Reviewed-on: https://chromium-review.googlesource.com/1033494
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/8d5c31ed1564cb8232ddb30b7a499996ac5cb850/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 41 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f9e1083d7195cf952822649f651910a1c70cc466

commit f9e1083d7195cf952822649f651910a1c70cc466
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 27 20:25:33 2018

Use alternate cros_venv cache

Since /home is noexec on non-test images.

BUG= chromium:830765 
TEST=None

Change-Id: Ie77c00f0e4c177b22c936414ae08a1fcf9d3d774
Reviewed-on: https://chromium-review.googlesource.com/1024960
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 18b46c77bf9a822eaef9d146815670d5c090e1d9)
Reviewed-on: https://chromium-review.googlesource.com/1033496
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/f9e1083d7195cf952822649f651910a1c70cc466/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/f9e1083d7195cf952822649f651910a1c70cc466/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 42 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/aeb9132eebd8fd32168506e91f4ed7679d247b2f

commit aeb9132eebd8fd32168506e91f4ed7679d247b2f
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 27 20:25:42 2018

moblab: Remove unsupported stanza

BUG= chromium:830765 
TEST=None

Change-Id: I55687aa0ce75b50c6abb8e1f8ba0233fe2cab5b9
Reviewed-on: https://chromium-review.googlesource.com/1022473
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit ec3055009087a04722b8ebdaf85fafbe29ae8363)
Reviewed-on: https://chromium-review.googlesource.com/1033495
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/aeb9132eebd8fd32168506e91f4ed7679d247b2f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 43 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/d466e7427fd84aeab179e18fe59ab811abe907af

commit d466e7427fd84aeab179e18fe59ab811abe907af
Author: Allen Li <ayatane@google.com>
Date: Fri Apr 27 20:25:34 2018

Add CROS_VENV_CACHE to allow alternate path

BUG= chromium:830765 
TEST=None

Change-Id: I594402a91eff18dec9f781cad8b3a7ebe245f209
Reviewed-on: https://chromium-review.googlesource.com/1025012
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit ec4ec1cc25376e8c752d92b34c0f5d282d059af0)

[modify] https://crrev.com/d466e7427fd84aeab179e18fe59ab811abe907af/venv/cros_venv/venvlib.py

Project Member

Comment 44 by bugdroid1@chromium.org, Apr 27 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra_virtualenv/+/b0080ed7c65f4535e328250e8138243e4770bf61

commit b0080ed7c65f4535e328250e8138243e4770bf61
Author: Allen Li <ayatane@google.com>
Date: Fri Apr 27 20:25:57 2018

Add CROS_VENV_CACHE to allow alternate path

BUG= chromium:830765 
TEST=None

Change-Id: I594402a91eff18dec9f781cad8b3a7ebe245f209
Reviewed-on: https://chromium-review.googlesource.com/1025012
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit ec4ec1cc25376e8c752d92b34c0f5d282d059af0)

[modify] https://crrev.com/b0080ed7c65f4535e328250e8138243e4770bf61/venv/cros_venv/venvlib.py

Project Member

Comment 45 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/688956e7a11c77e05931c5182b4888e626319f1c

commit 688956e7a11c77e05931c5182b4888e626319f1c
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat Apr 28 01:05:15 2018

[moblab] Fix job_aborter startup.

- reland of cl/1031381

Removed the runlevel syntax on job_aborter - it was not working
on moblab.

Changed the sudo command to use -E option to preserve the
enviroment variable.

Followup fixes from previous review 1028473

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: Ieb1d24f841a8ceab82594fff29f2858598b97cf0
Reviewed-on: https://chromium-review.googlesource.com/1031773
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/688956e7a11c77e05931c5182b4888e626319f1c/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/688956e7a11c77e05931c5182b4888e626319f1c/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 46 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/400ec0b4c0d68df713baec706fa95bc295a9bdbc

commit 400ec0b4c0d68df713baec706fa95bc295a9bdbc
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Apr 30 18:52:33 2018

[moblab] Fix job_aborter startup.

Ensure the cache directory exists and is owned by moblab.
remove setuid moblab - not available in this version of upstart.

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: I6befd057d0ea4178bc5cfb0ef2d63b3d736212ac
Reviewed-on: https://chromium-review.googlesource.com/1028473
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1035458
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/400ec0b4c0d68df713baec706fa95bc295a9bdbc/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/400ec0b4c0d68df713baec706fa95bc295a9bdbc/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 47 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/51673f1cc47c046394db23c637d08459f5cc27e9

commit 51673f1cc47c046394db23c637d08459f5cc27e9
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Apr 30 21:14:46 2018

[moblab] Fix job_aborter startup.

- reland of cl/1031381

Removed the runlevel syntax on job_aborter - it was not working
on moblab.

Changed the sudo command to use -E option to preserve the
enviroment variable.

Followup fixes from previous review 1028473

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: Ieb1d24f841a8ceab82594fff29f2858598b97cf0
Reviewed-on: https://chromium-review.googlesource.com/1031773
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 688956e7a11c77e05931c5182b4888e626319f1c)
Reviewed-on: https://chromium-review.googlesource.com/1035822
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/51673f1cc47c046394db23c637d08459f5cc27e9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/51673f1cc47c046394db23c637d08459f5cc27e9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 48 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7954182f4118fb6120e2147e68447bf907542992

commit 7954182f4118fb6120e2147e68447bf907542992
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Apr 30 21:14:59 2018

[moblab] Move job_aborter to the init directory.

BUG= chromium:830765 
TEST=None

Change-Id: Ie14b2ac1575fea99311570be7753880a0cbfd487
Reviewed-on: https://chromium-review.googlesource.com/1017343
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 907fba3eed002a25d2b923a648286a1250434b12)
Reviewed-on: https://chromium-review.googlesource.com/1035823
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/7954182f4118fb6120e2147e68447bf907542992/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 49 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9ea5c538af8ee7e334dfbabc84999a8cd1db7614

commit 9ea5c538af8ee7e334dfbabc84999a8cd1db7614
Author: Allen Li <ayatane@chromium.org>
Date: Mon Apr 30 21:15:37 2018

moblab: Remove unsupported stanza

BUG= chromium:830765 
TEST=None

Change-Id: I55687aa0ce75b50c6abb8e1f8ba0233fe2cab5b9
Reviewed-on: https://chromium-review.googlesource.com/1022473
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit ec3055009087a04722b8ebdaf85fafbe29ae8363)
Reviewed-on: https://chromium-review.googlesource.com/1036282
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/9ea5c538af8ee7e334dfbabc84999a8cd1db7614/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 50 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/eac4af496fef9aa5357fafe04db8b926fd41977f

commit eac4af496fef9aa5357fafe04db8b926fd41977f
Author: Allen Li <ayatane@chromium.org>
Date: Mon Apr 30 21:16:10 2018

Use alternate cros_venv cache

Since /home is noexec on non-test images.

BUG= chromium:830765 
TEST=None

Change-Id: Ie77c00f0e4c177b22c936414ae08a1fcf9d3d774
Reviewed-on: https://chromium-review.googlesource.com/1024960
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 18b46c77bf9a822eaef9d146815670d5c090e1d9)
Reviewed-on: https://chromium-review.googlesource.com/1036283
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/eac4af496fef9aa5357fafe04db8b926fd41977f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/eac4af496fef9aa5357fafe04db8b926fd41977f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 51 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7a4064ce547a1fc8d4eaee1b9cace1d9bbb192db

commit 7a4064ce547a1fc8d4eaee1b9cace1d9bbb192db
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Apr 30 21:17:05 2018

[moblab] Fix job_aborter startup.

Ensure the cache directory exists and is owned by moblab.
remove setuid moblab - not available in this version of upstart.

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: I6befd057d0ea4178bc5cfb0ef2d63b3d736212ac
Reviewed-on: https://chromium-review.googlesource.com/1028473
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit 2ce9b356a94b34658ae7340b0e8c68611e44be03)
Reviewed-on: https://chromium-review.googlesource.com/1036284
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/7a4064ce547a1fc8d4eaee1b9cace1d9bbb192db/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/7a4064ce547a1fc8d4eaee1b9cace1d9bbb192db/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 52 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ca6e4d16f78fc4b6de5078b0927a74bd8587013b

commit ca6e4d16f78fc4b6de5078b0927a74bd8587013b
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Apr 30 21:17:35 2018

[moblab] Fix job_aborter startup.

- reland of cl/1031381

Removed the runlevel syntax on job_aborter - it was not working
on moblab.

Changed the sudo command to use -E option to preserve the
enviroment variable.

Followup fixes from previous review 1028473

BUG= chromium:830765 
TEST=copied onto local moblab and started / stopped scripts

Change-Id: Ieb1d24f841a8ceab82594fff29f2858598b97cf0
Reviewed-on: https://chromium-review.googlesource.com/1031773
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 688956e7a11c77e05931c5182b4888e626319f1c)
Reviewed-on: https://chromium-review.googlesource.com/1036285
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/ca6e4d16f78fc4b6de5078b0927a74bd8587013b/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf
[modify] https://crrev.com/ca6e4d16f78fc4b6de5078b0927a74bd8587013b/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 53 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f306f0b8f39bdc1820e4f04122228f2d07519006

commit f306f0b8f39bdc1820e4f04122228f2d07519006
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu May 10 18:26:23 2018

[moblab] Ensure job_aborter is executed at the correct time.

Job aborter needs the autotest setup to be complete and the
database to be active.

Added in standard bootup debugging that helped solve these issues.

BUG= chromium:830765 
TEST=built and tested on moblab

Change-Id: I347510bfccc0331ecfbe8caa37bfe7ac9f885917
Reviewed-on: https://chromium-review.googlesource.com/1054267
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/f306f0b8f39bdc1820e4f04122228f2d07519006/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 54 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ae1dea27c44370903a7fa9ee4946145e3ac92248

commit ae1dea27c44370903a7fa9ee4946145e3ac92248
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 11 06:18:07 2018

[moblab] Ensure job_aborter is executed at the correct time.

Job aborter needs the autotest setup to be complete and the
database to be active.

Added in standard bootup debugging that helped solve these issues.

BUG= chromium:830765 
TEST=built and tested on moblab

Change-Id: I347510bfccc0331ecfbe8caa37bfe7ac9f885917
Reviewed-on: https://chromium-review.googlesource.com/1054185
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/ae1dea27c44370903a7fa9ee4946145e3ac92248/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 55 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/b764aece017badcde8f48649b719017a0e80e2fb

commit b764aece017badcde8f48649b719017a0e80e2fb
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 11 17:35:54 2018

Revert "[moblab] Ensure job_aborter is executed at the correct time."

This reverts commit f306f0b8f39bdc1820e4f04122228f2d07519006.

Reason for revert: Original CL was updated after CP

Original change's description:
> [moblab] Ensure job_aborter is executed at the correct time.
> 
> Job aborter needs the autotest setup to be complete and the
> database to be active.
> 
> Added in standard bootup debugging that helped solve these issues.
> 
> BUG= chromium:830765 
> TEST=built and tested on moblab
> 
> Change-Id: I347510bfccc0331ecfbe8caa37bfe7ac9f885917
> Reviewed-on: https://chromium-review.googlesource.com/1054267
> Reviewed-by: Keith Haddow <haddowk@chromium.org>
> Commit-Queue: Keith Haddow <haddowk@chromium.org>
> Tested-by: Keith Haddow <haddowk@chromium.org>

Bug:  chromium:830765 
Change-Id: I99db55b84e0fd9753c1164dfdd50274dd9efa6d2
Reviewed-on: https://chromium-review.googlesource.com/1054750
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/b764aece017badcde8f48649b719017a0e80e2fb/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 56 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0c45090517223ee739c6e33441f121618c27997f

commit 0c45090517223ee739c6e33441f121618c27997f
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 11 17:41:31 2018

[moblab] Ensure job_aborter is executed at the correct time.

Job aborter needs the autotest setup to be complete and the
database to be active.

Added in standard bootup debugging that helped solve these issues.

BUG= chromium:830765 
TEST=built and tested on moblab

Change-Id: I347510bfccc0331ecfbe8caa37bfe7ac9f885917
Reviewed-on: https://chromium-review.googlesource.com/1054185
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
(cherry picked from commit ae1dea27c44370903a7fa9ee4946145e3ac92248)
Reviewed-on: https://chromium-review.googlesource.com/1054751
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/0c45090517223ee739c6e33441f121618c27997f/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Project Member

Comment 57 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1f3a57ac42525c255c91b06ddc45ac4641794d68

commit 1f3a57ac42525c255c91b06ddc45ac4641794d68
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 11 17:54:38 2018

[moblab] Ensure job_aborter is executed at the correct time.

Job aborter needs the autotest setup to be complete and the
database to be active.

Added in standard bootup debugging that helped solve these issues.

BUG= chromium:830765 
TEST=built and tested on moblab

Change-Id: I2af817e47c2ea8023c52ea6050ba1c131f6ebf96
Reviewed-on: https://chromium-review.googlesource.com/1055662
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/1f3a57ac42525c255c91b06ddc45ac4641794d68/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/job_aborter.conf

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)

Sign in to add a comment