New issue
Advanced search Search tips

Issue 830730 link

Starred by 1 user
Status: WontFix
Owner:
wjmaclean@chromium.org
Closed: Apr 2018
Cc:
kenrb@chromium.org
wjmaclean@chromium.org
sullivan@chromium.org
primiano@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 823871


Sign in to add a comment

105.5%-429% regression in system_health.memory_desktop at 548917:549053

Project Member Reported by primiano@chromium.org, Apr 9 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 9 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830730

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a33fba929ff6ff5c8e257a16360b9a0b401113f199e935c73de36cea7a4ee1a4


Bot(s) for this bug's original alert(s):

android-webview-nexus6
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 9 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/131e6338c40000

Comment 5 by sullivan@chromium.org, Apr 10 2018

Cc: sullivan@chromium.org
Trying bisect on webview since this didn't repro on linux.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Apr 11 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/149b03bcc40000
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Apr 13 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/168f2582c40000

Comment 10 by simonhatch@chromium.org, Apr 13 2018

Blockedon: 823871
These are failing with swarming timeouts, not enough devices, blocking on crbug.com/823871
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Apr 15 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14c6042ac40000
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Apr 17 2018

Cc: kenrb@chromium.org wjmaclean@chromium.org
Owner: wjmaclean@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148b457ac40000

Revert "Test for adding gesture target that's not in map." by wjmaclean@chromium.org
https://chromium.googlesource.com/chromium/src/+/a49abb1509a7808645847913b115cfca0b281949

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 14 by wjmaclean@chromium.org, Apr 17 2018 

I have a *very* hard time believing that *reverting* my CL cause a performance regression. (The original CL itself almost certainly did cause a regression.)

I'm assuming this was assigned by an automated process ... are we sure it's found the right CL?

Comment 15 by sullivan@chromium.org, Apr 17 2018 

Looking at the graph: https://chromeperf.appspot.com/group_report?bug_id=830730

Memory drops at the land, and goes up at the revert. I'm pretty sure it's the right CL, but maybe there was a bug in the original CL that caused it to cut skia memory in half on this page? Or maybe it's a timing issue with the CL and the benchmark?

I think it's okay to WontFix this.

Comment 16 by wjmaclean@chromium.org, Apr 17 2018

Status: WontFix (was: Assigned)
Definitely. The original CL did nothing but add a DumpWithoutCrashing, which unfortunately got called too often (hence the need to revert).

Comment 17 by wjmaclean@chromium.org, Apr 19 2018 

 Issue 830724  has been merged into this issue.
►

Sign in to add a comment