Valgrind (and other profiling tools) are broken when using LLD for linking |
||
Issue descriptionThis a KI issue with Valgrind, https://bugs.kde.org/show_bug.cgi?id=384727. LLD produces debugging information in a slightly different format then what Valgrind expects. We have turned on LLD as the default of Linux, which caused this bug to be seen by the PDFium team. This issue can be worked around by passing --no-rosegment to LLD. I have talked with thakis@ about this OOB. I am going to add a gn arg for passing this flag, so that we can work around this issue while waiting for an upstream fix.
,
Apr 11 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/63c5fa9cf2250dcd91dd88d8233c0d9d93b1d917 commit 63c5fa9cf2250dcd91dd88d8233c0d9d93b1d917 Author: Ryan Harrison <rharrison@chromium.org> Date: Wed Apr 11 14:50:41 2018 Add documentation about Valgrind LLD workaround BUG= chromium:830706 Change-Id: I72ea6373d898953c10e523399655f1f630941b09 Reviewed-on: https://pdfium-review.googlesource.com/30110 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/63c5fa9cf2250dcd91dd88d8233c0d9d93b1d917/docs/safetynet.md [modify] https://crrev.com/63c5fa9cf2250dcd91dd88d8233c0d9d93b1d917/README.md
,
Apr 11 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b45464bb8cd14b468d28e6cb80cd207441baf5c9 commit b45464bb8cd14b468d28e6cb80cd207441baf5c9 Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 12 06:25:13 2018 Roll src/third_party/pdfium/ 6bebd2e3c..87b67f842 (8 commits) https://pdfium.googlesource.com/pdfium.git/+log/6bebd2e3cfb7..87b67f842fe5 $ git log 6bebd2e3c..87b67f842 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 tsepez Remove CFX_DIBAttribute::m_strAuthor 2018-04-11 hnakashima Fix crash when ColorSpace references itself directly. 2018-04-11 tsepez Fix issues with PDFium third_party/base/span.h 2018-04-11 tsepez Remove use of GetBuffer()/ReleaseBuffer() when c_str() is sufficient. 2018-04-11 tsepez Make cxfa_fmlexer.cpp resilient to null strings 2018-04-11 tsepez Fix trailing whitespace handling in CPDF_StreamParser::ReadInlineStream() 2018-04-11 rharrison Reserve space to reduce memory operations while encoding barcode 2018-04-11 rharrison Add documentation about Valgrind LLD workaround Created with: roll-dep src/third_party/pdfium BUG= chromium:828206 , chromium:831498 , chromium:802242 , chromium:830706 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7134510b37a0aab373bdff663020825afe63436f Reviewed-on: https://chromium-review.googlesource.com/1008962 Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550047} [modify] https://crrev.com/b45464bb8cd14b468d28e6cb80cd207441baf5c9/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 9 2018