New issue
Advanced search Search tips

Issue 830689 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Apparent reliance on creation time uniqueness in CookieStoreIOS::DeleteCanonicalCookieAsync

Project Member Reported by morlovich@chromium.org, Apr 9 2018

Issue description

Stumbled on this in a code review:

void CookieStoreIOS::DeleteCanonicalCookieAsync(const CanonicalCookie& cookie,
   ....

  // This relies on the fact cookies are given unique creation dates.
  CookieFilterFunction filter = base::Bind(
      IsCookieCreatedBetween, cookie.CreationDate(), cookie.CreationDate());
  DeleteCookiesWithFilterAsync(std::move(filter), std::move(callback));
}

CookieMonster has been moving away from having unique creation dates, so this might no longer 
work correctly now, or stop working soon. I haven't looked at iOS code yet[1], though, so this may be wrong,
but seems worth due diligence.

[1] This bit came up in a code review.


 

Comment 1 by pkl@chromium.org, Apr 9 2018

Cc: eugene...@chromium.org
Owner: mrefaat@chromium.org
Status: Assigned (was: Untriaged)
I didn't assign a milestone because I would like someone to assess the severity. If this seems like something that we should fix, please apply a M-67 label for this.
Hmm, might not actually be a bug in practice since it seems like CookieStoreIOS generates uniqueness itself via creation_time_manager_->MakeUniqueCreationTime, though it's hard for me to be certain --- if it never actually imports a cookie from cookie monster than it's probably OK, though likely some of this weirdness can be removed eventually. 

(While CookieStoreIOSPersistent just seems to forward everything to CookieMonster?)


Sign in to add a comment