Apparent reliance on creation time uniqueness in CookieStoreIOS::DeleteCanonicalCookieAsync |
|
Issue description
Stumbled on this in a code review:
void CookieStoreIOS::DeleteCanonicalCookieAsync(const CanonicalCookie& cookie,
....
// This relies on the fact cookies are given unique creation dates.
CookieFilterFunction filter = base::Bind(
IsCookieCreatedBetween, cookie.CreationDate(), cookie.CreationDate());
DeleteCookiesWithFilterAsync(std::move(filter), std::move(callback));
}
CookieMonster has been moving away from having unique creation dates, so this might no longer
work correctly now, or stop working soon. I haven't looked at iOS code yet[1], though, so this may be wrong,
but seems worth due diligence.
[1] This bit came up in a code review.
,
Apr 9 2018
Hmm, might not actually be a bug in practice since it seems like CookieStoreIOS generates uniqueness itself via creation_time_manager_->MakeUniqueCreationTime, though it's hard for me to be certain --- if it never actually imports a cookie from cookie monster than it's probably OK, though likely some of this weirdness can be removed eventually. (While CookieStoreIOSPersistent just seems to forward everything to CookieMonster?) |
|
►
Sign in to add a comment |
|
Comment 1 by pkl@chromium.org
, Apr 9 2018Owner: mrefaat@chromium.org
Status: Assigned (was: Untriaged)