New issue
Advanced search Search tips

Issue 830675 link

Starred by 1 user
Status: Fixed
Owner:
penghuang@chromium.org
Closed: May 2018
Cc:
niklase@chromium.org
emir...@chromium.org
penghuang@chromium.org
dalecur...@chromium.org
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28%-2279.1% regression in browser_tests at 548801:548819

Project Member Reported by emir...@chromium.org, Apr 9 2018 
There is a clear regression in this range, affecting a couple metrics.
Skipped frames: Percentage of frames that aren't picked up by the compositor corresponding to vsync interval. In short, they are not displayed. This has gone pretty bad. 
Render Algorithm Latency Max: Time between EnqueueFrame() and SetCurrentFrame() calls. 
Compositor Picking Frame Latency Mean: Time between SetCurrentFrame() and GetcurrentFrame() calls.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 9 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830675

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3e4f4ecf08e4e87e1a7f0aec89eac7d76aa5a42d38e9e96226e36e583e6e44d8


Bot(s) for this bug's original alert(s):

chromium-webrtc-rel-linux

Comment 2 by emir...@chromium.org, Apr 9 2018

Cc: dalecur...@chromium.org
Owner: penghuang@chromium.org
Status: Assigned (was: Untriaged)
There is CrOS only compositor related CL in the range:
https://chromium.googlesource.com/chromium/src/+/400c1e296933da71f3b4e3a04b0843297dd4ffa4

penghuang@ can you take a look? This CL seems to have an adverse affect on displaying real time video.

Comment 3 by emir...@chromium.org, Apr 9 2018

Components: Blink>WebRTC>Video
Labels: OS-Linux
*linux only

Comment 4 by emir...@chromium.org, Apr 12 2018 

penghuang@ I can't reproduce the regression locally either, skipped frames is ~0. I believe that is related to my local machine vs the bot performance. However, the regression metrics still give some hints. 

"Render Algorithm Latency Max" is doubled. That is the time between WebMediaPlayerMSCompositor::EnqueueFrame() and WebMediaPlayerMSCompositor::SetCurrentFrame() calls. This can only be affected by presentation interval given to UpdateCurrentFrame()[0][1]. the interval is solid 0.016 on my local machine. However, if that is affected in the bots such that interval is longer after your CL, that can explain what is happening. Does that seem likely?
 
[0] https://cs.chromium.org/chromium/src/content/renderer/media/stream/webmediaplayer_ms_compositor.cc?type=cs&sq=package:chromium&l=270
[1] https://cs.chromium.org/chromium/src/cc/layers/video_frame_provider.h?type=cs&sq=package:chromium&l=62

Comment 5 Deleted

Comment 6 by penghuang@chromium.org, May 3 2018

Owner: penghuang@chromium.org
Status: Assigned (was: Available)
Sorry. I didn't read the graphs correctly. Assigned it back.

Comment 8 by penghuang@chromium.org, May 3 2018 

I have landed several CLs which should improve performance for presentation feedback. So I will land a CL(https://crrev.com/c/1040725) to turn on the presentation feedback again. Wish the regression will not happen anymore.

Comment 9 by penghuang@chromium.org, May 6 2018

Status: Fixed (was: Assigned)
My change has been relanded [1]. And there is no regression with it.

[1]https://chromium.googlesource.com/chromium/src/+/3cadd73f42b57196f515bd4be68b1105b4716d1b
►

Sign in to add a comment