New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830672 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Check in/update labstation tools into labtools

Project Member Reported by kevcheng@chromium.org, Apr 9 2018

Issue description

- Check in the following tools to lab_tools:
  * check_labstation.sh (verifies labstation fw/os and flashes as needed):
Status:
  * Update servo-stat to validate servo v4
  * Check in dut_migration tool (crosreview.com/415107)
    *No migrations planned till 6/18 due to servo v4 inventory constraints so no one will be using till then.

 
Cc: haoweiw@chromium.org jrbarnette@chromium.org
Labels: -Pri-3 Pri-1
Have you checked these tools in yet?

I'd like to start assigning the remaining servov4 work, but I believe this is a blocker.

Comment 3 by kevcheng@google.com, Apr 23 2018

Not yet but these are used by the lab team and are using an x20 copy currently.
This tool is obsselete due to dead code found. we might need to rebuild this tool to and place it under lab_tool repo. 
RE #4 can you elaborate?

What tool if any is actually being used?
The tool is call check_labstion.sh. You can find it here. https://x20web.corp.google.com/users/ha/haoweiw/misc/check_labstation.tar

Inside of it, there is bash script call check_labstation.sh.

It contain an dead code line. 
host_at_stable_version() {                                                      
  local EXP_VER=$(atest stable_version list -b guado_labstation | grep guado | awk '{print $3}')

We also need to have this tool added to lab_tool repo. 
Somebody, please check this code in. Who owns it? haoweiw? kevcheng?
that's me (kevcheng)

Sorry for the lag, I'll start the review process next week.
Thanks. In the meantime, I will move it to a proper location for lab team to easy access. 

Sign in to add a comment