https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjIyMzQvbmV0X3VuaXR0ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1RtVjBkMjl5YTBWeWNtOXlURzluWjJsdVowVnVaRlJ2Ulc1a1ZHVnpkQzVWY0d4dllXUkJkRk5vZFhSa2IzZHUMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA The root pipeline had an assertion error yet the analysis status is still pending. Many other analyses are impacted as well.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b213e3443a0ecbba636883f6d769a624c6d686f7 commit b213e3443a0ecbba636883f6d769a624c6d686f7 Author: Shuotao Gao <stgao@chromium.org> Date: Wed May 23 01:54:45 2018 [Findit] Flake Analyzer - Set error on pipeline abortion correctly. In the old code, there is a bug: 1) an instance of MasterAnalysis is retrieved first 2) a ndb transaction is made to update the analysis with an error 3) then the retrieved analysis instance is used to set the end time and overwrite the saved error in the ndb. Bug: 830660 Change-Id: I3ff4b917c2de067c57c95f2586bd9de0a80ee9f0 Reviewed-on: https://chromium-review.googlesource.com/1069829 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/b213e3443a0ecbba636883f6d769a624c6d686f7/appengine/findit/services/flake_failure/flake_analysis_util.py [modify] https://crrev.com/b213e3443a0ecbba636883f6d769a624c6d686f7/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py [modify] https://crrev.com/b213e3443a0ecbba636883f6d769a624c6d686f7/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py [modify] https://crrev.com/b213e3443a0ecbba636883f6d769a624c6d686f7/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
Comment 1 by st...@chromium.org
, Apr 10 2018Owner: st...@chromium.org
Status: Assigned (was: Available)