New issue
Advanced search Search tips

Issue 830658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4%-217% regression in loading.desktop at 548616:548736

Project Member Reported by primiano@chromium.org, Apr 9 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=830658

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1e9dee393108b74876e4ff8f4ffd87f46927ff64e8059c9d4787ae0c816e8bc4


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 10 2018

Cc: ishell@chromium.org mlippautz@chromium.org u...@chromium.org cbruni@chromium.org marja@chromium.org
Owner: marja@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12f5012cc40000

[runtime] Do some more StringTable shrinking by cbruni@chromium.org
https://chromium.googlesource.com/v8/v8/+/6823c0a496a75161e3a82eefc759180b547077e2

[reland] [in-place weak refs] Replace the WeakCell potentially in Map::raw_transitions_. by marja@chromium.org
https://chromium.googlesource.com/v8/v8/+/ceaf02d6138e329560e831265a4391deb7bea7df

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by marja@chromium.org, Apr 11 2018

Owner: cbruni@chromium.org
The main regression point is the stringtable commit from cbruni@.

Comment 5 by marja@chromium.org, Apr 11 2018

Owner: marja@chromium.org
Looking at this:

https://chromeperf.appspot.com/group_report?sid=1e9dee393108b74876e4ff8f4ffd87f46927ff64e8059c9d4787ae0c816e8bc4

it's still too early to say whether the revert fixed (nearly) all of the performance issue and how much remains. For most graphs, the new value is within the noise compared to the old values (before cbruni@'s orig commit).

I'll check the situation again once we get a couple of more runs.

Sign in to add a comment