New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830655 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 826087



Sign in to add a comment

[Findit] Flake Analyzer - Analysis made it to completion but an error is reported

Project Member Reported by lijeffrey@chromium.org, Apr 9 2018

Issue description

Owner: wylieb@chromium.org
Status: Assigned (was: Available)

Comment 2 by st...@chromium.org, Apr 10 2018

Blocking: 826087
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/22f62d09326c59d67fabb1fa1db0fdf30e575359

commit 22f62d09326c59d67fabb1fa1db0fdf30e575359
Author: Brandon Wylie <wylieb@chromium.org>
Date: Wed Apr 11 18:24:25 2018

[Findit] Flake Analyzer - Support a single analysis status in the UI

The old pipelines had three different analyses (1) regression range
(or build-level) status. (2) Culprit analysis (or commit-level) status.
(3) Heuristic analysis status. The new pipelines have only one status,
which is the status for the entire analysis. This change instruments
this in the ui and also on the handler. Notable changes include:
* Support for old analyses (that will assumed to all be completed or
  ended in error since the new pipelines are 100% running now) by
  computing a single analyses server-side.
* Changing the frontend polymer components to support this.
* Changing the template to accept the new status parameter and passing
  that through to polymer element flake-analysis-info.

Bug:  830655 
Change-Id: I11162164582ce13dd6f4164aa6ee50d968bba680
Reviewed-on: https://chromium-review.googlesource.com/1006478
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/22f62d09326c59d67fabb1fa1db0fdf30e575359/appengine/findit/ui/elements/analysis/flake/flake-analysis-info-demo.html
[modify] https://crrev.com/22f62d09326c59d67fabb1fa1db0fdf30e575359/appengine/findit/ui/elements/analysis/flake/flake-analysis-info.html
[modify] https://crrev.com/22f62d09326c59d67fabb1fa1db0fdf30e575359/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/22f62d09326c59d67fabb1fa1db0fdf30e575359/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/22f62d09326c59d67fabb1fa1db0fdf30e575359/appengine/findit/templates/flake/result.html

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bbb50f8f027b0e69b6c68783348fbba5ab9394e9

commit bbb50f8f027b0e69b6c68783348fbba5ab9394e9
Author: Brandon Wylie <wylieb@chromium.org>
Date: Thu Apr 12 00:18:18 2018

[Findit] Flake Analyzer - Support single analysis status for list-flakes

Analyses statuses have been condensed down to one status for the new
pipelines. This change will support this and also the old format.

Bug:  830655 
Change-Id: I7923062a88a59ded5e745e6139ad68fe75280d5f
Reviewed-on: https://chromium-review.googlesource.com/1008965
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/bbb50f8f027b0e69b6c68783348fbba5ab9394e9/appengine/findit/templates/flake/dashboard.html
[modify] https://crrev.com/bbb50f8f027b0e69b6c68783348fbba5ab9394e9/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/bbb50f8f027b0e69b6c68783348fbba5ab9394e9/appengine/findit/handlers/flake/test/list_flakes_test.py

Comment 5 by wylieb@chromium.org, Apr 12 2018

Status: Verified (was: Assigned)

Sign in to add a comment