New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 830653 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ kbr@chromium.org
sadrul@chromium.org
█ hubbe@chromium.org
█ reve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent, GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage fail under asan, msan, and tsan

Project Member Reported by thakis@chromium.org, Apr 9 2018 
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_msan_rel_ng/982

[ RUN      ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent
../../ui/gl/gl_context_glx_unittest.cc:20: Failure
Value of: xdisplay
  Actual: false
Expected: true
[  FAILED  ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent (0 ms)


https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/283782

[ RUN      ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent
../../ui/gl/gl_context_glx_unittest.cc:20: Failure
Value of: xdisplay
  Actual: false
Expected: true
[  FAILED  ] GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent (0 ms)



[ RUN      ] GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage
[8388:8388:0406/061223.473658:32661126906:ERROR:gl_surface_glx.cc(418)] XOpenDisplay failed.
[8388:8388:0406/061223.473714:32661126958:ERROR:gl_initializer_x11.cc(157)] GLSurfaceGLX::InitializeOneOff failed.
../../ui/gl/test/gl_test_helper.cc:77: Failure
The difference between expected and actual is 32, which exceeds error, where
expected evaluates to 32,
actual evaluates to 0, and
error evaluates to 0.
 at 0, 0 channel 1


(I had to get the latter via the swarming output; the link to the test directly didn't work)
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8fc38f72151224ad8cc4582cda864a7721560bc

commit a8fc38f72151224ad8cc4582cda864a7721560bc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Apr 10 02:20:11 2018

Remove msan, tsan test lists and just use asan test lists on all memory bots.

For example, angle_unittests wasn't running on the MSan bot, which wasn't
intentional.  If a test really doesn't work under e.g. TSan, it can
be added to the exceptions file instead.

For another example, https://chromium-review.googlesource.com/#/c/981787/
added cronet tests, but again not to msan.

Disable a few tests that don't pass on tsan or msan.

Bug:  830659 , 830648 ,830653, 830819 ,830944, 830945 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icac81720f32c24497942b9c056c6d6999a866ec6
Reviewed-on: https://chromium-review.googlesource.com/987477
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549382}
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/chromeos/dbus/cras_audio_client_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/third_party/blink/renderer/platform/text/text_run_test.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_context_glx_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_image_shared_memory_unittest.cc

Comment 2 by thakis@chromium.org, Apr 12 2018

Labels: Stability-Memory-AddressSanitizer
Status: Untriaged (was: Unconfirmed)
Summary: GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent, GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage fail under asan, msan, and tsan (was: GLContextGLXTest.DoNotDestroyOnFailedMakeCurrent, GLImageSharedMemory/GLImageCopyTest/4.CopyTexImage fail under msan and tsan)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3695968a8414ad39402dd8c275e53155d170023

commit d3695968a8414ad39402dd8c275e53155d170023
Author: Nico Weber <thakis@chromium.org>
Date: Thu Apr 12 03:33:46 2018

Remove many chromium.memory exceptions.

If we run tests on the main waterfall, we generally should run them
on the memory waterfall as well.

I filed bugs and added comments to those for the few tests that
actually don't pass on the memory waterfall. Most do pass.

Bug: 814403,831667,831674,831676,830653
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0ea3cf12745f089d7fb87da8fc20e2665d86d53f
Reviewed-on: https://chromium-review.googlesource.com/987916
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550005}
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/ui/gl/gl_context_glx_unittest.cc
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/ui/gl/gl_image_shared_memory_unittest.cc

Comment 4 by erikc...@chromium.org, Apr 16 2018

Labels: -OS-Mac

Comment 5 by thakis@chromium.org, Apr 16 2018

Labels: OS-Linux

Comment 6 by thakis@chromium.org, May 8 2018

Cc: kbr@chromium.org
sadrul: This probably needs something like https://bugs.chromium.org/p/chromium/issues/detail?id=830659#c12 -- should these tests move to gl_tests?
►

Sign in to add a comment