New issue
Advanced search Search tips

Issue 830651 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
brianosman@chromium.org
caseq@chromium.org
robertphillips@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

chrome relies on Skia debugger internals

Reported by carycl...@skia.org, Apr 9 2018 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
Building chrome with Skia CL review.skia.org/119894 fails because logging_canvas.cc relies on SkImageFilter::toString() and paint_op_helper.h additionally relies on SkMatrix::toString(), SkColorFilter::toString(), SkMaskFilter::toString(), SkPathEffect::toString(), and SkDrawLooper::toString().

All SkXXX::toString() were at one time used by the older Skia debugger, but it is no longer maintained. All have been replaced by Json equivalents in tools/debugger. 

What is the expected behavior?
Chromium builds should not rely on SkXXX::toString().

What went wrong?
The Skia Team didn't identify the dependency when updating its debugger.

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: stable
OS Version: 10.0
Flash Version:

Comment 1 by caryclark@google.com, Apr 9 2018

Cc: robertphillips@chromium.org brianosman@chromium.org

Comment 2 by robertphillips@chromium.org, Apr 9 2018 

Do we know what their unit tests do with the string information?

Comment 3 by krajshree@chromium.org, Apr 9 2018

Labels: Needs-Triage-M65

Comment 4 by krajshree@chromium.org, Apr 10 2018

Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it seems to be related to unittest. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!

Comment 5 by pfeldman@chromium.org, Apr 10 2018

Cc: caseq@chromium.org
logging_canvas.cc will be used to replay that in the layers debugger in Chrome DevTools. But logging canvas does nothing more than wrapping those toStrings into JsonValue of the same type newer skia tools are using. So all that is needed is calling the Json methods and adjusting for the new JsonValue structure where needed.
Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f95a802baa5836695986793155a70dcac8385e63

commit f95a802baa5836695986793155a70dcac8385e63
Author: Cary Clark <caryclark@google.com>
Date: Fri May 18 20:18:34 2018

remove toString dependency

Skia ::toString is no longer maintained.
Remove Chrome dependency on these internals.

R=enne@chromium.org

Bug:  830651 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I21d9f2a1bc3f4786c07398aa359fabf7a6231f7e
Reviewed-on: https://chromium-review.googlesource.com/1066297
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560007}
[modify] https://crrev.com/f95a802baa5836695986793155a70dcac8385e63/cc/test/paint_op_helper.h
Project Member

Comment 7 by bugdroid1@chromium.org, May 20 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/5191880cbf3ee4d122b0d11b4945fbab0784fda7

commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7
Author: Cary Clark <caryclark@skia.org>
Date: Sun May 20 21:16:37 2018

remove toString

toString may have been used by obsolete debugger only
find out if that is so

R=brianosman@google.com,bsalomon@google.com

Docs-Preview: https://skia.org/?cl=119894
Bug:830651
Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
Reviewed-on: https://skia-review.googlesource.com/119894
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkPaint.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkOffsetImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tools/bookmaker/includeWriter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/samplecode/ClockFaceView.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkBitmap.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkOverdrawColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkPictureShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/Sk1DPathEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkImageShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkStringUtils.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkColorFilterImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkImage.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/gpu/text/GrSDFMaskFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkStringUtils.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkColorShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/docs/SkMatrix_Reference.bmh
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkTileImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkBlurMF.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkTwoPointConicalGradient.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkComposeImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/docs/SkBitmap_Reference.bmh
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkDiscretePathEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkDropShadowImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkMatrix.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkLumaColorFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkColorFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkImageSource.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/gm/imagefiltersbase.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/Sk2DPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkBlitter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkDrawLooper.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkBlurImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkOffsetImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkToSRGBColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkComposeImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkGradientShaderPriv.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkDisplacementMapEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkDashImpl.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/Sk1DPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkShaderBase.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkLumaColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkPathEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkEmbossMaskFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkPaintImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/Sk2DPathEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkEmbossMaskFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tests/GrShapeTest.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkMatrixImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkColorMatrixFilterRowMajor255.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkMorphologyImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkMatrixImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkSweepGradient.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkTileImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkPictureImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkPaintImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkComposeShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkMatrixConvolutionImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/docs/SkImage_Reference.bmh
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkCornerPathEffect.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkRadialGradient.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkTrimPE.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkModeColorFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkLightingImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkMagnifierImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/gpu/GrTestUtils.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tests/QuickRejectTest.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkMergeImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkLayerDrawLooper.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkBitmap.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkLocalMatrixImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkEmptyShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkColorFilterImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkPaint.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tests/CanvasTest.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkImageSource.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/tests/ImageFilterTest.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkMatrix.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkGradientShader.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkMergeImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/core/SkColorMatrixFilterRowMajor255.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/image/SkImage.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/docs/undocumented.bmh
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkToSRGBColorFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkPictureImageFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/core/SkMaskFilter.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkCornerPathEffect.h
[modify] https://crrev.com/5191880cbf3ee4d122b0d11b4945fbab0784fda7/include/effects/SkOverdrawColorFilter.h
Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56a0f63141883ff697e9e2c5a71bdb9a02c67c72

commit 56a0f63141883ff697e9e2c5a71bdb9a02c67c72
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sun May 20 22:53:50 2018

Roll src/third_party/skia/ da17f1e7d..5191880cb (2 commits)

https://skia.googlesource.com/skia.git/+log/da17f1e7df1d..5191880cbf3e

$ git log da17f1e7d..5191880cb --date=short --no-merges --format='%ad %ae %s'
2018-05-18 caryclark remove toString
2018-05-18 brianosman Add drawBitmapLattice to SkDebugCanvas

Created with:
  roll-dep src/third_party/skia
BUG= chromium:830651 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: Ic416a02f00901a15956ee78e8f87dd9ee6d8e3cf
Reviewed-on: https://chromium-review.googlesource.com/1067001
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560205}
[modify] https://crrev.com/56a0f63141883ff697e9e2c5a71bdb9a02c67c72/DEPS
Project Member

Comment 9 by bugdroid1@chromium.org, May 20 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/32a4910e57b1fdd3c8671de1ee85e05ca21d079f

commit 32a4910e57b1fdd3c8671de1ee85e05ca21d079f
Author: Cary Clark <caryclark@google.com>
Date: Sun May 20 23:15:48 2018

Revert "remove toString"

This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7.

Reason for revert: broke flutter

Original change's description:
> remove toString
> 
> toString may have been used by obsolete debugger only
> find out if that is so
> 
> R=​brianosman@google.com,bsalomon@google.com
> 
> Docs-Preview: https://skia.org/?cl=119894
> Bug:830651
> Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> Reviewed-on: https://skia-review.googlesource.com/119894
> Commit-Queue: Cary Clark <caryclark@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org

Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  830651 
Reviewed-on: https://skia-review.googlesource.com/129340
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>

[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkPaint.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkOffsetImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tools/bookmaker/includeWriter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/samplecode/ClockFaceView.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkBitmap.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkOverdrawColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkPictureShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/Sk1DPathEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkImageShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkStringUtils.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkColorFilterImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkImage.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/gpu/text/GrSDFMaskFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkStringUtils.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkColorShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/docs/SkMatrix_Reference.bmh
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkTileImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkBlurMF.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkTwoPointConicalGradient.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkComposeImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/docs/SkBitmap_Reference.bmh
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkDiscretePathEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkDropShadowImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkMatrix.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkLumaColorFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkColorFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkImageSource.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/gm/imagefiltersbase.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/Sk2DPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkBlitter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkDrawLooper.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkBlurImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkOffsetImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkToSRGBColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkComposeImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkGradientShaderPriv.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkDisplacementMapEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkDashImpl.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/Sk1DPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkShaderBase.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkLumaColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkPathEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkEmbossMaskFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkPaintImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/Sk2DPathEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkEmbossMaskFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tests/GrShapeTest.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkMatrixImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkColorMatrixFilterRowMajor255.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkMorphologyImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkMatrixImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkSweepGradient.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkTileImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkPictureImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkPaintImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkComposeShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkMatrixConvolutionImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/docs/SkImage_Reference.bmh
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkCornerPathEffect.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkRadialGradient.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkTrimPE.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkModeColorFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkLightingImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkMagnifierImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/gpu/GrTestUtils.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tests/QuickRejectTest.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkMergeImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkLayerDrawLooper.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkBitmap.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkLocalMatrixImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkEmptyShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkColorFilterImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkPaint.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tests/CanvasTest.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkImageSource.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/tests/ImageFilterTest.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkMatrix.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkGradientShader.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkMergeImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/core/SkColorMatrixFilterRowMajor255.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/image/SkImage.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/docs/undocumented.bmh
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkToSRGBColorFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkPictureImageFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/core/SkMaskFilter.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkCornerPathEffect.h
[modify] https://crrev.com/32a4910e57b1fdd3c8671de1ee85e05ca21d079f/include/effects/SkOverdrawColorFilter.h
Project Member

Comment 10 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa4019ba8d2894465c9aea8c11d411ec1c05c07

commit 4fa4019ba8d2894465c9aea8c11d411ec1c05c07
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 21 00:28:43 2018

Roll src/third_party/skia/ 5191880cb..32a4910e5 (1 commit)

https://skia.googlesource.com/skia.git/+log/5191880cbf3e..32a4910e57b1

$ git log 5191880cb..32a4910e5 --date=short --no-merges --format='%ad %ae %s'
2018-05-20 caryclark Revert "remove toString"

Created with:
  roll-dep src/third_party/skia
BUG= chromium:830651 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I20bc5ec8ec3c5637612f644bbc33d08cd848511e
Reviewed-on: https://chromium-review.googlesource.com/1067004
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560210}
[modify] https://crrev.com/4fa4019ba8d2894465c9aea8c11d411ec1c05c07/DEPS
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd4a35b120907131a9950784eb8acbdb1625cc94

commit dd4a35b120907131a9950784eb8acbdb1625cc94
Author: Cary Clark <caryclark@google.com>
Date: Wed May 23 18:38:40 2018

remove use of SkImageFilter toString

All toString() in Skia are no longer maintained, so replace
it with an explicit string.

R=wangxianzhu@chromium.org,fmalita@chromium.org

Bug:  830651 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I973ced39741a0a99437f8268143b8561ad8fadf8
Reviewed-on: https://chromium-review.googlesource.com/1070331
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561174}
[modify] https://crrev.com/dd4a35b120907131a9950784eb8acbdb1625cc94/third_party/blink/renderer/platform/graphics/logging_canvas.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/92e37b6d79f12ccfaaf7671413316952d182267d

commit 92e37b6d79f12ccfaaf7671413316952d182267d
Author: Cary Clark <caryclark@skia.org>
Date: Thu May 31 11:43:13 2018

Reland "remove toString"

This reverts commit 32a4910e57b1fdd3c8671de1ee85e05ca21d079f.

Reason for revert: SkMatrix::toString use has been removed from flutter and has been picked up in fuchsia

Original change's description:
> Revert "remove toString"
> 
> This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7.
> 
> Reason for revert: broke flutter
> 
> Original change's description:
> > remove toString
> > 
> > toString may have been used by obsolete debugger only
> > find out if that is so
> > 
> > R=​brianosman@google.com,bsalomon@google.com
> > 
> > Docs-Preview: https://skia.org/?cl=119894
> > Bug:830651
> > Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> > Reviewed-on: https://skia-review.googlesource.com/119894
> > Commit-Queue: Cary Clark <caryclark@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
> 
> Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  830651 
> Reviewed-on: https://skia-review.googlesource.com/129340
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Cary Clark <caryclark@google.com>

TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  830651 
Change-Id: Ida8725b6051132d8c46faf99358a8fcc1bcabf34
Reviewed-on: https://skia-review.googlesource.com/129623
Reviewed-by: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>

[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkPaint.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkOffsetImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tools/bookmaker/includeWriter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/samplecode/ClockFaceView.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkBitmap.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkOverdrawColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkPictureShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/Sk1DPathEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkImageShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkStringUtils.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkColorFilterImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkImage.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/gpu/text/GrSDFMaskFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkStringUtils.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkColorShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/docs/SkMatrix_Reference.bmh
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkTileImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkBlurMF.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkTwoPointConicalGradient.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkComposeImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/docs/SkBitmap_Reference.bmh
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkDiscretePathEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkDropShadowImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkMatrix.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkLumaColorFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkColorFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkImageSource.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/gm/imagefiltersbase.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/Sk2DPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkBlitter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkDrawLooper.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkBlurImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkOffsetImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkToSRGBColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkComposeImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkGradientShaderPriv.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkDisplacementMapEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkDashImpl.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/Sk1DPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkShaderBase.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkLumaColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkPathEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkEmbossMaskFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkPaintImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/Sk2DPathEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkEmbossMaskFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tests/GrShapeTest.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkMatrixImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkColorMatrixFilterRowMajor255.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkMorphologyImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkMatrixImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkSweepGradient.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkTileImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkPictureImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkPaintImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkComposeShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkMatrixConvolutionImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/docs/SkImage_Reference.bmh
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkCornerPathEffect.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkRadialGradient.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkTrimPE.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkModeColorFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkLightingImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkMagnifierImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/gpu/GrTestUtils.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tests/QuickRejectTest.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkMergeImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkLayerDrawLooper.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkBitmap.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkLocalMatrixImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkEmptyShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkColorFilterImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkPaint.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tests/CanvasTest.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkImageSource.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/tests/ImageFilterTest.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkMatrix.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkGradientShader.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkMergeImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/core/SkColorMatrixFilterRowMajor255.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/image/SkImage.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/docs/undocumented.bmh
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkToSRGBColorFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkPictureImageFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/core/SkMaskFilter.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkCornerPathEffect.h
[modify] https://crrev.com/92e37b6d79f12ccfaaf7671413316952d182267d/include/effects/SkOverdrawColorFilter.h
Project Member

Comment 13 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/89ad31e97cc886dc6417d9ee2ec79998c1a09912

commit 89ad31e97cc886dc6417d9ee2ec79998c1a09912
Author: Cary Clark <caryclark@google.com>
Date: Thu May 31 12:27:44 2018

Revert "Reland "remove toString""

This reverts commit 92e37b6d79f12ccfaaf7671413316952d182267d.

Reason for revert: toString still used by flutter

Original change's description:
> Reland "remove toString"
> 
> This reverts commit 32a4910e57b1fdd3c8671de1ee85e05ca21d079f.
> 
> Reason for revert: SkMatrix::toString use has been removed from flutter and has been picked up in fuchsia
> 
> Original change's description:
> > Revert "remove toString"
> > 
> > This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7.
> > 
> > Reason for revert: broke flutter
> > 
> > Original change's description:
> > > remove toString
> > > 
> > > toString may have been used by obsolete debugger only
> > > find out if that is so
> > > 
> > > R=​brianosman@google.com,bsalomon@google.com
> > > 
> > > Docs-Preview: https://skia.org/?cl=119894
> > > Bug:830651
> > > Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> > > Reviewed-on: https://skia-review.googlesource.com/119894
> > > Commit-Queue: Cary Clark <caryclark@google.com>
> > > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > 
> > TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
> > 
> > Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  830651 
> > Reviewed-on: https://skia-review.googlesource.com/129340
> > Reviewed-by: Cary Clark <caryclark@google.com>
> > Commit-Queue: Cary Clark <caryclark@google.com>
> 
> TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  830651 
> Change-Id: Ida8725b6051132d8c46faf99358a8fcc1bcabf34
> Reviewed-on: https://skia-review.googlesource.com/129623
> Reviewed-by: Cary Clark <caryclark@skia.org>
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Cary Clark <caryclark@google.com>

TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org

Change-Id: Iafc59ffc1b3db67c520ba31bf12d68e1b46c0ea2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  830651 
Reviewed-on: https://skia-review.googlesource.com/131082
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>

[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkPaint.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkOffsetImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tools/bookmaker/includeWriter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/samplecode/ClockFaceView.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkBitmap.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkOverdrawColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkPictureShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/Sk1DPathEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkImageShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkStringUtils.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkColorFilterImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkImage.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/gpu/text/GrSDFMaskFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkStringUtils.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkColorShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/docs/SkMatrix_Reference.bmh
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkTileImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkBlurMF.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkTwoPointConicalGradient.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkComposeImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/docs/SkBitmap_Reference.bmh
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkDiscretePathEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkDropShadowImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkMatrix.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkLumaColorFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkColorFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkImageSource.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/gm/imagefiltersbase.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/Sk2DPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkBlitter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkDrawLooper.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkBlurImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkOffsetImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkToSRGBColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkComposeImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkGradientShaderPriv.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkDisplacementMapEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkDashImpl.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/Sk1DPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkShaderBase.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkLumaColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkPathEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkEmbossMaskFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkPaintImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/Sk2DPathEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkEmbossMaskFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tests/GrShapeTest.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkMatrixImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkColorMatrixFilterRowMajor255.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkMorphologyImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkMatrixImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkSweepGradient.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkTileImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkPictureImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkPaintImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkComposeShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkMatrixConvolutionImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/docs/SkImage_Reference.bmh
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkCornerPathEffect.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkRadialGradient.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkTrimPE.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkModeColorFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkLightingImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkMagnifierImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/gpu/GrTestUtils.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tests/QuickRejectTest.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkMergeImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkLayerDrawLooper.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkBitmap.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkLocalMatrixImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkEmptyShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkColorFilterImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkPaint.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tests/CanvasTest.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkImageSource.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/tests/ImageFilterTest.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkMatrix.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkGradientShader.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkMergeImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/core/SkColorMatrixFilterRowMajor255.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/image/SkImage.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/docs/undocumented.bmh
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkToSRGBColorFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkPictureImageFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/core/SkMaskFilter.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkCornerPathEffect.h
[modify] https://crrev.com/89ad31e97cc886dc6417d9ee2ec79998c1a09912/include/effects/SkOverdrawColorFilter.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/27dddae3130c8a6cfaa845195b2fb95cc691dd26

commit 27dddae3130c8a6cfaa845195b2fb95cc691dd26
Author: Cary Clark <caryclark@skia.org>
Date: Fri Jun 08 20:36:53 2018

rebase

This reverts commit 32a4910e57b1fdd3c8671de1ee85e05ca21d079f.

Reason for revert: SkMatrix::toString use has been removed from flutter
and has been picked up in fuchsia

Additionally some bookmaker changes take into account recent
additions of typedef comments and the generated header comment.

Original change's description:
> Revert "remove toString"
>
> This reverts commit 5191880cbf3ee4d122b0d11b4945fbab0784fda7.
>
> Reason for revert: broke flutter
>
> Original change's description:
> > remove toString
> >
> > toString may have been used by obsolete debugger only
> > find out if that is so
> >
> > R=​brianosman@google.com,bsalomon@google.com
> >
> > Docs-Preview: https://skia.org/?cl=119894
> > Bug:830651
> > Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> > Reviewed-on: https://skia-review.googlesource.com/119894
> > Commit-Queue: Cary Clark <caryclark@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
>
> Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c

TBR=bsalomon@google.com,brianosman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Reviewed-on: https://skia-review.googlesource.com/129623
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@google.com>
Docs-Preview: https://skia.org/?cl=133583
Bug:  830651 
Change-Id: If8499e796be63580ad419e150e94d43e8b89de1b
Reviewed-on: https://skia-review.googlesource.com/133583
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>

[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkPaint.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/SkImage_Reference.md
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkOffsetImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tools/bookmaker/includeWriter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/samplecode/ClockFaceView.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkLinearGradient.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkBitmap.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkOverdrawColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkPictureShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkPictureShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/Sk1DPathEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkImageShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/undocumented.md
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkStringUtils.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkColorFilterImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkImage.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/gpu/text/GrSDFMaskFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkStringUtils.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkColorShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/docs/SkMatrix_Reference.bmh
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkShaderMaskFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkTableColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkTileImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkBlurMF.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkLocalMatrixShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkTwoPointConicalGradient.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkDashPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkComposeImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/docs/SkBitmap_Reference.bmh
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkDiscretePathEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkDropShadowImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkDropShadowImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkMatrix.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/utils/SkShadowUtils.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tools/bookmaker/parserCommon.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkLumaColorFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkLocalMatrixImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkLightingImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkColorFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkImageSource.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/gm/imagefiltersbase.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/Sk2DPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkBlitter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkTrimPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkDrawLooper.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkDiscretePathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/docs/SkPaint_Reference.bmh
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkBlurImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkOffsetImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkToSRGBColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkColorFilterShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkComposeImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/SkPaint_Reference.md
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkGradientShaderPriv.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkDisplacementMapEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkDashImpl.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkMagnifierImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkSweepGradient.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/Sk1DPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkComposeShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkRadialGradient.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkShaderBase.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkLumaColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkPathEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkEmbossMaskFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkDraw_vertices.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkPaintImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/Sk2DPathEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkEmbossMaskFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tests/GrShapeTest.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkMatrixImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkColorMatrixFilterRowMajor255.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tools/bookmaker/bookmaker.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkMorphologyImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkMaskFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkMatrixImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkImageShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/catalog.htm
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkModeColorFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkSweepGradient.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkPerlinNoiseShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkTileImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkPictureImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkPaintImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkComposeShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkLocalMatrixShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkMatrixConvolutionImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/SkMatrix_Reference.md
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/site/user/api/SkBitmap_Reference.md
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/docs/SkImage_Reference.bmh
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkCornerPathEffect.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkRadialGradient.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkTableMaskFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkTrimPE.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tests/PDFPrimitivesTest.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkModeColorFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkHighContrastFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkMagnifierImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/gpu/GrTestUtils.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkLinearGradient.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tests/QuickRejectTest.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkMergeImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkLayerDrawLooper.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkBitmap.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkLocalMatrixImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkEmptyShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkColorFilterImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkPaint.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkLayerDrawLooper.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tests/CanvasTest.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkImageSource.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkColorShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/tests/ImageFilterTest.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkMatrix.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkGradientShader.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkMergeImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkMatrixConvolutionImageFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/core/SkColorMatrixFilterRowMajor255.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/image/SkImage.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/gradients/SkTwoPointConicalGradient.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/shaders/SkColorFilterShader.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/docs/undocumented.bmh
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/src/effects/SkColorMatrixFilter.cpp
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkToSRGBColorFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkPictureImageFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/core/SkMaskFilter.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkCornerPathEffect.h
[modify] https://crrev.com/27dddae3130c8a6cfaa845195b2fb95cc691dd26/include/effects/SkOverdrawColorFilter.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f

commit ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 09 17:18:41 2018

Roll src/third_party/skia 7a45dd1..5ebb90d (40 commits)

https://skia.googlesource.com/skia.git/+log/7a45dd1..5ebb90d


git log 7a45dd1..5ebb90d --date=short --no-merges --format='%ad %ae %s'
2018-06-09 senorblanco@chromium.org Revert "remove half float workaround in GrGLGpu::onReadPixels"
2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 mtklein@chromium.org remove unused parts of SkTypes.h
2018-06-08 egdaniel@google.com Fall back to bilerp if we are undable to do a copy for mips.
2018-06-08 egdaniel@google.com Reland "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c3907ef..f15f886 (6 commits)
2018-06-08 bsalomon@google.com Stop passing GrPrimitiveProcessor to GrMesh::sendToGpu.
2018-06-08 herb@google.com Glyph search of desperation
2018-06-08 egdaniel@google.com Revert "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 borenet@google.com [recipes] Make ct_skps use binaries from a build task
2018-06-08 brianosman@google.com Avoid degenerate matrices (that trigger asserts) in test code
2018-06-08 mtklein@chromium.org see if we can remove this hack
2018-06-08 caryclark@skia.org rebase
2018-06-08 khushalsagar@chromium.org fonts: Perform blob analysis at SkBaseDevice layer instead of canvas.
2018-06-08 mtklein@chromium.org remove unimportant bench
2018-06-08 csmartdalton@google.com Make the SkPathRef GenIDChangeListener ref counted
2018-06-08 bsalomon@google.com Remove include of GrGLProgramBuilder.h from GrGLProgram.h and GrVkPipelineState.h
2018-06-08 csmartdalton@google.com Add a front() accessor to GrAllocator
2018-06-08 herb@google.com New more efficient run builder
2018-06-08 brucewang@google.com Add SkTypeface::makeClone.
2018-06-08 bsalomon@google.com remove half float workaround in GrGLGpu::onReadPixels
2018-06-08 brianosman@google.com Fix A2B JPEG images on GPU backed xform or color-managed canvas
2018-06-08 bungeman@google.com Add text size override to Viewer.
2018-06-08 csmartdalton@google.com Implement Sk2f::floor
2018-06-08 mtklein@chromium.org remove linear blending from SkWebpCodec
2018-06-08 senorblanco@chromium.org GrTessellator: catch missing intersections.
2018-06-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 fmalita@chromium.org SkJson
2018-06-08 enne@chromium.org Fix SkImageInfo::computeByteSize underflow
2018-06-08 egdaniel@google.com Reland "Require mips to be allocated at texture creation time and disable late allocations."
2018-06-08 bsalomon@google.com Revert "Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp""
2018-06-08 caryclark@skia.org update SkColor
2018-06-08 caryclark@skia.org fix define comments
2018-06-08 mtklein@chromium.org remove final SkTypes dependencies in SkArenaAlloc
2018-06-08 benjaminwagner@google.com Remove Win2k8 GPU jobs.
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81970bc..c3907ef (2 commits)
2018-06-08 timliang@google.com fixed vec3 size differences and mod calculation of skslc msl backend
2018-06-08 brianosman@google.com srgb config is gone. Stop testing it.
2018-06-08 borenet@google.com Update gen_tasks.go to use unforked glog
2018-06-08 robertphillips@google.com Add a factory to any GrOp-derived class that lacked one


Created with:
  gclient setdep -r src/third_party/skia@5ebb90d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:830651 , chromium:829622 , chromium:843135 ,chromium: 819616
TBR=halcanary@chromium.org

Change-Id: If58892b6b6b2061e1b52168911b4fb49a1b990e7
Reviewed-on: https://chromium-review.googlesource.com/1094454
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565887}
[modify] https://crrev.com/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f/DEPS

Comment 16 by caryclark@google.com, Jun 11 2018

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment