TextRunTest, IndexOfSubRun fails under tsan |
|||||
Issue descriptionhttps://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/283782 RUN ] TextRunTest.IndexOfSubRun ../../third_party/WebKit/Source/platform/text/TextRunTest.cpp:18: Failure Expected equality of these values: kNotSubRun Which is: 4294967295 run.IndexOfSubRun(TextRun(String("1"))) Which is: 0 [ FAILED ] TextRunTest.IndexOfSubRun (1 ms)
,
Apr 13 2018
,
Apr 14 2018
,
May 8 2018
kojii: ping?
,
May 8 2018
Sorry for the delay.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346266d30ddc7db0e687eab1bd0e84070369cb9f commit 346266d30ddc7db0e687eab1bd0e84070369cb9f Author: Koji Ishii <kojii@chromium.org> Date: Tue May 08 18:12:12 2018 Fix TextRunTest.IndexOfSubRun under TSAN It looks like only under TSAN, String("1") and String("1234567890") share the memory address, but the test assumes they are at the different memory. This patch fixes by using the string literal address directly. Bug: 830648 Change-Id: I804f44e301d3a8f5e13da9acd985e33103cae8a5 Reviewed-on: https://chromium-review.googlesource.com/1050047 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#556879} [modify] https://crrev.com/346266d30ddc7db0e687eab1bd0e84070369cb9f/third_party/blink/renderer/platform/text/text_run_test.cc
,
May 8 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 10 2018