New issue
Advanced search Search tips

Issue 830648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

TextRunTest, IndexOfSubRun fails under tsan

Project Member Reported by thakis@chromium.org, Apr 9 2018

Issue description

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/283782

 RUN      ] TextRunTest.IndexOfSubRun
../../third_party/WebKit/Source/platform/text/TextRunTest.cpp:18: Failure
Expected equality of these values:
  kNotSubRun
    Which is: 4294967295
  run.IndexOfSubRun(TextRun(String("1")))
    Which is: 0
[  FAILED  ] TextRunTest.IndexOfSubRun (1 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8fc38f72151224ad8cc4582cda864a7721560bc

commit a8fc38f72151224ad8cc4582cda864a7721560bc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Apr 10 02:20:11 2018

Remove msan, tsan test lists and just use asan test lists on all memory bots.

For example, angle_unittests wasn't running on the MSan bot, which wasn't
intentional.  If a test really doesn't work under e.g. TSan, it can
be added to the exceptions file instead.

For another example, https://chromium-review.googlesource.com/#/c/981787/
added cronet tests, but again not to msan.

Disable a few tests that don't pass on tsan or msan.

Bug:  830659 , 830648 ,830653, 830819 ,830944, 830945 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icac81720f32c24497942b9c056c6d6999a866ec6
Reviewed-on: https://chromium-review.googlesource.com/987477
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549382}
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/chromeos/dbus/cras_audio_client_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/third_party/blink/renderer/platform/text/text_run_test.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_context_glx_unittest.cc
[modify] https://crrev.com/a8fc38f72151224ad8cc4582cda864a7721560bc/ui/gl/gl_image_shared_memory_unittest.cc

Comment 2 by rsesek@chromium.org, Apr 13 2018

Status: Assigned (was: Unconfirmed)

Comment 3 by thakis@chromium.org, Apr 14 2018

Labels: -OS-Mac OS-Linux
kojii: ping?

Comment 5 by kojii@chromium.org, May 8 2018

Status: Started (was: Assigned)
Sorry for the delay.
Project Member

Comment 6 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/346266d30ddc7db0e687eab1bd0e84070369cb9f

commit 346266d30ddc7db0e687eab1bd0e84070369cb9f
Author: Koji Ishii <kojii@chromium.org>
Date: Tue May 08 18:12:12 2018

Fix TextRunTest.IndexOfSubRun under TSAN

It looks like only under TSAN, String("1") and String("1234567890")
share the memory address, but the test assumes they are at the
different memory.

This patch fixes by using the string literal address directly.

Bug:  830648 
Change-Id: I804f44e301d3a8f5e13da9acd985e33103cae8a5
Reviewed-on: https://chromium-review.googlesource.com/1050047
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556879}
[modify] https://crrev.com/346266d30ddc7db0e687eab1bd0e84070369cb9f/third_party/blink/renderer/platform/text/text_run_test.cc

Comment 7 by kojii@chromium.org, May 8 2018

Status: Fixed (was: Started)

Sign in to add a comment