New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830592 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

transitions should work correctly, even if animation frames were skipped

Project Member Reported by vollick@chromium.org, Apr 9 2018

Issue description

The problem is that transitions enqueue an animation from the current value to the target value, but the current value may be stale if the element's animation update was skipped due to an animation. Instead, it should ensure that the current value is fresh per pending animations and then start the transition.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a5665becb7cce9c10461631036bc847d76db45

commit 18a5665becb7cce9c10461631036bc847d76db45
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Apr 16 18:05:31 2018

[vr] Ensure unticked transitions complete

If a transition was enqueued but not serviced and, much later, another
transition is enqueued, it should transition from the final value of
the earlier transition.

Bug:  832650 , 830592 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2
Reviewed-on: https://chromium-review.googlesource.com/1014008
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551035}
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation_unittest.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/ui_scene_creator.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a5665becb7cce9c10461631036bc847d76db45

commit 18a5665becb7cce9c10461631036bc847d76db45
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Apr 16 18:05:31 2018

[vr] Ensure unticked transitions complete

If a transition was enqueued but not serviced and, much later, another
transition is enqueued, it should transition from the final value of
the earlier transition.

Bug:  832650 , 830592 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2
Reviewed-on: https://chromium-review.googlesource.com/1014008
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551035}
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/animation_unittest.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/18a5665becb7cce9c10461631036bc847d76db45/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Assigned)
Labels: M-68 Test-Complete

Sign in to add a comment