When the popup menu is presented, the button on which it is attached should be in the selected mode, and the other buttons should be dimmed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2 commit d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Apr 13 17:18:14 2018 Update the UI to spotlight the popup menu's anchor This CL adds a UI updater for the popup menu. This updater is in charge of spotlighting the button acting as an anchor for the popup menu and dimming all the other controls of the toolbar, reducing their alpha. This new UI updater replace the TabHistoryUIUpdater as the TabHistory is replaced by the popup menu. Bug: 830552 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5dd7391d184c5177ffa3fb1fb5c2479098acb615 Reviewed-on: https://chromium-review.googlesource.com/1010348 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550662} [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [add] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/public/BUILD.gn [add] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_updating.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinatee.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_tints.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_tints.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h [modify] https://crrev.com/d0f73d2c8cb4154e0158d7bc42f3d70a3e0f8ed2/ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h
Issue verified Version: Chrome Canary 68.0.3398.0 Device: iPhone 8 iOS: 11.2.6 When the popup menu is presented, the button on which it is attached is into selected mode, and the other buttons are dimmed. https://drive.google.com/open?id=1h6mS32tqFrINsZnCR0NohemWqBssDCPo https://drive.google.com/open?id=1iV-dHfB3ZFG8f4LzQUZb4rIGqKPsUFub
The NextAction date has arrived: 2018-04-25
Comment 1 by gambard@chromium.org
, Apr 9 2018