Issue metadata
Sign in to add a comment
|
Regression: Unable to save any field i.e, 'SAVE' button is seen disabled while editing a printer |
||||||||||||||||||||||
Issue descriptionChrome Version:67.0.3390.0/10559.0.0 dev channel Daisy,Kip,Reks OS:Chrome OS What steps will reproduce the problem? (1)Launch chrome,go to chrome://settings/cupsPrinters page ->Add a Printer (2)From more actions.. Edit the added printer >>click on Browse button and attach a sample screenshot which is invalid type. (3)Now edit the data at Name field/ Address field and observe 'SAVE' button is seen disabled Actual:Unable to save any field data i.e,'SAVE' button is seen disabled when we edit Name field/Address field with a invalid file attachment Expected:Instead, at least the remaining fields such as Name field/Address field should be seen saved This is a Regression issue as same is working fine in 67.0.3390.0/10550.0.0 dev Note:Issue is not seen in Linux,Windows OS @xdai: Please confirm the behavior. Attached the screencast for reference..
,
Apr 10 2018
So do you recommend that we leave the save button enabled as long as one of the entered values is valid?
,
Apr 10 2018
Oops. Sorry. I thought the attached expected video is the actual video. Then I think the current behavior is correct.
,
Apr 12 2018
If the current behavior is okay I'll mark this as "WontFix" for now. If you would like me to change this in the future please let me know.
,
Apr 13 2018
Re: C #4 > Expected: I recommend that leave the save button enabled as long as one of the entered values is valid. In the actual video,the file type is invalid but if the other fields like 'Name or Address' are valid SAVE button is seen disabled instead it should be seen enabled. Reopening the issue for confirmation. Thanks..
,
Apr 19 2018
Since the PPD error is displayed prominently, we can leave the SAVE button enabled. It should be clear that the PPD was rejected and won't be saved.
,
Apr 19 2018
,
Apr 25 2018
,
May 1 2018
,
May 11 2018
Agree with the decision to leave button enabled. 1. Since we start with displaying the button as enabled, disabling it later can be confusing and one has to figure out which form entry disabled it. 2. We highlight the error immediately/prominently and this serves the purpose of letting the user know they cannot proceed without fixing this error.
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64f3e627e4ee851d65f3f66b97ebc8e671048cdf commit 64f3e627e4ee851d65f3f66b97ebc8e671048cdf Author: David Valleau <valleau@chromium.org> Date: Sat May 12 01:56:05 2018 Change SAVE button in edit printer dialog to always be enabled Previously, when a user provided an invalid PPD file the 'SAVE' button in the edit printer dialog would be disabled. This would prevent users from editing other fields in the dialog and saving the changes unless the closed the dialog and reopened it again. Since there is already an error message surfaced to the user indicating that the PPD they provided is invalid, it should be okay to leave the button enabled. BUG= chromium:830527 R=skau@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iec26a0c9473ce920f3337521ecaebfb8a2ffe5fe Reviewed-on: https://chromium-review.googlesource.com/1028005 Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#558093} [modify] https://crrev.com/64f3e627e4ee851d65f3f66b97ebc8e671048cdf/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
,
May 17 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by x...@chromium.org
, Apr 10 2018Owner: valleau@chromium.org