Issue metadata
Sign in to add a comment
|
6.1% regression in memory.desktop at 548372:548430 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 9 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1393abccc40000
,
Apr 9 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1393abccc40000 Update Windows order files by hans@chromium.org https://chromium.googlesource.com/chromium/src/+/8a45d2a9c56fd9a9de3bbdf188f1a3ed1f9c65b3 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 9 2018
This doesn't make sense.. it seems the graph just reset to about the level it was a few days before. How reliable is this metric? For example, the perf report for my change (https://chromeperf.appspot.com/group_report?rev=548389) indicates it reduced memory usage of media.desktop for another benchmark by 50%. On Mac :-p Seems flaky to me.
,
Apr 9 2018
https://cs.chromium.org/chromium/src/tools/perf/benchmark.csv?type=cs&q=memory.desktop&sq=package:chromium&l=34 suggests memory.desktop is owned by erikchen. erikchen, is that metric known to be super flaky? Is there a bug for that? (See previous comment)
,
Apr 9 2018
The chart linked in this regression is for "memory:chrome:all_processes:reported_by_chrome:v8:effective_size". I personally don't think we should alert on this because it's flaky, see the bug I filed: https://bugs.chromium.org/p/chromium/issues/detail?id=736506 The v8 team requested that we keep this alert: https://bugs.chromium.org/p/chromium/issues/detail?id=736506#c8
,
Apr 9 2018
The V8 metric in the linked graph https://chromeperf.appspot.com/group_report?bug_id=830517 varies by +/-200KB on 8MB (i.e. about 3%). I have a pending change that considerably reduces then noise of V8 memory metrics: https://chromium-review.googlesource.com/c/catapult/+/983775 The metric in comment #4 that changed by 50% is the compositor memory metric (memory:chrome:all_processes:reported_by_chrome:cc), which is unrelated to V8 metric. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 9 2018