New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 830505 link

Starred by 1 user
Status: Fixed
Owner:
horo@chromium.org
Closed: Jun 2018
Cc:
kinuko@chromium.org
kouhei@chromium.org
ksakamoto@chromium.org
█ kenjibaheux@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 830506
Blocking:
issue 803774



Sign in to add a comment

Provide a way to debug SignedHTTPExchange errors

Project Member Reported by horo@chromium.org, Apr 9 2018 
Currently it is difficult to debug the SignedHTTPExchange related loading errors.

We have TRACE_EVENTs in SignedHTTPExchange related codes.
So we can check the behavior using chrome://tracing.
But it is not Web developer friendly.
DevTools should provide a way to debug the SignedHTTPExchange related error.
And also it would be very useful if Web developer can check the content of CBOR envelope using DevTools.

Screenshots are in this document: https://bit.ly/2HXVbCU

Comment 1 by horo@chromium.org, Apr 9 2018

Blocking: 803774

Comment 2 by horo@chromium.org, Apr 9 2018

Blockedon: 830506

Comment 3 by horo@chromium.org, Apr 11 2018 

I'm creating a CL to show SignedHTTPExchange related errors in DevTool's console.
https://crrev.com/c/1004880
See the attached screenshot.
signed-exchange-error-in-devtools.png
20.3 KB View Download

Comment 4 by horo@chromium.org, Apr 11 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdbb490d6ab316cee3e7516c74d82e58417d6bc5

commit cdbb490d6ab316cee3e7516c74d82e58417d6bc5
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Apr 12 06:09:14 2018

Show SignedHTTPExchange related errors in DevTool's console

After this CL, SignedHTTPExchange related errors will be shown in DevTool's console.
Screenshot:  crbug.com/830505#c3 

Bug:  830505 
Change-Id: Icfc184d98ca2bb1f83e378c596b8b73f4da8a1b6
Reviewed-on: https://chromium-review.googlesource.com/1004880
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550040}
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/BUILD.gn
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/loader/prefetch_url_loader.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/loader/prefetch_url_loader_service.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_cert_fetcher.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_cert_fetcher_factory.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_cert_fetcher_factory.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header_parser.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header_parser.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header_parser_unittest.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_header_unittest.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_signature_verifier.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[add] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_utils.cc
[add] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/signed_exchange_utils.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_loader.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_prefetch_handler.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_request_handler.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/browser/web_package/web_package_request_handler.h
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/test/fuzzer/signed_exchange_header_fuzzer.cc
[modify] https://crrev.com/cdbb490d6ab316cee3e7516c74d82e58417d6bc5/content/test/fuzzer/signed_exchange_header_parser_fuzzer.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5168f11924d56c9628b781254a021bb6a207a377

commit 5168f11924d56c9628b781254a021bb6a207a377
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Apr 24 23:07:33 2018

Fix wrong TRACE_EVENT_END0()'s name

Bug:  830505 
Change-Id: I4c7a6333fc6ac16a53a619700f59838e81f74411
Reviewed-on: https://chromium-review.googlesource.com/1025930
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553339}
[modify] https://crrev.com/5168f11924d56c9628b781254a021bb6a207a377/content/browser/web_package/signed_exchange_handler.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4801e768a9e54248eeb68b019bd9beb65f465241

commit 4801e768a9e54248eeb68b019bd9beb65f465241
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Apr 25 07:36:57 2018

Introduce SignedExchangeDevToolsProxy

SignedExchangeDevToolsProxy lives on the IO thread and sends messages to
DevTools via the UI thread to show signed exchange related information.
Currently it is used only to send error messages.

When Network Service is not enabled, the frame tree node ID is not available
while handling prefetch requests on the IO thread. So this CL introduces
|frame_tree_node_id_getter| callback.
For non-NetworkService prefetch requests, the callback is GetFrameTreeNodeId()
in resource_message_filter.cc. For other cases (non-NetworkService navigation
requests, NetworkService navigation requests, NetworkService prefetch requests)
the callback is the lambda which just returns frame_tree_node_id.

Bug:  830505 
Change-Id: I22777225b8b678f406fc35dacf963b935236c0ab
Reviewed-on: https://chromium-review.googlesource.com/1025492
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553478}
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/BUILD.gn
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/loader/prefetch_url_loader.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/loader/prefetch_url_loader_service.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/loader/prefetch_url_loader_service.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_cert_fetcher.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_cert_fetcher_factory.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_cert_fetcher_factory.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[add] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_devtools_proxy.cc
[add] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_devtools_proxy.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header_parser.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header_parser.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header_parser_unittest.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_header_unittest.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_signature_verifier.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/signed_exchange_utils.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/web_package_loader.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/web_package_prefetch_handler.h
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/browser/web_package/web_package_request_handler.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/test/fuzzer/signed_exchange_header_fuzzer.cc
[modify] https://crrev.com/4801e768a9e54248eeb68b019bd9beb65f465241/content/test/fuzzer/signed_exchange_header_parser_fuzzer.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3317f6dd3326dc49f29e2920483925b7e979e329

commit 3317f6dd3326dc49f29e2920483925b7e979e329
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Apr 26 03:23:46 2018

Add SignedExchange related DevTools layout tests

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

This CL adds LayoutTests and -expected.txt files to track the progress
of the implementation.

Currently there are some difference from the ideal behavior:
- The status code of the succeeded .htxg should be 200. Currenly it is
  302 which is the status code of internally generated redirect
  response.
- The status code of the invalid .htxg should be 200. Currenly it is 0
  because the actual response is not sent to DevTools. DevTools just
  recieves "loadingFailed" event.
- The request to the certificate file shold be displayed. Currenly
  DevTools doesn't recieve the certificate request which is sent from
  the browser process.
- There is no signed exchange related information in the network log.

Bug:  830505 
Change-Id: I80c4c648c466505fef4f729eb046a91ede4a4660
Reviewed-on: https://chromium-review.googlesource.com/1027574
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553882}
[modify] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired.js
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation.js
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired.js
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch.js
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/virtual/htxg-with-network-service/http/tests/devtools/htxg/README.txt
[add] https://crrev.com/3317f6dd3326dc49f29e2920483925b7e979e329/third_party/WebKit/LayoutTests/virtual/htxg/http/tests/devtools/htxg/README.txt
Project Member

Comment 9 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b51f112e484bf2d353ff1bc49d20d772a1c64b

commit 32b51f112e484bf2d353ff1bc49d20d772a1c64b
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed May 09 17:58:46 2018

Send the outer response of SignedExchange to DevTools

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

This CL introduces a new DevTools event “signedExchangeReceived".
SignedExchange related information (SignedExchangeInfo) will be sent to
DevTools in this event.
SignedExchangeInfo will contain:
- The outer response not to show the internally generated redirect response.
- The signed exchange header information.
- The certificate information.
- The error messages if error occured.
This CL only introduces SignedExchangeInfo.outerResponse.

When the signed exchange request is a navigation request,
|devtools_navigation_token| can be used to find the matching request in
SDK.NetworkManager.
But when the signed exchange request is a prefetch request, the browser process
doesn't know the request id used in DevTools. So SDK.NetworkManager uses
|_inflightRequestsByURL| to find the matching request.

For navigation case, |devtools_navigation_token|, |url| and |report_raw_headers|
flags are passed from NavigationRequest through NavigationRequestInfo,
WebPackageRequestHandler, WebPackageLoader, SignedExchangeDevToolsProxy,
RenderFrameDevToolsAgentHost, NetworkHandler to SDK.NetworkManager in DevTools.
For prefetch case |url| and |report_raw_headers| are passed from
PrefetchURLLoader through WebPackagePrefetchHandler and WebPackageLoader.

Bug:  830505 
Change-Id: I186debe50c283b1cdfb9ae268a06fea143edcc6d
Reviewed-on: https://chromium-review.googlesource.com/1027554
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557238}
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/frame_host/navigation_request_info.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/frame_host/navigation_request_info.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/navigation_url_loader_impl_unittest.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/prefetch_url_loader.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/signed_exchange_devtools_proxy.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_loader.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_prefetch_handler.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_request_handler.cc
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/content/browser/web_package/web_package_request_handler.h
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/blink/renderer/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/32b51f112e484bf2d353ff1bc49d20d772a1c64b/third_party/blink/renderer/devtools/front_end/sdk/NetworkRequest.js
Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e483c9aed639f11151c44ecc1d496c1fde36ee

commit 05e483c9aed639f11151c44ecc1d496c1fde36ee
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 10 01:59:40 2018

Introduce a new DevTools resource type for Signed Exchange.

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

After this CL, the Type column in network tab will be "signed-exchange"
for signed exchange responses.

This CL depends on https://crrev.com/c/1027554

Bug:  830505 
Change-Id: I2d7bb005dc24377e105e64e7b7ac439eaea2e88b
Reviewed-on: https://chromium-review.googlesource.com/1029750
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557419}
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired.js
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation.js
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired.js
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch.js
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-toggle-type-filter-expected.txt
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/blink/renderer/core/inspector/inspector_page_agent.h
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/blink/renderer/devtools/front_end/common/ResourceType.js
[modify] https://crrev.com/05e483c9aed639f11151c44ecc1d496c1fde36ee/third_party/blink/renderer/devtools/front_end/sdk/NetworkManager.js
Project Member

Comment 11 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb

commit bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 10 02:26:49 2018

Show the certificate request of signed exchange in DevTools.

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

After this CL, the certificate request of signed exchange is displayed.

This CL depends on https://crrev.com/c/1029750

Bug:  830505 
Change-Id: Ia431b5bb889fa5f89754f11eb2e54dbf91d0e4fe
Reviewed-on: https://chromium-review.googlesource.com/1029755
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557431}
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/web_package/signed_exchange_cert_fetcher.h
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/content/browser/web_package/signed_exchange_devtools_proxy.h
[add] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found-expected.txt
[add] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found.js
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[add] https://crrev.com/bb82ff6a3bb004b1c8e94410a4bcc1bfc1c67ecb/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.htxg

Comment 12 by horo@chromium.org, May 10 2018

Description: Show this description
Project Member

Comment 13 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1

commit 705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 17 00:36:11 2018

Show SignedExchange related information in DevTool's Preview panel

SignedExchangeDevToolsProxy sends the SignedExchangeHeader and the certificate
information and the error messages to DevTools.
When the user clicks a signed exchange response in Network panel, these
information will be displayed in the Preview panel.

And the network grid view will show “from SignedExchange” in the size column of
the content of the signed exchange like “from disk cache”.

See the doc for more details: https://bit.ly/2HXVbCU

This CL depends on https://crrev.com/c/1029755

Bug:  830505 
Change-Id: Ice3743f2e1675b6d604eeaba731ebd8494c2b5a1
Reviewed-on: https://chromium-review.googlesource.com/1004890
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559363}
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/web_package/signed_exchange_devtools_proxy.h
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found-expected.txt
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/NetworkItemView.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/RequestPreviewView.js
[add] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/module.json
[add] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/signedExchangeInfoTree.css
[add] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network/signedExchangeInfoView.css
[modify] https://crrev.com/705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1/third_party/blink/renderer/devtools/front_end/network_test_runner/NetworkTestRunner.js

Comment 14 by horo@chromium.org, May 18 2018 

705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1 landed in 68.0.3434.0.
So now we can see the information of signed exchange in DevTools.
signed-exchange-68.0.3434.0.mov
9.5 MB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ac04d63b06db0e81a986691346f67ba8ad7f865

commit 4ac04d63b06db0e81a986691346f67ba8ad7f865
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon May 21 17:01:18 2018

Brush up DevTools SignedExchange support

This incorporats with dgozman's comments in crrev.com/c/1004890
- Change "from SignedExchange" to "from signed-exchange" in NetworkRequestNode.
- Show the signed exchagne url as the initiator of certificate request.
- Show "from signed-exchange" in the headers tab of the inner request.
- Add "View request" link in the preview tab of signed exchange to show the inner request.
- Add "Learn more" link in the preview tab of signed exchange.

Bug:  830505 
Change-Id: Ica7ae52e563efb283c600c812be196951a12a336
Reviewed-on: https://chromium-review.googlesource.com/1065558
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560287}
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/browser_sdk/NetworkLog.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/network/RequestHeadersView.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/network/RequestPreviewView.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/network/signedExchangeInfoTree.css
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/4ac04d63b06db0e81a986691346f67ba8ad7f865/third_party/blink/renderer/devtools/front_end/sdk/NetworkRequest.js
Project Member

Comment 16 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6449e2279bab53228fe6ece3941a8ed7e064a27e

commit 6449e2279bab53228fe6ece3941a8ed7e064a27e
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed May 23 04:00:32 2018

Use net::ErrorToShortString() in SignedExchangeHandler::OnCertVerifyComplete()

Currently when faild to verify the certificate while loading signed exchanges,
only the error number is shown in DevTools.
To show the error string (example: ERR_CERT_DATE_INVALID), this CL uses
net::ErrorToShortString().

Bug:  830505 
Change-Id: Ic93c6c9f532c67ca2ab0bfe6fbd32f0fb2359893
Reviewed-on: https://chromium-review.googlesource.com/1068950
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560927}
[modify] https://crrev.com/6449e2279bab53228fe6ece3941a8ed7e064a27e/content/browser/web_package/signed_exchange_handler.cc
Project Member

Comment 17 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ce890a5c52e7765a6e3d715c40e30974f145bf

commit 15ce890a5c52e7765a6e3d715c40e30974f145bf
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 24 09:08:22 2018

Introduce net::ERR_INVALID_SIGNED_EXCHANGE

When Chrome fails to load a signed exchange, the error page shows ERR_FAILED.
It is difficult to know the failed reason.
After this CL, the error page shows ERR_INVALID_SIGNED_EXCHANGE.

> This site can’t be reached
> The webpage at https://example.com/example.sxg might be temporarily down or it may
> have moved permanently to a new web address.
> ERR_INVALID_SIGNED_EXCHANGE

Bug:  830505 
Change-Id: Ifcc60a9a353b4f3c29711bc27fb94322761dbdfb
Reviewed-on: https://chromium-review.googlesource.com/1065396
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561434}
[modify] https://crrev.com/15ce890a5c52e7765a6e3d715c40e30974f145bf/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/15ce890a5c52e7765a6e3d715c40e30974f145bf/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/15ce890a5c52e7765a6e3d715c40e30974f145bf/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/15ce890a5c52e7765a6e3d715c40e30974f145bf/net/base/net_error_list.h
Project Member

Comment 18 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645

commit 4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri May 25 03:54:16 2018

Add a link to view certificate in DevTool's SignedExchangeInfoView.

It is useful when debugging the certificate especially when failed to
load the signed exchange.
(When succeeded, we can view the certificate in Security panel)

This CL also changes "certUrl" to optional in PDL file, because this
could be null according to the spec.

Bug:  830505 
Change-Id: I710d91bc43bd414d03aca7d4e3dfdb9342b10500
Reviewed-on: https://chromium-review.googlesource.com/1055407
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561758}
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/web_package/signed_exchange_devtools_proxy.h
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/4defbb6af0fda52f8a5ccc32ad5eb03cb31ce645/third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
Project Member

Comment 19 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/093fa71d6166125445c508f1782d32dd5719b3ef

commit 093fa71d6166125445c508f1782d32dd5719b3ef
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri May 25 03:59:58 2018

Shows the signature and CertSHA256 of signed exchange in DevTools

The signature header was removed from the response headers in the spec.
https://github.com/WICG/webpackage/commit/f4ca17d1377bed966fdba85c03adbd798cfb5a96
(Chromium implementation is not updated yet.)
So we should show the all "signature" information.

Bug:  830505 
Change-Id: I1e922806e2febedb66c3f4e1614d5277a6012e3d
Reviewed-on: https://chromium-review.googlesource.com/1069948
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561761}
[modify] https://crrev.com/093fa71d6166125445c508f1782d32dd5719b3ef/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/093fa71d6166125445c508f1782d32dd5719b3ef/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/093fa71d6166125445c508f1782d32dd5719b3ef/third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
[modify] https://crrev.com/093fa71d6166125445c508f1782d32dd5719b3ef/third_party/blink/renderer/devtools/front_end/network/signedExchangeInfoTree.css

Comment 20 by horo@chromium.org, May 30 2018 

I'm creating a CL to highlight the error related field when failed to load signed exchange.

https://chromium-review.googlesource.com/c/chromium/src/+/1074910
cha256_error.png
237 KB View Download
timestamp_error.png
234 KB View Download
Project Member

Comment 21 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40c7c3bf6c79421eef544a54e180ea53655da00

commit b40c7c3bf6c79421eef544a54e180ea53655da00
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 31 07:32:45 2018

Highlight the error related field in DevTool's SignedExchangeInfoView

Screenshots:  http://crbug.com/830505#c20 

Bug:  830505 
Change-Id: I91d08b747bacf6781b8088e800605b51a73e34f0
Reviewed-on: https://chromium-review.googlesource.com/1074910
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563178}
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/BUILD.gn
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_devtools_proxy.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_devtools_proxy.h
[add] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_error.cc
[add] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_error.h
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/signed_exchange_utils.h
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found-expected.txt
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/blink/renderer/devtools/front_end/network/signedExchangeInfoTree.css
[modify] https://crrev.com/b40c7c3bf6c79421eef544a54e180ea53655da00/third_party/blink/renderer/devtools/front_end/network_test_runner/NetworkTestRunner.js
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6361cb09afb2d46deb532e850bf7340f9f591dae

commit 6361cb09afb2d46deb532e850bf7340f9f591dae
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon Jun 04 04:36:02 2018

Stop using TRACE_EVENT_BEGIN/END for logging signed exchange errors

Bug:  830505 
Change-Id: I9e1084ad1647f898933f40dfdb536cffdc371a46
Reviewed-on: https://chromium-review.googlesource.com/1080493
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563997}
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_certificate_chain.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_prologue.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/6361cb09afb2d46deb532e850bf7340f9f591dae/content/browser/web_package/signed_exchange_utils.h

Comment 23 by horo@chromium.org, Jun 5 2018

Status: Fixed (was: Started)
Now we can debug the SignedHTTPExchange errors in DevTools Preview tab.
So I want to mark this issue "fixed".

Comment 24 by kinuko@chromium.org, Jun 5 2018 

\o/
►

Sign in to add a comment