URL is not reset when reloading the current page (via link or load)
Reported by
eranna.d...@gmail.com,
Apr 9 2018
|
|||||||||||
Issue descriptionTHIS TEMPLATE IS FOR FILING BUGS ON THE ANDROID SYSTEM WEBVIEW. GENERAL WEB BUGS SHOULD BE FILED USING A DIFFERENT TEMPLATE! Device name: Windows 7(64bit) Android version: WebView version (from system settings -> Apps -> Android System WebView): Application:Google Chrome Application version:google Chrome Version 65.0.3325.181 (Official Build) (64-bit) URLs (if applicable): Steps to reproduce: (1)Open any the website in the google chrome. (2)Now click on the logo of that Webpage now it will loads Welcome page of that Particular website (3)now clear the web url in the search engine box. (4)now again click on the same logo,chrome will reloads the page but it will not show the URL of that page Expected result: When click on the same url in page it should show the URL in the Search Engine bar Actual result: When click on the same url in page it should show the URL in the Search Engine bar,but it is empty. This is faced when i was testing my web page, User will some time cut the url (or)clear the URL and click on the same link.It will not show the URL then User will get confused and it feel as bug in his page. Example attached to this Bug Please find the attachment Regards, Eranna.D
,
Apr 9 2018
This is not for the android issue
,
Apr 9 2018
,
Apr 9 2018
,
Apr 10 2018
Thanks for filing the issue! Able to reproduce the issue on reported chrome version 65.0.3325.181 and on the latest canary 67.0.3390.0 using Windows 10, ubuntu 14.04 and Mac 10.13.1. As the issue is seen from M60(60.0.3112.0) considering it as Non-Regression and marking it as Untriaged.
,
Apr 10 2018
,
Apr 10 2018
Is there any reward for this bug??
,
Apr 10 2018
I think this is working as intended. If the user started editing text within the URL bar at the top of the page (even if it's simply clearing the text there), then we only want to revert the edits and display something if we have something new to display. Doing something that causes a reload doesn't cause meet that threshold. CC pkasting to make sure have this right, and jdonnelly for learning
,
Apr 16 2018
We're supposed to allow resetting the URL when the omnibox does not have focus. That seems to work correctly when the new URL is not identical to the old one, but when it is, I think the load is being treated as a reload, and it's not resetting the address bar. It probably should reset it even in that case. I think the existing behavior was intentional originally, but I suspect we made the wrong call.
,
Apr 17 2018
any way i need one clarification is it bug r not from ur prospective?? because in the comment 8 mpear said it is working as intended now ur saying that u have made a wrong call that's y i am in little bit confused. is it bug from ur prospective??
,
Apr 17 2018
I agree with pkasting@: this is a bug. The current behavior was what was originally intended, but now that you've reported it and we've thought about it, we think the original intention was wrong. Marking as available.
,
Apr 18 2018
is there any reward for this bug??? i am expecting a reward for this bug. my bug is eligible for the reward?? asking for the reward is wrong thing means i am very sorry for that. Regards, Eranna.D
,
Apr 18 2018
The bug reward system is only for security bugs; this isn't a security bug (sorry!). If you find a security bug, please follow the instructions here: https://www.google.com/about/appsecurity/chrome-rewards/index.html which includes a link for and instructions about how to file a security bug in a way that would be eligible for a reward.
,
Jun 15 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7e58d9d308fc916d923b03d3fbc71677d10aeef commit b7e58d9d308fc916d923b03d3fbc71677d10aeef Author: manuk <manukh@chromium.org> Date: Wed Jun 20 14:19:55 2018 omnibox: reset display url when re-navigating to the current page by clicking a link Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. Bug: 830491 Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 Reviewed-on: https://chromium-review.googlesource.com/1103233 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#568831} [modify] https://crrev.com/b7e58d9d308fc916d923b03d3fbc71677d10aeef/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/b7e58d9d308fc916d923b03d3fbc71677d10aeef/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/b7e58d9d308fc916d923b03d3fbc71677d10aeef/components/omnibox/browser/omnibox_edit_model_unittest.cc
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/814464663e344580f3bb8c16a2a1f0766f75cba3 commit 814464663e344580f3bb8c16a2a1f0766f75cba3 Author: manuk hovanesian <manukh@chromium.org> Date: Mon Jun 25 20:43:37 2018 Revert "omnibox: reset display url when re-navigating to the current page by clicking a link" This reverts commit b7e58d9d308fc916d923b03d3fbc71677d10aeef. Reason for revert: Introduced regression issues relating to omnibox text being cleared. Original change's description: > omnibox: reset display url when re-navigating to the current page by clicking a link > > Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. > > Bug: 830491 > Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 > Reviewed-on: https://chromium-review.googlesource.com/1103233 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568831} TBR=tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830491 Change-Id: If20093795454513c9734fa2c8ed686843e83a683 Reviewed-on: https://chromium-review.googlesource.com/1113879 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570165} [modify] https://crrev.com/814464663e344580f3bb8c16a2a1f0766f75cba3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/814464663e344580f3bb8c16a2a1f0766f75cba3/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/814464663e344580f3bb8c16a2a1f0766f75cba3/components/omnibox/browser/omnibox_edit_model_unittest.cc
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0 commit cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0 Author: manuk <manukh@chromium.org> Date: Fri Jun 29 15:13:05 2018 omnibox: reset display url when re-navigating to the current page by clicking a link Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. Bug: 830491 Change-Id: I9819fa29ca1d86467a660e0e40ddb149cf210f1d Reviewed-on: https://chromium-review.googlesource.com/1114337 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571479} [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/browser.cc [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/browser_window.h [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/cocoa/browser_window_cocoa.h [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/browser/ui/views/toolbar/toolbar_view.h [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/test/base/test_browser_window.h [modify] https://crrev.com/cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0/chrome/test/data/links.html
,
Jul 3
Can we mark this Fixed or is there more to do here?
,
Jul 3
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eef81e15511bebf37bb099901722da18bc987f00 commit eef81e15511bebf37bb099901722da18bc987f00 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri Jul 13 20:07:47 2018 Revert "omnibox: reset display url when re-navigating to the current page by clicking a link" This reverts commit cf4c67a7aab6662ff4d886958c8b8c4ba8b41bb0. Reason for revert: I believe that this change is responsible for https://crbug.com/862196 ("Text in omnibox completely reset while typing"). Rather than try a speculative fix, I'm going to revert this and we can try to re-land post-branch with an associated fix. Original change's description: > omnibox: reset display url when re-navigating to the current page by clicking a link > > Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` > logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained > unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is > reset. > > Bug: 830491 > Change-Id: I9819fa29ca1d86467a660e0e40ddb149cf210f1d > Reviewed-on: https://chromium-review.googlesource.com/1114337 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571479} TBR=mpearson@chromium.org,thakis@chromium.org,tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830491 Change-Id: Ie9a30f656a0e0faabeaf690b865fa49e37e8bc7f Reviewed-on: https://chromium-review.googlesource.com/1134099 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575040} [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/browser.cc [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/browser_window.h [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/cocoa/browser_window_cocoa.h [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/browser/ui/views/toolbar/toolbar_view.h [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/test/base/test_browser_window.h [modify] https://crrev.com/eef81e15511bebf37bb099901722da18bc987f00/chrome/test/data/links.html
,
Jul 13
Post M69-branch, we'll need to re-fix this while making sure it doesn't result in the issue described at https://crbug.com/862196 .
,
Jul 17
Changing the underlying display URL without reverting the omnibox ought to Just Work, because if the omnibox doesn't currently have focus, I believe it will revert itself, and if it does have focus with edits in progress, you don't want to forcibly revert it.
,
Jul 17
re comment #22: The point of this bug request *is* to revert the omnibox (even if it has edits in progress) when the user clicks on a link.
,
Jul 17
That's WontFix in the limit because handling a link click is async, and may be async by an arbitrarily long time. If the user is busy interacting with the omnibox when the click finally results in a navigation, we should never revert what they're doing. That's why I said in comment 22 "if the omnibox doesn't currently have focus, I believe it will revert itself" -- if we don't do that today, that's probably an OK change (to allow reversion while not focused), but going further and reverting while the omnibox is focused should never happen.
,
Sep 10
,
Sep 10
Clarifying summary. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by eranna.d...@gmail.com
, Apr 9 2018