kUnthrottled -> Replace them with appropriate kInternal* task types kUnspecedTimer -> Replace them with appropriate kInternal* task types kUnspecedLoading -> Rename them to kInternalLoading
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a80bd3ea0c54c121ff6e8daa81be11b7a5e7826 commit 5a80bd3ea0c54c121ff6e8daa81be11b7a5e7826 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Apr 09 11:19:22 2018 Replace TaskType::kUnspecedTimer with kInternalMedia where media is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: I359671de2e2081338c6d838c193ecc3a8092490b Reviewed-on: https://chromium-review.googlesource.com/1002720 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549151} [modify] https://crrev.com/5a80bd3ea0c54c121ff6e8daa81be11b7a5e7826/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc [modify] https://crrev.com/5a80bd3ea0c54c121ff6e8daa81be11b7a5e7826/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3dd67deaaa0e3fb0477d4604f410f36c543ed46 commit c3dd67deaaa0e3fb0477d4604f410f36c543ed46 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Apr 09 12:12:12 2018 Rename kUnspecedLoading to kInternalLoading We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. As the first step, this CL renames kUnspecedLoading to kInternalLoading simply as the current kUnspecedLoading usages are related to loading. Bug: 830489 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I674ca3b5842502a376731de921629f6f79dcd225 Reviewed-on: https://chromium-review.googlesource.com/1002719 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549156} [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/content/renderer/manifest/manifest_change_notifier.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/css/css_font_face_src_value.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/css/remote_font_face_source.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/html/image_document.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/loader/navigation_scheduler.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/loader/worker_fetch_context.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/loader/worker_threadable_loader.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/svg/graphics/svg_image.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/main_thread_worklet_global_scope.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/parent_frame_task_runners.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/threaded_worklet_global_scope.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/core/workers/worklet.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler.cc [modify] https://crrev.com/c3dd67deaaa0e3fb0477d4604f410f36c543ed46/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096 commit 9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Apr 11 02:27:45 2018 Replace TaskType::kUnspecedTimer with kInternalUserInteraction where inputing is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. This CL also introduces a new TaskType kInternalUserInteraction for future usage. Bug: 830489 Change-Id: I5d2852c1e96c2955d1e2c2368da80d44cb57b846 Reviewed-on: https://chromium-review.googlesource.com/1005135 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549735} [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/renderer/core/input/event_handler.cc [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/9f2ecbccaffbb2fcc6b331d5c9a5b3e34a4ce096/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b988b22eff54ba689350162bf985040a4a8f971 commit 4b988b22eff54ba689350162bf985040a4a8f971 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Apr 12 07:29:22 2018 Replace TaskType::kUnspecedTimer/kUnthrottled with kInternalInspector where inspector is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. This CL also introduces a new TaskType kInternalInspector. Bug: 830489 Change-Id: I8cd432f0f65ac9cd5ae98fd4be69e4986a87053c Reviewed-on: https://chromium-review.googlesource.com/1005652 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550072} [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/inspector/InspectorOverlayAgent.cpp [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/workers/threaded_object_proxy_base.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/4b988b22eff54ba689350162bf985040a4a8f971/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10edbe72b6a7a00103c1448d58cefa39d0ed32c3 commit 10edbe72b6a7a00103c1448d58cefa39d0ed32c3 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Apr 12 08:08:29 2018 Replace TaskType::kUnspecedTimer with kInternalIPC where IPC is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: If0f260c6c7d4ec9f8ca476bc6731e54f1d7cb7d2 Reviewed-on: https://chromium-review.googlesource.com/1005642 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550093} [modify] https://crrev.com/10edbe72b6a7a00103c1448d58cefa39d0ed32c3/third_party/blink/renderer/core/mojo/mojo_watcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6 commit 77ad239d8b00ec11edcc82ecf11d3c03a962c1d6 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Apr 12 10:59:03 2018 Replace TaskType::kUnspecedTimer with kInternalAnimation where animation is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. This CL also introduced a new type kInternalAnimation. Bug: 830489 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia8be580c1f313c89c6928dbb201c0cb2ac435ed8 Reviewed-on: https://chromium-review.googlesource.com/1009448 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550140} [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/core/animation/document_timeline.h [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/core/editing/frame_caret.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/core/html/forms/spin_button_element.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/core/layout/layout_progress.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/core/svg/animation/smil_time_container.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/77ad239d8b00ec11edcc82ecf11d3c03a962c1d6/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4bde421505cd58d1ae6263c60882dbf4377812b commit d4bde421505cd58d1ae6263c60882dbf4377812b Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Apr 16 06:00:36 2018 Replace TaskType::kUnspecedTimer with kInternalAccessibility where accessibility is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Ib390ab3a726e1a825aa81d0c76e972f455c31ca4 Reviewed-on: https://chromium-review.googlesource.com/1013499 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550939} [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/d4bde421505cd58d1ae6263c60882dbf4377812b/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/279040a6fd76c5fb25e905b3c2a7ec82f582e562 commit 279040a6fd76c5fb25e905b3c2a7ec82f582e562 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Apr 16 06:02:05 2018 Replace TaskType::kUnspecedTimer with kInternalAnimation where animation is related This is a remaining task from https://chromium-review.googlesource.com/c/chromium/src/+/1009448 We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Iefa7d73db427177eab41481a396be7aa42fbf230 Reviewed-on: https://chromium-review.googlesource.com/1012042 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550940} [modify] https://crrev.com/279040a6fd76c5fb25e905b3c2a7ec82f582e562/third_party/blink/renderer/core/animation/pending_animations.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/335b449401c4d3cdc789925ed3910728713debf1 commit 335b449401c4d3cdc789925ed3910728713debf1 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Apr 17 23:08:11 2018 scheduler: Fix TaskTypeToString for kInternalAccessibility Bug: 830489 Change-Id: Ief2540485aa699a72ad9adccafa487a729e7fb08 Reviewed-on: https://chromium-review.googlesource.com/1015441 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551515} [modify] https://crrev.com/335b449401c4d3cdc789925ed3910728713debf1/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
As we have changed the direction how to treat kUnspecedTimer and kUnthrottled and defined the guideline, let's move on crbug.com/836410.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c27cd8a007aca697e21ba7845e8afb8bcbb3c7b commit 2c27cd8a007aca697e21ba7845e8afb8bcbb3c7b Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed May 09 13:17:23 2018 Replace TaskType::kUnthrottled with kInternalLoading where loading is related This changes a behavior slightly: the task runner is change from unthrottleable to throttleable. However, there should not be a strong reason why the task runner should be unthrottled there. We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 830489 Change-Id: I55519cb83aa40cbf4fd98bcd18a9424aa9a7b882 Reviewed-on: https://chromium-review.googlesource.com/1051308 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557165} [modify] https://crrev.com/2c27cd8a007aca697e21ba7845e8afb8bcbb3c7b/content/renderer/image_downloader/image_downloader_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4b5192aa8f23da95b959deff74ddd6ceef116f3 commit f4b5192aa8f23da95b959deff74ddd6ceef116f3 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu May 10 09:49:25 2018 Replace TaskType::kUnthrottled with kInternalWorker where worker is related We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 830489 Change-Id: I465769461f4db57031e49c391f0efe715e2dc067 Reviewed-on: https://chromium-review.googlesource.com/1046730 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557484} [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/public/platform/task_type.h [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/core/workers/worker_event_queue.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/f4b5192aa8f23da95b959deff74ddd6ceef116f3/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Apr 9 2018