New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830339 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary separator line is seen below App info on the context menu of any app

Project Member Reported by kebalaji@chromium.org, Apr 9 2018

Issue description

Chrome Version:  67.0.3390.0/10559.0.0 dev channel Daisy,Kip and Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Click on App launcher and Right click on any app to get context menu and observe

Actual: Unnecessary separator line is seen below App info on the context menu
Expected: No such issue should be seen

This is a Regression issue as same is working fine in 67.0.3383.0/10550.0.0

@Newcomer: Please confirm the issue
 
ActualContextMenu.png
811 KB View Download
ExpectedContextmenu.png
841 KB View Download
Status: Assigned (was: Untriaged)
Labels: Touch-Friendly-Launcher-Urgent
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0453022ae1a429f8650446cb0aa2b882a1e4c297

commit 0453022ae1a429f8650446cb0aa2b882a1e4c297
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue May 08 22:08:31 2018

cros:Add Actionable Submenu option to AppList extension context menus

Part 2 of "Add Actionable Submenus To Extension App Context Menus"

This part adds the actionable submenu option to the AppList.

Also in this cl:
- Re-ordered function in extension_app_context_menu.cc to match the
  header.
- Fixed a mis-placed separator (incidental fix due to restructuring
  the context menu option ordering).

Bug: 829940
Bug:  830339 
Change-Id: If3f369260b4883206a6014754e08fcbae697b7ae
Reviewed-on: https://chromium-review.googlesource.com/1050406
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556980}
[modify] https://crrev.com/0453022ae1a429f8650446cb0aa2b882a1e4c297/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/0453022ae1a429f8650446cb0aa2b882a1e4c297/chrome/browser/ui/app_list/extension_app_context_menu.cc
[modify] https://crrev.com/0453022ae1a429f8650446cb0aa2b882a1e4c297/chrome/browser/ui/app_list/extension_app_context_menu.h

Status: Fixed (was: Assigned)

Sign in to add a comment