New issue
Advanced search Search tips

Issue 830337 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
sinhak@chromium.org
blundell@chromium.org
pmarko@chromium.org
rockot@google.com
toniki...@chromium.org
jdufault@chromium.org
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Flaky timeouts: WebviewClientCertsLoginTest

Project Member Reported by shimazu@chromium.org, Apr 9 2018 
WebviewClientCertsLoginTest on browser_tests and mus_browser_tests is often timed out.

browser_tests:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebviewClientCertsLoginTest

mus_browser_tests:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=mus_browser_tests&tests=WebviewClientCertsLoginTest

I'll disable the following tests on ASan/LSan.
SigninFrameAuthorityGiven
SigninFrameAuthorityGivenNoMatchingCert
SigninFrameCertNotAutoSelected
SigninFrameIntermediateAuthorityKnown
SigninFrameIntermediateAuthorityUnknown
SigninFrameNoAuthorityGiven

Could you add proper component flags to this issue?
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/386c37acaa0a6e6004de5ca6ff8da880bd7910c5

commit 386c37acaa0a6e6004de5ca6ff8da880bd7910c5
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Apr 09 08:22:06 2018

Disable flaky browser tests: WebviewClientCertsLoginTest on ASan/LSan

This CL is disabling the following tests in WebviewClientCertsLoginTest.

- SigninFrameAuthorityGiven
- SigninFrameAuthorityGivenNoMatchingCert
- SigninFrameCertNotAutoSelected
- SigninFrameIntermediateAuthorityKnown
- SigninFrameIntermediateAuthorityUnknown
- SigninFrameNoAuthorityGiven

TBR=achuith@chromium.org
NOTRY=true

Bug: 830337
Change-Id: I5b7c0817551d360bb4c143bdfa6f537a6d561a0e
Reviewed-on: https://chromium-review.googlesource.com/1002714
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549122}
[modify] https://crrev.com/386c37acaa0a6e6004de5ca6ff8da880bd7910c5/chrome/browser/chromeos/login/webview_login_browsertest.cc

Comment 2 by achuith@chromium.org, Apr 9 2018

Cc: jdufault@chromium.org
Components: Tests>Flaky
Labels: Hotlist-CrOS-Gardener
Owner: michae...@chromium.org
We should see what's timing out (maybe WaitForGaiaPageLoad?), and increase the timeout on ASAN/LSAN

Comment 3 by shimazu@chromium.org, Apr 9 2018

Labels: -Sheriff-Chromium
Thanks for working on this.
Let me remove Sheriff-Chromium flag since the tests are now disabled.

Comment 4 by michae...@chromium.org, Apr 24 2018

Owner: ----
Removing myself. Current/future gardeners can pick up via Hotlist-CrOS-Gardener.

Comment 5 by achuith@chromium.org, Apr 25 2018

Labels: -Pri-1 Pri-3
I think it may be acceptable to just not run these tests on ASAN/LSAN

Comment 6 by hendrich@chromium.org, May 8 2018

Cc: pmarko@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a296794061c657566bc1fa18ff6e5c5ce0ba914

commit 3a296794061c657566bc1fa18ff6e5c5ce0ba914
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Jul 18 00:19:12 2018

Disable WebviewClientCertsLoginTest.SigninFrameCertMultipleFiltersAutoSelected

Bug: 830337
Change-Id: Ica61483028f3cd92787191d3115476f54b5f84c2
Tbr: achuith@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1140798
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575867}
[modify] https://crrev.com/3a296794061c657566bc1fa18ff6e5c5ce0ba914/chrome/browser/chromeos/login/webview_login_browsertest.cc

Comment 9 by toniki...@chromium.org, Nov 29

Cc: sinhak@chromium.org rockot@google.com toniki...@chromium.org blundell@chromium.org
 Issue 909034  has been merged into this issue.
►

Sign in to add a comment