New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830330 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix video encoder flush implementation on RK3288 platform

Project Member Reported by akahuang@chromium.org, Apr 9 2018

Issue description

In  issue 820313 , we check the flush function in VEA unittest. But currently the encoder of RK3288 platform doesn't support flush correctly. We should implement the flush and remove the boards from the blacklist of flush at:

chromiumos/src/third_party/autotest/files/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py "has_broken_flush" method.
 

Comment 1 by tfiga@chromium.org, Apr 9 2018

Components: OS>Kernel>Video
Labels: OS-Chrome

Comment 2 by tfiga@chromium.org, May 10 2018

Labels: media-kernel-backlog
Cc: akahuang@chromium.org
Owner: selcott@chromium.org
Status: Assigned (was: Untriaged)
Hi Sharif,

To support flush, we need to implement V4L2_ENC_CMD_STOP and V4L2_ENC_CMD_START ioctl call.
https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/vidioc-encoder-cmd.html

For rockchip 3288, we probably need to modify at driver or plugin.
These are the CLs we support RK339. You can take a look first.
https://chromium-review.googlesource.com/#/c/939226/
https://chromium-review.googlesource.com/#/c/958725/

After you finish it, you can verify by VEA unittest.
https://sites.google.com/a/google.com/chromeos-video/development#TOC-Run-VEA-test

The detail of the V4L2 Flush and previous issue:
https://docs.google.com/document/d/1Bmbf-E01AGUO7Wesn72e_pKYb5iyE7gk8k84FQ97sS4/edit#heading=h.rldclxpzk5bv
https://b.corp.google.com/issues/71882314
Labels: media-kernel-good-first-bug
Any updates here?

Sign in to add a comment