New issue
Advanced search Search tips

Issue 830317 link

Starred by 1 user
Status: Fixed
Owner:
yamaguchi@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Zip Archiver: Zipping progress notification stops when a target file deleted before zipped.

Project Member Reported by yamaguchi@chromium.org, Apr 9 2018 
Chrome Version: 67.0.3393.0

Steps To Reproduce:
(1) Select multiple large files (about 250MB) under Downloads.
(2) Right-click and choose "zip selection"
(3) While the first file is being zipped, select only the 2nd file and delete it.
(4) Wait until the zipping progress in notification goes up to 50%.

Expected Result:
It should shown an error and cancel zipping.

Actual Result:
It freezes at 50%.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
100%

What is the impact to the user, and is there a workaround? If so, what is
it?
User can still retry zipping files ignoring the notification.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18fb38eb09976bbb51bd3f805224b152eab16b36

commit 18fb38eb09976bbb51bd3f805224b152eab16b36
Author: Tatsuhisa Yamaguchi <yamaguchi@google.com>
Date: Mon Apr 09 09:21:07 2018

Zip Archiver: Handle error on opening a source file.

A file passed to Zip Archiver for packing may be removed before starting
to zip it. It happens, for example, when multiple fils are passed to Zip
Archiver and user removed the file while preceding files are processed.

Bug:  830317 
Test: Manually tested by the repro steps in the bug.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c8682ddf21abc7e11c0e9e7d427890b7093c233
Reviewed-on: https://chromium-review.googlesource.com/1002434
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549134}
[modify] https://crrev.com/18fb38eb09976bbb51bd3f805224b152eab16b36/chrome/browser/resources/chromeos/zip_archiver/js/compressor.js

Comment 2 by yamaguchi@chromium.org, Apr 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment