New issue
Advanced search Search tips

Issue 830291 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 829251
Blocking:
issue 828331



Sign in to add a comment

NetS13nServiceWorker: Fetch events with FetchEvent#body are triggered by SWURLRequestJob

Project Member Reported by shimazu@chromium.org, Apr 9 2018 
At least a test "FetchEvent#body is a string and is passed to network fallback" fails due to a DCHECK:
DCHECK(request_body_blob_uuid_.empty() && request_body_blob_size_ == 0 && !request_body_blob_ && client_id_.empty())

The stack trace shows the request is hooked via SWURLRequestJob even when --enable-features=ServiceWorkerServicification. There might be a flaw somewhere around hooking.

Comment 1 by shimazu@chromium.org, Apr 9 2018 

Stack trace

[93060:93153:0405/163052.218544:FATAL:service_worker_fetch_dispatcher.cc(482)] Check failed: (request_body_blob_uuid_.empty() && request_body_blob_size_ == 0 && !request_body_blob_ && client_id_.empty()). 
#0 0x7fa046c8b40c base::debug::StackTrace::StackTrace()
#1 0x7fa046cb571b logging::LogMessage::~LogMessage()
#2 0x7fa045e272dc content::ServiceWorkerFetchDispatcher::ServiceWorkerFetchDispatcher()
#3 0x7fa045e871d6 content::ServiceWorkerURLRequestJob::RequestBodyFileSizesResolved()
#4 0x7fa045a04dad _ZN4base8internal7InvokerINS0_9BindStateIMN7content12_GLOBAL__N_129CallbackWrapperOnWorkerThreadIFvbEEEFvbEJNS_7WeakPtrIS7_EEEEES6_E7RunOnceEPNS0_13BindStateBaseEb
#5 0x7fa045e890c0 content::ServiceWorkerURLRequestJob::FileSizeResolver::Complete()
#6 0x7fa045e86c7d content::ServiceWorkerURLRequestJob::FileSizeResolver::Resolve()
#7 0x7fa045e86451 content::ServiceWorkerURLRequestJob::StartRequest()
#8 0x7fa0454def04 _ZN4base8internal7InvokerINS0_9BindStateIMN7content12_GLOBAL__N_124QueueingConnectionFilterEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x7fa046c8bd2f base::debug::TaskAnnotator::RunTask()
#10 0x7fa046cc1826 base::internal::IncomingTaskQueue::RunTask()
#11 0x7fa046cc5987 base::MessageLoop::RunTask()
#12 0x7fa046cc5daa base::MessageLoop::DeferOrRunPendingTask()
#13 0x7fa046cc603e base::MessageLoop::DoWork()
#14 0x7fa046cc8cf9 base::MessagePumpLibevent::Run()
#15 0x7fa046cc51fc base::MessageLoop::Run()
#16 0x7fa046cfd876 base::RunLoop::Run()
#17 0x7fa046d3fd4a base::Thread::Run()
#18 0x7fa045a05bc4 content::BrowserProcessSubThread::IOThreadRun()
#19 0x7fa045a05b0f content::BrowserProcessSubThread::Run()
#20 0x7fa046d40344 base::Thread::ThreadMain()
#21 0x7fa046d3bedf base::(anonymous namespace)::ThreadFunc()
#22 0x7fa046ddb494 start_thread
#23 0x7fa03d3e9a8f clone

Comment 2 by shimazu@chromium.org, Apr 24 2018

Blocking: 828331
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316143da2ae63a95c4779aa951af224ce9da6f7e

commit 316143da2ae63a95c4779aa951af224ce9da6f7e
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Apr 25 02:15:57 2018

NetS13nSW: Skip making a handler for subresource requests

Bug:  830291 
Change-Id: I1b1b6fe8c20bd1384e8e01cb9521481b38c4c1cb
Reviewed-on: https://chromium-review.googlesource.com/1025672
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553423}
[modify] https://crrev.com/316143da2ae63a95c4779aa951af224ce9da6f7e/content/browser/service_worker/service_worker_request_handler.cc

Comment 4 by shimazu@chromium.org, May 7 2018

Status: Fixed (was: Available)
►

Sign in to add a comment