[WPT Import] updated testharness.js test (now passing) resulting in incorrectly updated mac baselines that fail in CQ |
|||
Issue descriptionhttps://github.com/w3c/web-platform-tests/pull/10353 changed css/css-variables/variable-cssText.html upstream so that it will now pass in Chromium, but the change is not making it through import. This problem can be seen in builds #15416 through #15429 and is currently blocking import: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15416 https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15429 The reviews: https://chromium-review.googlesource.com/c/chromium/src/+/1000450 https://chromium-review.googlesource.com/c/chromium/src/+/1001695 In the first (1000450) the mac try bot results: https://test-results.appspot.com/data/layout_results/mac10_10_blink_rel/6565/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/mac10_11_blink_rel/6717/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/mac10_12_retina_blink_rel/226/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/mac10_13_blink_rel/409/layout-test-results/results.html Notably, mac10_12_blink_rel (sans retina) seems to note have run layout tests and passed: https://ci.chromium.org/buildbot/tryserver.blink/mac10.12_blink_rel/4420 Seemingly based on this, the existing variable-cssText-expected.txt (alongside test, not platform-specific) was renamed to LayoutTests/platform/mac-mac10.12/external/wpt/css/css-variables/variable-cssText-expected.txt and other all-passing baselines were added for mac-mac10.11 and mac-retina. So the test was not run, but still the fact that the bot passed seems to have been taken to mean that the old expectation was correct for the bot.
,
Apr 8 2018
Actually, let's make it [ Skip ], then it'll definitely make it through import.
,
Apr 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2ad352b955423a885803e00550c57dfa9a2df4 commit 8a2ad352b955423a885803e00550c57dfa9a2df4 Author: Philip Jägenstedt <foolip@chromium.org> Date: Sun Apr 08 20:14:34 2018 Skip external/wpt/css/css-variables/variable-cssText.html To unblock wpt-importer, as this test has been changed upstream (https://github.com/w3c/web-platform-tests/pull/10353) and mac baselines are being incorrectly because of what seems to be a rebaselining bug. Bug: 830270 Change-Id: Idbb86361efcba8511f04ca03577f59e8aa71497b No-Try: true TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1002092 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#549091} [modify] https://crrev.com/8a2ad352b955423a885803e00550c57dfa9a2df4/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/2611ee64e11fb4b398cbf3599bf9d2a28c9b4a0b/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-cssText-expected.txt
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fa89244d74bee7d2e133db27e7cd5284d957133 commit 0fa89244d74bee7d2e133db27e7cd5284d957133 Author: Philip Jägenstedt <foolip@chromium.org> Date: Mon Apr 09 14:45:59 2018 Reenable external/wpt/css/css-variables/variable-cssText.html It was disabled to unblock wpt-importer, and the test change has now been imported and the test should be passing. Bug: 830270 Change-Id: I5049adc3a5225b3feb7e934bcceeb416dd48ea4b Reviewed-on: https://chromium-review.googlesource.com/1002813 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549172} [modify] https://crrev.com/0fa89244d74bee7d2e133db27e7cd5284d957133/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 9 2018
,
Apr 11 2018
There's not much to do here except wait for issue 830629 , but making myself the owner to be poked by rotation :)
,
Apr 11 2018
This should now be fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by foolip@chromium.org
, Apr 8 2018