New issue
Advanced search Search tips

Issue 830255 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836071



Sign in to add a comment

IDL compiler: Update include paths to use absolute path

Project Member Reported by peria@chromium.org, Apr 8 2018

Issue description

After the Great Blink mv ( issue 768828 ), IDL compiler outputs #include's using relative paths.
Let's fix it to meet with the coding style.
 

Comment 1 by tkent@chromium.org, Apr 9 2018

One easy idea is to prepend "third_party/blink/renderer" if a path starts with "bindings" "core" "modules" or "platform" in normalize_and_sort_incldues().

Comment 2 by tkent@chromium.org, Apr 24 2018

Blocking: 836071

Comment 3 by peria@chromium.org, May 3 2018

Cc: dcheng@chromium.org jbroman@chromium.org
 Issue 831106  has been merged into this issue.

Comment 4 by peria@chromium.org, May 3 2018

Blockedon: 839389
Project Member

Comment 5 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6027305a9a5481e0e98ea9905e7dfb3dd3fb9cb

commit a6027305a9a5481e0e98ea9905e7dfb3dd3fb9cb
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon May 14 06:04:26 2018

bindings: Change path of bindings test outputs

Some bindings code generator code depend on the paths of
output directories to generate their contents.
This CL changes the directory to output temporary files
to test, and makes it possible to remove test-only hacks
in code generators.


Bug:  830255 
Change-Id: I67b80489fcb3752679770cb56fa5c442c657b181
Reviewed-on: https://chromium-review.googlesource.com/1056778
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558207}
[modify] https://crrev.com/a6027305a9a5481e0e98ea9905e7dfb3dd3fb9cb/third_party/blink/tools/blinkpy/bindings/bindings_tests.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef846477a1d1d87864b84c2a01de1c798ee72954

commit ef846477a1d1d87864b84c2a01de1c798ee72954
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 14 08:53:24 2018

Qualify #includes in files generated by the IDL compiler except for primary headers.

* normaliza_and_sort_includes():
 - Fix the normalization. The output directory is now
   "gen/third_party/blink/", not "gen/blink/".

 - produce repo-root-relative paths instead of blink-relative paths.

Bug:  830255 ,  842413 
Change-Id: Ia99af5830f3cc67cb25e3e26ff24d0941f38effa
Reviewed-on: https://chromium-review.googlesource.com/1056967
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558228}
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/scripts/code_generator.py
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_string.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/nested_union_type.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/origin_trial_features_for_core.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_double.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived_implemented_as.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_garbage_collected_or_string.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_garbage_collected_or_string.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_data_view.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_attribute_getters.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_attribute_getters.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_garbage_collected.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_garbage_collected.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_node.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.h
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
[modify] https://crrev.com/ef846477a1d1d87864b84c2a01de1c798ee72954/third_party/blink/renderer/bindings
Project Member

Comment 7 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bec680de8c29b3ad012f50d638a17b2318748dc

commit 2bec680de8c29b3ad012f50d638a17b2318748dc
Author: Kent Tamura <tkent@chromium.org>
Date: Tue May 15 04:38:11 2018

bindings: Qualify #includes in generated V8GeneratedCoreBindings.cpp, initPartialInterfacesInModules.cpp, and V8ContextSnapshotExternalReferences.cpp.

Bug:  830255 
Change-Id: I8c833ac805de7e378e5983f204022f7fdc72794e
Reviewed-on: https://chromium-review.googlesource.com/1058870
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558611}
[modify] https://crrev.com/2bec680de8c29b3ad012f50d638a17b2318748dc/third_party/blink/renderer/bindings/scripts/aggregate_generated_bindings.py
[modify] https://crrev.com/2bec680de8c29b3ad012f50d638a17b2318748dc/third_party/blink/renderer/bindings/scripts/generate_init_partial_interfaces.py
[modify] https://crrev.com/2bec680de8c29b3ad012f50d638a17b2318748dc/third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3896403e9f711cd788ef11f2480ed720e4e18c6a

commit 3896403e9f711cd788ef11f2480ed720e4e18c6a
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Tue May 15 07:14:21 2018

bindings: Make CodeGeneratorV8 inheritances use render_templates

To merge common processes into one place, this CL make CodeGeneratorV8
inheritances to use CodeGeneratorBase.render_templates(), which was
renamed from render_template().
This CL also make normalize_and_sort_includes() to use set() type
to avoid include duplicates.


Bug:  830255 
Change-Id: I7e723153930ae55cab04d5a5fdb38b51c3494434
Reviewed-on: https://chromium-review.googlesource.com/1058743
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558634}
[modify] https://crrev.com/3896403e9f711cd788ef11f2480ed720e4e18c6a/third_party/blink/renderer/bindings/scripts/code_generator.py
[modify] https://crrev.com/3896403e9f711cd788ef11f2480ed720e4e18c6a/third_party/blink/renderer/bindings/scripts/code_generator_v8.py

Project Member

Comment 9 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9cced3bd8870af6f1fe4f6aece338c07ef6935

commit 0b9cced3bd8870af6f1fe4f6aece338c07ef6935
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Wed May 16 08:08:34 2018

bindings: Use project rooted paths in include

Before this CL, generated .cc files uses only the filename of
the header file for their first #include.
This CL makes them to use project rooted paths to be consistent
with Chromium coding style.


Bug:  830255 
Change-Id: Ie73d5352b7ab4350fac1b61a1aa55b8e7fee4397
Reviewed-on: https://chromium-review.googlesource.com/1016941
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559010}
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/scripts/code_generator.py
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/scripts/code_generator_web_agent_api.py
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/scripts/code_generator_web_agent_api_test.py
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/DEPS
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_3.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_3.h
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_garbage_collected_or_string.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_attribute_getters.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_garbage_collected.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
[modify] https://crrev.com/0b9cced3bd8870af6f1fe4f6aece338c07ef6935/third_party/blink/renderer/core/css/cssom/element_computed_style_map.h

Comment 10 by peria@chromium.org, May 25 2018

Blockedon: -839389
Labels: Hotlist-Bindings-IDLCompiler
Status: Fixed (was: Assigned)

Sign in to add a comment