New issue
Advanced search Search tips

Issue 830251 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Clipboard Copy swallowing some content

Reported by dezkohor...@gmail.com, Apr 8 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Steps to reproduce the problem:
1. Go to site:
https://stackoverflow.com/questions/45129790/difference-between-http-and-httpclient-in-angular-4
2. Mark and copy to clipboard e.g. the question (don't need to copy also the answers) including points acquired and comments of the question under the question.
3. Then paste it in Libre Office or in the browser in gmail. It should preserve all formatting and text including the comments. But only the question alone is preserved without comments - the comments are swallowed. This problem first occurred on my Android phone Google Chrome and then also on Google Chrome on both the windows 10 PCs.
------
The Copy is working OK in Microsoft Edge browser or in Firefox. But Firefox is damaging the formatting :-). Therefore, only Microsoft Edge is working 100% for me now.
----
If I Copy from Microsoft Edge and then Paste in Google Chrome in gmail or Libre Office, formatting and text is preserved OK.

What is the expected behavior?
If I copy the stackoverflow question It should preserve all content and formatting including comments. Paste in Libre Office or Google Chrome in gmail should preserve formatting and text.

What went wrong?
See the question above, man.

Did this work before? Yes In April 4-th, 2018 it seemed to be working

Chrome version: 65.0.3325.181 (Official Build) (64-bit) (cohort: Stable)  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 27.0 r0
 
Sorry, Firefox is also completely buggy. Only Microsoft Edge is working OK.
Labels: Needs-Bisect Needs-Triage-M65
Cc: susan.boorgula@chromium.org
Components: UI
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET RegressedIn-65 M-66 FoundIn-66 Target-67 Target-66 Target-65 FoundIn-65 FoundIn-67 OS-Linux OS-Mac Pri-1
Owner: futhark@chromium.org
Status: Assigned (was: Unconfirmed)
dezkohorvath@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the latest Canary 67.0.3390.0 and Stable 65.0.3325.181 as per the original comment.

Bisect Information:
===================
Good Build: 65.0.3311.0 (Revision - 526879)
Bad Build : 65.0.3312.0 (Revision - 527163)

On executing the per-revision bisect script, below is the Changelog URL:

https://chromium.googlesource.com/chromium/src/+log/da1fcc66d9bfb143e87d3aa950939efda151b832..27c0ee55811678e4896cf0a07f8c4728bd7a58f2

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/848920

futhark@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding ReleaseBlock-Stable for M-66 as this is a recent regression. Please feel free to remove if it is not applicable.

Thanks.
Reminder: Please note that M66 Stable is only 7 days away. This bug has been marked as ReleaseBlock Stable for M66. So please take a look and appropriately address this bug. 
Gentle ping to get an update on this issue ASAP as M66 stable cut is tomorrow and this bug is marked as stable blocker.

Thanks..!


*stable release
Labels: -M-66 -Target-65 -Target-66 M-67
This has been present since M65. Let's target the fix for 67 instead. 
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c6b2eb72fa636a85f4bb3854c074b5afc09dbe

commit 66c6b2eb72fa636a85f4bb3854c074b5afc09dbe
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Apr 23 07:05:39 2018

Handle display:contents for markup serializer.

We skipped subtree of elements with no LayoutObject, but we need to
include display:contents subtrees.

Bug:  830251 
Change-Id: Ifcfb331f8974b6d2e2e2600e9d29ec13d23bbf3b
Reviewed-on: https://chromium-review.googlesource.com/1021771
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552647}
[modify] https://crrev.com/66c6b2eb72fa636a85f4bb3854c074b5afc09dbe/third_party/blink/renderer/core/editing/serializers/styled_markup_serializer.cc
[modify] https://crrev.com/66c6b2eb72fa636a85f4bb3854c074b5afc09dbe/third_party/blink/renderer/core/editing/serializers/styled_markup_serializer_test.cc

Components: -UI Blink>Editing
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-67
Labels: -Merge-TBD
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 24 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17f7df17e55eea819c7f4503d12accc663d68acf

commit 17f7df17e55eea819c7f4503d12accc663d68acf
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Apr 24 08:30:24 2018

Handle display:contents for markup serializer.

We skipped subtree of elements with no LayoutObject, but we need to
include display:contents subtrees.

Bug:  830251 
Change-Id: Ifcfb331f8974b6d2e2e2600e9d29ec13d23bbf3b
Reviewed-on: https://chromium-review.googlesource.com/1021771
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552647}(cherry picked from commit 66c6b2eb72fa636a85f4bb3854c074b5afc09dbe)
Reviewed-on: https://chromium-review.googlesource.com/1025711
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#252}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/17f7df17e55eea819c7f4503d12accc663d68acf/third_party/blink/renderer/core/editing/serializers/styled_markup_serializer.cc
[modify] https://crrev.com/17f7df17e55eea819c7f4503d12accc663d68acf/third_party/blink/renderer/core/editing/serializers/styled_markup_serializer_test.cc

Sign in to add a comment