New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830206 link

Starred by 12 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

termina: increase limits on open files and inotify

Project Member Reported by smbar...@chromium.org, Apr 7 2018

Issue description

These can't be set by the container, so we should set these on the host.
 

Comment 1 by dinv...@gmail.com, Apr 16 2018

Same here, after setting a new limit in `/etc/sysctl.conf`, `sudo sysctl -p` gives `sysctl: permission denied on key 'fs.inotify.max_user_watches'`

Increasing this limit is needed for normal operation of IDEs/code editors (e.g. IntelliJ and VSCode).

Comment 2 by dgreid@chromium.org, Apr 16 2018

Owner: jkwang@chromium.org
Status: Assigned (was: Untriaged)
jkwang, can you take a look this week? Thanks.
We have an official document that lists optimal values for 
/etc/security/limits.conf and /etc/sysctl.conf:
https://github.com/lxc/lxd/blob/master/doc/production-setup.md

You might want to take a look at these. :)

Comment 4 by dinv...@gmail.com, May 2 2018

Has there been any progress on this front? Thanks

Comment 5 by jkwang@google.com, May 2 2018

Working on a CL.
Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/96e8d80bde6d41c9e62061e5c8518c8e20cc5fda

commit 96e8d80bde6d41c9e62061e5c8518c8e20cc5fda
Author: Jingkui Wang <jkwang@google.com>
Date: Sat May 05 03:37:57 2018

vm_tools: setup resource limits in maitred

This patch setup the limits according to lxd suggestion.

BUG= chromium:830206 
TEST=manual

Change-Id: Ic05922a6502d3a6d9aecfc1ba526c88881042db8
Reviewed-on: https://chromium-review.googlesource.com/1041655
Commit-Ready: Jingkui Wang <jkwang@google.com>
Tested-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/96e8d80bde6d41c9e62061e5c8518c8e20cc5fda/vm_tools/maitred/init.h
[modify] https://crrev.com/96e8d80bde6d41c9e62061e5c8518c8e20cc5fda/vm_tools/maitred/init.cc

Comment 7 by dinv...@gmail.com, May 5 2018

Excellent news, thank you!
Status: Fixed (was: Assigned)
Verified on component version 10669.0.0, which is now live.
Status: Verified (was: Fixed)

Sign in to add a comment