New issue
Advanced search Search tips

Issue 830183 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Stack-overflow in base::ReadFromFD

Project Member Reported by ClusterFuzz, Apr 7 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6070354615992320

Fuzzer: afl_hit_test_manager_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffe4b267ea8
Crash State:
  base::ReadFromFD
  base::RandBytes
  base::UnguessableToken::Create
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=546214:546245

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6070354615992320

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 7 2018

Components: Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 7 2018

Labels: Test-Predator-Auto-Owner
Owner: riajiang@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/337a57b9b3be8a2f7dab252c4d4d90ff44bbc2b3 (Add a fuzzer for HitTestManager and HitTestAggregator.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a49113392b0c716829dcb2cad847a8a210e2a1b

commit 3a49113392b0c716829dcb2cad847a8a210e2a1b
Author: Ria Jiang <riajiang@chromium.org>
Date: Wed Apr 11 22:37:04 2018

Fix stack-overflow in hit_test_manager_fuzzer.

Fix stack-overflow in hit_test_manager_fuzzer by limiting how many
levels of embedding we can have in hit-test data.

Updated coverage report: (still ~98%)
https://goto.google.com/riajiang-hit-test-fuzzer-report-update

Bug:  830183 ,  831028 ,  831029 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I53e2203fe47c94b915a4ad1cfee65b5a3b50cc5d
Reviewed-on: https://chromium-review.googlesource.com/1007963
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549960}
[modify] https://crrev.com/3a49113392b0c716829dcb2cad847a8a210e2a1b/components/viz/service/hit_test/hit_test_manager_fuzzer.cc

Project Member

Comment 4 by ClusterFuzz, Apr 12 2018

ClusterFuzz has detected this issue as fixed in range 549952:549964.

Detailed report: https://clusterfuzz.com/testcase?key=6070354615992320

Fuzzer: afl_hit_test_manager_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffe4b267ea8
Crash State:
  base::ReadFromFD
  base::RandBytes
  base::UnguessableToken::Create
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=546214:546245
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=549952:549964

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6070354615992320

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Apr 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6070354615992320 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment