New issue
Advanced search Search tips

Issue 830182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Some layout tests reference third_party/WebKit/public/platform

Project Member Reported by qyears...@chromium.org, Apr 7 2018

Issue description

Example results:
https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_Leak/17441/layout-test-results/results.html

Example test:
https://chromium.googlesource.com/chromium/src/+/238613f2364a704efa82a4e252f6c2058d7b1924/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html

Related tests to be updated:
http/tests/loading/htxg/resources/htxg-util.js
http/tests/credentialmanager/credentialscontainer-create-origins.html
http/tests/credentialmanager/credentialscontainer-get-errors.html
http/tests/credentialmanager/mock-authenticator.html
http/tests/credentialmanager/credentialscontainer-get-origins.html
http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html
http/tests/credentialmanager/tools/virtual-authenticator-environment-manual.html
http/tests/credentialmanager/register-then-sign.html
http/tests/credentialmanager/resources/publickey-create-helper.html
http/tests/credentialmanager/resources/publickey-get-helper.html
http/tests/credentialmanager/virtual-navigator-credentials.html
http/tests/credentialmanager/credentialscontainer-create-basics.html
http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html
http/tests/credentialmanager/credentialscontainer-get-basics.html
http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html
http/tests/credentialmanager/credentialscontainer-store-basics.html
http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html
http/tests/budget/get-cost.html
http/tests/budget/reserve.html
http/tests/budget/resources/instrumentation-service-worker.js
http/tests/budget/get-budget.html

 
Cc: -qyears...@chromium.org
Owner: qyears...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba75a9c365c659bfa24767f61c669fb5857d657c

commit ba75a9c365c659bfa24767f61c669fb5857d657c
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Sat Apr 07 18:26:25 2018

Update path to public/platform in layout tests

NOTREECHECKS=true
NOTRY=true

Bug:  830182 
Change-Id: Ibdb00d372df47e7d9fb3170c3bd205ef04cebd83
Reviewed-on: https://chromium-review.googlesource.com/1001272
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549066}
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-origins.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/mock-authenticator.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/register-then-sign.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-create-helper.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-get-helper.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/tools/virtual-authenticator-environment-manual.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/virtual-navigator-credentials.html
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-util.js
[modify] https://crrev.com/ba75a9c365c659bfa24767f61c669fb5857d657c/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html

Comment 3 by tkent@chromium.org, Apr 7 2018

Status: Fixed (was: Started)

Sign in to add a comment