New issue
Advanced search Search tips

Issue 830180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

isolate tests failing on win builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 7 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of qyearsley@google.com

isolate tests failing on win builders

Log excerpt:
isolate: isolate C:\b\c\b\win\src\out\Release\blink_platform_unittests.isolate: partitioning deps: GetFileAttributesEx C:\b\c\b\win\src\third_party\blink\LayoutTests\images\resources: The system cannot find the path specified.

Builders failed on: 
- Win Builder: 
  https://build.chromium.org/p/chromium.win/builders/Win%20Builder
- Win x64 Builder: 
  https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder

 
Owner: qyears...@chromium.org
Status: Started (was: Available)
There's a relative path to the layout tests directory, looks like it might need to be updated now (and then updated later when moving layout tests).

https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/BUILD.gn?l=2052
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c0f6d7de7073ed86bb24ab4addc9eb0decbacf

commit 69c0f6d7de7073ed86bb24ab4addc9eb0decbacf
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Sat Apr 07 17:52:05 2018

Update a path to layout tests in blink/renderer/platform/BUILD.gn

NOTRY=true
NOTREECHECKS=true

Bug:  830180 
Change-Id: Ib02e205eb54d19e7e2a5b7531aea0c379dba2703
Reviewed-on: https://chromium-review.googlesource.com/1001252
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549065}
[modify] https://crrev.com/69c0f6d7de7073ed86bb24ab4addc9eb0decbacf/third_party/blink/renderer/platform/BUILD.gn

Comment 3 by tkent@chromium.org, Apr 7 2018

Status: Fixed (was: Started)

Sign in to add a comment